All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] virtio: include asm/barrier explicitly
@ 2013-07-07 14:20 ` Michael S. Tsirkin
  0 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2013-07-07 14:20 UTC (permalink / raw)
  To: kvm; +Cc: Rusty Russell, virtualization, linux-kernel

virtio_ring.h uses mb() and friends, make
it pull in asm/barrier.h itself, not rely
on other headers to do it.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/linux/virtio_ring.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h
index ca3ad41..b300787 100644
--- a/include/linux/virtio_ring.h
+++ b/include/linux/virtio_ring.h
@@ -1,6 +1,7 @@
 #ifndef _LINUX_VIRTIO_RING_H
 #define _LINUX_VIRTIO_RING_H
 
+#include <asm/barrier.h>
 #include <linux/irqreturn.h>
 #include <uapi/linux/virtio_ring.h>
 
-- 
MST

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] virtio: include asm/barrier explicitly
@ 2013-07-07 14:20 ` Michael S. Tsirkin
  0 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2013-07-07 14:20 UTC (permalink / raw)
  To: kvm; +Cc: linux-kernel, virtualization

virtio_ring.h uses mb() and friends, make
it pull in asm/barrier.h itself, not rely
on other headers to do it.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/linux/virtio_ring.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h
index ca3ad41..b300787 100644
--- a/include/linux/virtio_ring.h
+++ b/include/linux/virtio_ring.h
@@ -1,6 +1,7 @@
 #ifndef _LINUX_VIRTIO_RING_H
 #define _LINUX_VIRTIO_RING_H
 
+#include <asm/barrier.h>
 #include <linux/irqreturn.h>
 #include <uapi/linux/virtio_ring.h>
 
-- 
MST

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] virtio: include asm/barrier explicitly
  2013-07-07 14:20 ` Michael S. Tsirkin
@ 2013-07-07 14:21   ` Michael S. Tsirkin
  -1 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2013-07-07 14:21 UTC (permalink / raw)
  To: kvm; +Cc: Rusty Russell, virtualization, linux-kernel

On Sun, Jul 07, 2013 at 05:20:19PM +0300, Michael S. Tsirkin wrote:
> virtio_ring.h uses mb() and friends, make
> it pull in asm/barrier.h itself, not rely
> on other headers to do it.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

In particular this fixes warnings during test build:
[linux]$ make -C tools/virtio/ 
make: Entering directory `/home/mst/scm/linux/tools/virtio'
cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
-fno-strict-overflow -fno-strict-aliasing -fno-common -MMD
-U_FORTIFY_SOURCE   -c -o virtio_test.o virtio_test.c
In file included from ./linux/virtio_ring.h:1:0,
                 from ../../usr/include/linux/vhost.h:17,
                 from virtio_test.c:14:
./linux/../../../include/linux/virtio_ring.h: In function ‘virtio_mb’:
./linux/../../../include/linux/virtio_ring.h:50:2: warning: implicit
declaration of function ‘mb’ [-Wimplicit-function-declaration]


> ---
>  include/linux/virtio_ring.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h
> index ca3ad41..b300787 100644
> --- a/include/linux/virtio_ring.h
> +++ b/include/linux/virtio_ring.h
> @@ -1,6 +1,7 @@
>  #ifndef _LINUX_VIRTIO_RING_H
>  #define _LINUX_VIRTIO_RING_H
>  
> +#include <asm/barrier.h>
>  #include <linux/irqreturn.h>
>  #include <uapi/linux/virtio_ring.h>
>  
> -- 
> MST

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] virtio: include asm/barrier explicitly
@ 2013-07-07 14:21   ` Michael S. Tsirkin
  0 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2013-07-07 14:21 UTC (permalink / raw)
  To: kvm; +Cc: linux-kernel, virtualization

On Sun, Jul 07, 2013 at 05:20:19PM +0300, Michael S. Tsirkin wrote:
> virtio_ring.h uses mb() and friends, make
> it pull in asm/barrier.h itself, not rely
> on other headers to do it.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

In particular this fixes warnings during test build:
[linux]$ make -C tools/virtio/ 
make: Entering directory `/home/mst/scm/linux/tools/virtio'
cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
-fno-strict-overflow -fno-strict-aliasing -fno-common -MMD
-U_FORTIFY_SOURCE   -c -o virtio_test.o virtio_test.c
In file included from ./linux/virtio_ring.h:1:0,
                 from ../../usr/include/linux/vhost.h:17,
                 from virtio_test.c:14:
./linux/../../../include/linux/virtio_ring.h: In function ‘virtio_mb’:
./linux/../../../include/linux/virtio_ring.h:50:2: warning: implicit
declaration of function ‘mb’ [-Wimplicit-function-declaration]


> ---
>  include/linux/virtio_ring.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h
> index ca3ad41..b300787 100644
> --- a/include/linux/virtio_ring.h
> +++ b/include/linux/virtio_ring.h
> @@ -1,6 +1,7 @@
>  #ifndef _LINUX_VIRTIO_RING_H
>  #define _LINUX_VIRTIO_RING_H
>  
> +#include <asm/barrier.h>
>  #include <linux/irqreturn.h>
>  #include <uapi/linux/virtio_ring.h>
>  
> -- 
> MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] virtio: include asm/barrier explicitly
  2013-07-07 14:20 ` Michael S. Tsirkin
@ 2013-07-08  2:01   ` Rusty Russell
  -1 siblings, 0 replies; 8+ messages in thread
From: Rusty Russell @ 2013-07-08  2:01 UTC (permalink / raw)
  To: Michael S. Tsirkin, kvm; +Cc: virtualization, linux-kernel

"Michael S. Tsirkin" <mst@redhat.com> writes:
> virtio_ring.h uses mb() and friends, make
> it pull in asm/barrier.h itself, not rely
> on other headers to do it.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Applied.

Thanks,
Rusty.
PS.  I'll squeeze these into this merge window, since they're trivial.

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] virtio: include asm/barrier explicitly
@ 2013-07-08  2:01   ` Rusty Russell
  0 siblings, 0 replies; 8+ messages in thread
From: Rusty Russell @ 2013-07-08  2:01 UTC (permalink / raw)
  To: Michael S. Tsirkin, kvm; +Cc: linux-kernel, virtualization

"Michael S. Tsirkin" <mst@redhat.com> writes:
> virtio_ring.h uses mb() and friends, make
> it pull in asm/barrier.h itself, not rely
> on other headers to do it.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Applied.

Thanks,
Rusty.
PS.  I'll squeeze these into this merge window, since they're trivial.

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] virtio: include asm/barrier explicitly
  2013-07-08  2:01   ` Rusty Russell
@ 2013-07-08  5:33     ` Stephen Rothwell
  -1 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2013-07-08  5:33 UTC (permalink / raw)
  To: Rusty Russell; +Cc: Michael S. Tsirkin, kvm, virtualization, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

Hi Rusty,

On Mon, 08 Jul 2013 11:31:45 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> PS.  I'll squeeze these into this merge window, since they're trivial.

s/'re trivial/fix bugs/  ;-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] virtio: include asm/barrier explicitly
@ 2013-07-08  5:33     ` Stephen Rothwell
  0 siblings, 0 replies; 8+ messages in thread
From: Stephen Rothwell @ 2013-07-08  5:33 UTC (permalink / raw)
  To: Rusty Russell; +Cc: virtualization, linux-kernel, kvm, Michael S. Tsirkin


[-- Attachment #1.1: Type: text/plain, Size: 277 bytes --]

Hi Rusty,

On Mon, 08 Jul 2013 11:31:45 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> PS.  I'll squeeze these into this merge window, since they're trivial.

s/'re trivial/fix bugs/  ;-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 183 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-07-08  5:33 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-07 14:20 [PATCH] virtio: include asm/barrier explicitly Michael S. Tsirkin
2013-07-07 14:20 ` Michael S. Tsirkin
2013-07-07 14:21 ` Michael S. Tsirkin
2013-07-07 14:21   ` Michael S. Tsirkin
2013-07-08  2:01 ` Rusty Russell
2013-07-08  2:01   ` Rusty Russell
2013-07-08  5:33   ` Stephen Rothwell
2013-07-08  5:33     ` Stephen Rothwell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.