* [ 1/8] libceph: Fix NULL pointer dereference in auth client code
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
@ 2013-07-11 22:20 ` Greg Kroah-Hartman
2013-07-11 22:20 ` [ 2/8] drivers/cdrom/cdrom.c: use kzalloc() for failing hardware Greg Kroah-Hartman
` (9 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-11 22:20 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, stable, Tyler Hicks, Chanam Park,
Seth Arnold, Sage Weil
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Tyler Hicks <tyhicks@canonical.com>
commit 2cb33cac622afde897aa02d3dcd9fbba8bae839e upstream.
A malicious monitor can craft an auth reply message that could cause a
NULL function pointer dereference in the client's kernel.
To prevent this, the auth_none protocol handler needs an empty
ceph_auth_client_ops->build_request() function.
CVE-2013-1059
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Reported-by: Chanam Park <chanam.park@hkpco.kr>
Reviewed-by: Seth Arnold <seth.arnold@canonical.com>
Reviewed-by: Sage Weil <sage@inktank.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
net/ceph/auth_none.c | 6 ++++++
1 file changed, 6 insertions(+)
--- a/net/ceph/auth_none.c
+++ b/net/ceph/auth_none.c
@@ -39,6 +39,11 @@ static int should_authenticate(struct ce
return xi->starting;
}
+static int build_request(struct ceph_auth_client *ac, void *buf, void *end)
+{
+ return 0;
+}
+
/*
* the generic auth code decode the global_id, and we carry no actual
* authenticate state, so nothing happens here.
@@ -107,6 +112,7 @@ static const struct ceph_auth_client_ops
.destroy = destroy,
.is_authenticated = is_authenticated,
.should_authenticate = should_authenticate,
+ .build_request = build_request,
.handle_reply = handle_reply,
.create_authorizer = ceph_auth_none_create_authorizer,
.destroy_authorizer = ceph_auth_none_destroy_authorizer,
^ permalink raw reply [flat|nested] 17+ messages in thread* [ 2/8] drivers/cdrom/cdrom.c: use kzalloc() for failing hardware
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
2013-07-11 22:20 ` [ 1/8] libceph: Fix NULL pointer dereference in auth client code Greg Kroah-Hartman
@ 2013-07-11 22:20 ` Greg Kroah-Hartman
2013-07-11 22:20 ` [ 3/8] hpfs: better test for errors Greg Kroah-Hartman
` (8 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-11 22:20 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, stable, Dan Carpenter, Jens Axboe,
Andrew Morton, Linus Torvalds, Jonathan Salwan, Luis Henriques
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jonathan Salwan <jonathan.salwan@gmail.com>
commit 542db01579fbb7ea7d1f7bb9ddcef1559df660b2 upstream.
In drivers/cdrom/cdrom.c mmc_ioctl_cdrom_read_data() allocates a memory
area with kmalloc in line 2885.
2885 cgc->buffer = kmalloc(blocksize, GFP_KERNEL);
2886 if (cgc->buffer == NULL)
2887 return -ENOMEM;
In line 2908 we can find the copy_to_user function:
2908 if (!ret && copy_to_user(arg, cgc->buffer, blocksize))
The cgc->buffer is never cleaned and initialized before this function.
If ret = 0 with the previous basic block, it's possible to display some
memory bytes in kernel space from userspace.
When we read a block from the disk it normally fills the ->buffer but if
the drive is malfunctioning there is a chance that it would only be
partially filled. The result is an leak information to userspace.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jonathan Salwan <jonathan.salwan@gmail.com>
Cc: Luis Henriques <luis.henriques@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/cdrom/cdrom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -2879,7 +2879,7 @@ static noinline int mmc_ioctl_cdrom_read
if (lba < 0)
return -EINVAL;
- cgc->buffer = kmalloc(blocksize, GFP_KERNEL);
+ cgc->buffer = kzalloc(blocksize, GFP_KERNEL);
if (cgc->buffer == NULL)
return -ENOMEM;
^ permalink raw reply [flat|nested] 17+ messages in thread* [ 3/8] hpfs: better test for errors
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
2013-07-11 22:20 ` [ 1/8] libceph: Fix NULL pointer dereference in auth client code Greg Kroah-Hartman
2013-07-11 22:20 ` [ 2/8] drivers/cdrom/cdrom.c: use kzalloc() for failing hardware Greg Kroah-Hartman
@ 2013-07-11 22:20 ` Greg Kroah-Hartman
2013-07-11 22:20 ` [ 4/8] block: do not pass disk names as format strings Greg Kroah-Hartman
` (7 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-11 22:20 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg Kroah-Hartman, stable, Mikulas Patocka, Linus Torvalds
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
commit 3ebacb05044f82c5f0bb456a894eb9dc57d0ed90 upstream.
The test if bitmap access is out of bound could errorneously pass if the
device size is divisible by 16384 sectors and we are asking for one bitmap
after the end.
Check for invalid size in the superblock. Invalid size could cause integer
overflows in the rest of the code.
Signed-off-by: Mikulas Patocka <mpatocka@artax.karlin.mff.cuni.cz>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
fs/hpfs/map.c | 3 ++-
fs/hpfs/super.c | 8 +++++++-
2 files changed, 9 insertions(+), 2 deletions(-)
--- a/fs/hpfs/map.c
+++ b/fs/hpfs/map.c
@@ -17,7 +17,8 @@ unsigned int *hpfs_map_bitmap(struct sup
struct quad_buffer_head *qbh, char *id)
{
secno sec;
- if (hpfs_sb(s)->sb_chk) if (bmp_block * 16384 > hpfs_sb(s)->sb_fs_size) {
+ unsigned n_bands = (hpfs_sb(s)->sb_fs_size + 0x3fff) >> 14;
+ if (hpfs_sb(s)->sb_chk) if (bmp_block >= n_bands) {
hpfs_error(s, "hpfs_map_bitmap called with bad parameter: %08x at %s", bmp_block, id);
return NULL;
}
--- a/fs/hpfs/super.c
+++ b/fs/hpfs/super.c
@@ -553,7 +553,13 @@ static int hpfs_fill_super(struct super_
sbi->sb_cp_table = NULL;
sbi->sb_c_bitmap = -1;
sbi->sb_max_fwd_alloc = 0xffffff;
-
+
+ if (sbi->sb_fs_size >= 0x80000000) {
+ hpfs_error(s, "invalid size in superblock: %08x",
+ (unsigned)sbi->sb_fs_size);
+ goto bail4;
+ }
+
/* Load bitmap directory */
if (!(sbi->sb_bmp_dir = hpfs_load_bitmap_directory(s, le32_to_cpu(superblock->bitmaps))))
goto bail4;
^ permalink raw reply [flat|nested] 17+ messages in thread* [ 4/8] block: do not pass disk names as format strings
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
` (2 preceding siblings ...)
2013-07-11 22:20 ` [ 3/8] hpfs: better test for errors Greg Kroah-Hartman
@ 2013-07-11 22:20 ` Greg Kroah-Hartman
2013-07-11 22:20 ` Greg Kroah-Hartman
` (6 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-11 22:20 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, stable, Kees Cook, Jens Axboe, Andrew Morton,
Linus Torvalds
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kees Cook <keescook@chromium.org>
commit ffc8b30866879ed9ba62bd0a86fecdbd51cd3d19 upstream.
Disk names may contain arbitrary strings, so they must not be
interpreted as format strings. It seems that only md allows arbitrary
strings to be used for disk names, but this could allow for a local
memory corruption from uid 0 into ring 0.
CVE-2013-2851
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
block/genhd.c | 2 +-
drivers/block/nbd.c | 3 ++-
drivers/scsi/osd/osd_uld.c | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -518,7 +518,7 @@ void register_disk(struct gendisk *disk)
ddev->parent = disk->driverfs_dev;
- dev_set_name(ddev, disk->disk_name);
+ dev_set_name(ddev, "%s", disk->disk_name);
/* delay uevents, until we scanned partition table */
dev_set_uevent_suppress(ddev, 1);
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -658,7 +658,8 @@ static int __nbd_ioctl(struct block_devi
mutex_unlock(&lo->tx_lock);
- thread = kthread_create(nbd_thread, lo, lo->disk->disk_name);
+ thread = kthread_create(nbd_thread, lo, "%s",
+ lo->disk->disk_name);
if (IS_ERR(thread)) {
mutex_lock(&lo->tx_lock);
return PTR_ERR(thread);
--- a/drivers/scsi/osd/osd_uld.c
+++ b/drivers/scsi/osd/osd_uld.c
@@ -465,7 +465,7 @@ static int osd_probe(struct device *dev)
oud->class_dev.class = &osd_uld_class;
oud->class_dev.parent = dev;
oud->class_dev.release = __remove;
- error = dev_set_name(&oud->class_dev, disk->disk_name);
+ error = dev_set_name(&oud->class_dev, "%s", disk->disk_name);
if (error) {
OSD_ERR("dev_set_name failed => %d\n", error);
goto err_put_cdev;
^ permalink raw reply [flat|nested] 17+ messages in thread* [ 5/8] crypto: sanitize argument for format string
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
@ 2013-07-11 22:20 ` Greg Kroah-Hartman
2013-07-11 22:20 ` [ 2/8] drivers/cdrom/cdrom.c: use kzalloc() for failing hardware Greg Kroah-Hartman
` (9 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-11 22:20 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, stable, Kees Cook, Herbert Xu,
David S. Miller, Andrew Morton, Linus Torvalds
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kees Cook <keescook@chromium.org>
commit 1c8fca1d92e14859159a82b8a380d220139b7344 upstream.
The template lookup interface does not provide a way to use format
strings, so make sure that the interface cannot be abused accidentally.
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
crypto/algapi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/crypto/algapi.c
+++ b/crypto/algapi.c
@@ -478,7 +478,8 @@ static struct crypto_template *__crypto_
struct crypto_template *crypto_lookup_template(const char *name)
{
- return try_then_request_module(__crypto_lookup_template(name), name);
+ return try_then_request_module(__crypto_lookup_template(name), "%s",
+ name);
}
EXPORT_SYMBOL_GPL(crypto_lookup_template);
^ permalink raw reply [flat|nested] 17+ messages in thread* [ 5/8] crypto: sanitize argument for format string
@ 2013-07-11 22:20 ` Greg Kroah-Hartman
0 siblings, 0 replies; 17+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-11 22:20 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, stable, Kees Cook, Herbert Xu,
David S. Miller, Andrew Morton, Linus Torvalds
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Kees Cook <keescook@chromium.org>
commit 1c8fca1d92e14859159a82b8a380d220139b7344 upstream.
The template lookup interface does not provide a way to use format
strings, so make sure that the interface cannot be abused accidentally.
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
crypto/algapi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/crypto/algapi.c
+++ b/crypto/algapi.c
@@ -478,7 +478,8 @@ static struct crypto_template *__crypto_
struct crypto_template *crypto_lookup_template(const char *name)
{
- return try_then_request_module(__crypto_lookup_template(name), name);
+ return try_then_request_module(__crypto_lookup_template(name), "%s",
+ name);
}
EXPORT_SYMBOL_GPL(crypto_lookup_template);
^ permalink raw reply [flat|nested] 17+ messages in thread
* [ 6/8] MAINTAINERS: add stable_kernel_rules.txt to stable maintainer information
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
` (4 preceding siblings ...)
2013-07-11 22:20 ` Greg Kroah-Hartman
@ 2013-07-11 22:20 ` Greg Kroah-Hartman
2013-07-12 3:36 ` Ben Hutchings
2013-07-11 22:20 ` [ 7/8] nfsd4: fix decoding of compounds across page boundaries Greg Kroah-Hartman
` (4 subsequent siblings)
10 siblings, 1 reply; 17+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-11 22:20 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg Kroah-Hartman, stable, David Howells
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
commit 7b175c46720f8e6b92801bb634c93d1016f80c62 upstream.
This hopefully will help point developers to the proper way that patches
should be submitted for inclusion in the stable kernel releases.
Reported-by: David Howells <dhowells@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5725,6 +5725,7 @@ P: Vincent Sanders <vince@simtec.co.uk>
M: Simtec Linux Team <linux@simtec.co.uk>
W: http://www.simtec.co.uk/products/EB110ATX/
S: Supported
+F: Documentation/stable_kernel_rules.txt
SIMTEC EB2410ITX (BAST)
P: Ben Dooks
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [ 6/8] MAINTAINERS: add stable_kernel_rules.txt to stable maintainer information
2013-07-11 22:20 ` [ 6/8] MAINTAINERS: add stable_kernel_rules.txt to stable maintainer information Greg Kroah-Hartman
@ 2013-07-12 3:36 ` Ben Hutchings
2013-07-12 3:48 ` Greg Kroah-Hartman
0 siblings, 1 reply; 17+ messages in thread
From: Ben Hutchings @ 2013-07-12 3:36 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, stable, David Howells
[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]
On Thu, 2013-07-11 at 15:20 -0700, Greg Kroah-Hartman wrote:
> 3.0-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> commit 7b175c46720f8e6b92801bb634c93d1016f80c62 upstream.
>
> This hopefully will help point developers to the proper way that patches
> should be submitted for inclusion in the stable kernel releases.
>
> Reported-by: David Howells <dhowells@redhat.com>
> Acked-by: David Howells <dhowells@redhat.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5725,6 +5725,7 @@ P: Vincent Sanders <vince@simtec.co.uk>
> M: Simtec Linux Team <linux@simtec.co.uk>
> W: http://www.simtec.co.uk/products/EB110ATX/
> S: Supported
> +F: Documentation/stable_kernel_rules.txt
You've applied this in the wrong place for some reason.
Ben.
>
> SIMTEC EB2410ITX (BAST)
> P: Ben Dooks
--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [ 6/8] MAINTAINERS: add stable_kernel_rules.txt to stable maintainer information
2013-07-12 3:36 ` Ben Hutchings
@ 2013-07-12 3:48 ` Greg Kroah-Hartman
0 siblings, 0 replies; 17+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-12 3:48 UTC (permalink / raw)
To: Ben Hutchings; +Cc: linux-kernel, stable, David Howells
On Fri, Jul 12, 2013 at 04:36:00AM +0100, Ben Hutchings wrote:
> On Thu, 2013-07-11 at 15:20 -0700, Greg Kroah-Hartman wrote:
> > 3.0-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > commit 7b175c46720f8e6b92801bb634c93d1016f80c62 upstream.
> >
> > This hopefully will help point developers to the proper way that patches
> > should be submitted for inclusion in the stable kernel releases.
> >
> > Reported-by: David Howells <dhowells@redhat.com>
> > Acked-by: David Howells <dhowells@redhat.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > ---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -5725,6 +5725,7 @@ P: Vincent Sanders <vince@simtec.co.uk>
> > M: Simtec Linux Team <linux@simtec.co.uk>
> > W: http://www.simtec.co.uk/products/EB110ATX/
> > S: Supported
> > +F: Documentation/stable_kernel_rules.txt
>
> You've applied this in the wrong place for some reason.
Ick, patch did something odd there, thanks, I'll go fix it up and see if
3.4 is ok too.
greg k-h
^ permalink raw reply [flat|nested] 17+ messages in thread
* [ 7/8] nfsd4: fix decoding of compounds across page boundaries
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
` (5 preceding siblings ...)
2013-07-11 22:20 ` [ 6/8] MAINTAINERS: add stable_kernel_rules.txt to stable maintainer information Greg Kroah-Hartman
@ 2013-07-11 22:20 ` Greg Kroah-Hartman
2013-07-11 22:20 ` [ 8/8] SCSI: sd: Fix parsing of temporary cache mode prefix Greg Kroah-Hartman
` (3 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-11 22:20 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg Kroah-Hartman, stable, Rick Macklem, J. Bruce Fields
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: "J. Bruce Fields" <bfields@redhat.com>
commit 247500820ebd02ad87525db5d9b199e5b66f6636 upstream.
A freebsd NFSv4.0 client was getting rare IO errors expanding a tarball.
A network trace showed the server returning BAD_XDR on the final getattr
of a getattr+write+getattr compound. The final getattr started on a
page boundary.
I believe the Linux client ignores errors on the post-write getattr, and
that that's why we haven't seen this before.
Reported-by: Rick Macklem <rmacklem@uoguelph.ca>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
fs/nfsd/nfs4xdr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -159,8 +159,8 @@ static __be32 *read_buf(struct nfsd4_com
*/
memcpy(p, argp->p, avail);
/* step to next page */
- argp->p = page_address(argp->pagelist[0]);
argp->pagelist++;
+ argp->p = page_address(argp->pagelist[0]);
if (argp->pagelen < PAGE_SIZE) {
argp->end = argp->p + (argp->pagelen>>2);
argp->pagelen = 0;
^ permalink raw reply [flat|nested] 17+ messages in thread* [ 8/8] SCSI: sd: Fix parsing of temporary cache mode prefix
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
` (6 preceding siblings ...)
2013-07-11 22:20 ` [ 7/8] nfsd4: fix decoding of compounds across page boundaries Greg Kroah-Hartman
@ 2013-07-11 22:20 ` Greg Kroah-Hartman
2013-07-12 13:54 ` [ 0/8] 3.0.86-stable review Guenter Roeck
` (2 subsequent siblings)
10 siblings, 0 replies; 17+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-11 22:20 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg Kroah-Hartman, stable, Ben Hutchings, James Bottomley
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ben Hutchings <ben@decadent.org.uk>
commit 2ee3e26c673e75c05ef8b914f54fadee3d7b9c88 upstream.
Commit 39c60a0948cc '[SCSI] sd: fix array cache flushing bug causing
performance problems' added temp as a pointer to "temporary " and used
sizeof(temp) - 1 as its length. But sizeof(temp) is the size of the
pointer, not the size of the string constant. Change temp to a static
array so that sizeof() does what was intended.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/scsi/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -138,7 +138,7 @@ sd_store_cache_type(struct device *dev,
char *buffer_data;
struct scsi_mode_data data;
struct scsi_sense_hdr sshdr;
- const char *temp = "temporary ";
+ static const char temp[] = "temporary ";
int len;
if (sdp->type != TYPE_DISK)
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [ 0/8] 3.0.86-stable review
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
` (7 preceding siblings ...)
2013-07-11 22:20 ` [ 8/8] SCSI: sd: Fix parsing of temporary cache mode prefix Greg Kroah-Hartman
@ 2013-07-12 13:54 ` Guenter Roeck
2013-07-12 17:29 ` Greg Kroah-Hartman
2013-07-12 17:22 ` Shuah Khan
2013-07-13 4:17 ` Satoru Takeuchi
10 siblings, 1 reply; 17+ messages in thread
From: Guenter Roeck @ 2013-07-12 13:54 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, torvalds, akpm, stable
On Thu, Jul 11, 2013 at 03:20:29PM -0700, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 3.0.86 release.
> There are 8 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat Jul 13 22:18:05 UTC 2013.
> Anything received after that time might be too late.
>
Build results are as follows. No changes from previous version.
Guenter
---
Build reference: v3.0.85-8-gfe7e43b
Build x86_64:defconfig passed
Build x86_64:allyesconfig passed
Build x86_64:allmodconfig passed
Build x86_64:allnoconfig passed
Build x86_64:alldefconfig passed
Build i386:defconfig passed
Build i386:allyesconfig passed
Build i386:allmodconfig passed
Build i386:allnoconfig passed
Build i386:alldefconfig passed
Build mips:defconfig passed
Build mips:bcm47xx_defconfig passed
Build mips:bcm63xx_defconfig passed
Build mips:ar7_defconfig passed
Build mips:fuloong2e_defconfig passed
Build mips:e55_defconfig passed
Build mips:powertv_defconfig passed
Build mips:malta_defconfig passed
Build powerpc:defconfig failed
Build powerpc:allyesconfig failed
Build powerpc:allmodconfig failed
Build powerpc:maple_defconfig failed
Build powerpc:ppc6xx_defconfig passed
Build powerpc:mpc83xx_defconfig passed
Build powerpc:mpc85xx_defconfig passed
Build powerpc:mpc85xx_smp_defconfig passed
Build powerpc:tqm8xx_defconfig passed
Build powerpc:85xx/sbc8548_defconfig passed
Build powerpc:83xx/mpc834x_mds_defconfig passed
Build powerpc:86xx/sbc8641d_defconfig passed
Build arm:defconfig passed
Build arm:allyesconfig failed
Build arm:allmodconfig failed
Build arm:exynos4_defconfig passed
Build arm:kirkwood_defconfig passed
Build arm:omap2plus_defconfig passed
Build arm:tegra_defconfig passed
Build arm:u8500_defconfig failed
Build arm:ap4evb_defconfig passed
Build arm:pxa910_defconfig passed
Build m68k:defconfig passed
Build m68k:m5272c3_defconfig failed
Build m68k:m5307c3_defconfig failed
Build m68k:m5249evb_defconfig failed
Build m68k:m5407c3_defconfig failed
Build m68k:sun3_defconfig passed
Build sparc:defconfig passed
Build sparc:sparc64_defconfig passed
Build xtensa:defconfig failed
Build xtensa:iss_defconfig failed
Build microblaze:mmu_defconfig failed
Build microblaze:nommu_defconfig failed
Build blackfin:defconfig failed
Build parisc:defconfig failed
-----------------------
Total builds: 54 Total build errors: 17
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [ 0/8] 3.0.86-stable review
2013-07-12 13:54 ` [ 0/8] 3.0.86-stable review Guenter Roeck
@ 2013-07-12 17:29 ` Greg Kroah-Hartman
0 siblings, 0 replies; 17+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-12 17:29 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-kernel, torvalds, akpm, stable
On Fri, Jul 12, 2013 at 06:54:43AM -0700, Guenter Roeck wrote:
> On Thu, Jul 11, 2013 at 03:20:29PM -0700, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 3.0.86 release.
> > There are 8 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat Jul 13 22:18:05 UTC 2013.
> > Anything received after that time might be too late.
> >
> Build results are as follows. No changes from previous version.
Thanks for testing and letting me know.
greg k-h
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [ 0/8] 3.0.86-stable review
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
` (8 preceding siblings ...)
2013-07-12 13:54 ` [ 0/8] 3.0.86-stable review Guenter Roeck
@ 2013-07-12 17:22 ` Shuah Khan
2013-07-13 4:17 ` Satoru Takeuchi
10 siblings, 0 replies; 17+ messages in thread
From: Shuah Khan @ 2013-07-12 17:22 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, torvalds, akpm, stable, Shuah Khan, shuahkhan
On 07/11/2013 05:44 PM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 3.0.86 release.
> There are 8 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat Jul 13 22:18:05 UTC 2013.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> kernel.org/pub/linux/kernel/v3.0/stable-review/patch-3.0.86-rc1.gz
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> -------------
Patches applied cleanly to 3.0.85, 3.4.52, 3.9.9, and 3.10
Compiled and booted on the following systems:
Samsung Series 9 900X4C Intel Corei5:
(3.4.53-rc1, 3.9.10-rc1, 3.10.1-rc1)
HP ProBook 6475b AMD A10-4600M APU with Radeon(tm) HD Graphics:
(3.0.86-rc1, 3.4.53-rc1, 3.9.10-rc1, and 3.10.1-rc1)
dmesgs for all releases look good. No regressions compared to the
previous dmesgs for each of these releases. dmesg emerg, crit, alert,
err are clean. No regressions in warn.
Cross-compile testing:
HP Compaq dc7700 SFF desktop: x86-64 Intel Core-i2:
(3.0.86-rc1, 3.4.53-rc1, 3.9.10-rc1, and 3.10.1-rc1)
Cross-compile tests results:
alpha: defconfig passed on all
arm: defconfig passed on all
arm64: not applicable to 3.0.y, 3.4.y. defconfig passed on 3.9.y, and 3.10.y
c6x: not applicable to 3.0.y, defconfig passed on 3.4.y, 3.9.y, and 3.10.y
mips: defconfig passed on all
mipsel: defconfig passed on all
powerpc: wii_defconfig passed on all
sh: defconfig passed on all
sparc: defconfig passed on all
tile: tilegx_defconfig passed on all
-- Shuah
Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research
America (Silicon Valley) shuah.kh@samsung.com | (970) 672-0658
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [ 0/8] 3.0.86-stable review
2013-07-11 22:20 [ 0/8] 3.0.86-stable review Greg Kroah-Hartman
` (9 preceding siblings ...)
2013-07-12 17:22 ` Shuah Khan
@ 2013-07-13 4:17 ` Satoru Takeuchi
2013-07-13 4:48 ` Greg Kroah-Hartman
10 siblings, 1 reply; 17+ messages in thread
From: Satoru Takeuchi @ 2013-07-13 4:17 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, torvalds, akpm, stable
At Thu, 11 Jul 2013 15:20:29 -0700,
Greg Kroah-Hartman wrote:
>
> This is the start of the stable review cycle for the 3.0.86 release.
> There are 8 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat Jul 13 22:18:05 UTC 2013.
> Anything received after that time might be too late.
This kernel can be built and boot without any problem.
Building a kernel with this kernel also works fine.
- Build Machine: debian jessy x86_64
CPU: Intel(R) Core(TM) i5-2400 CPU @ 3.10GHz x 4
memory: 8GB
- Test machine: debian jessy x86_64(KVM guest on the Build Machine)
vCPU: x2
memory: 2GB
Thanks,
Satoru
>
> The whole patch series can be found in one patch at:
> kernel.org/pub/linux/kernel/v3.0/stable-review/patch-3.0.86-rc1.gz
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> -------------
> Pseudo-Shortlog of commits:
>
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Linux 3.0.86-rc1
>
> Ben Hutchings <ben@decadent.org.uk>
> SCSI: sd: Fix parsing of 'temporary ' cache mode prefix
>
> J. Bruce Fields <bfields@redhat.com>
> nfsd4: fix decoding of compounds across page boundaries
>
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> MAINTAINERS: add stable_kernel_rules.txt to stable maintainer information
>
> Kees Cook <keescook@chromium.org>
> crypto: sanitize argument for format string
>
> Kees Cook <keescook@chromium.org>
> block: do not pass disk names as format strings
>
> Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
> hpfs: better test for errors
>
> Jonathan Salwan <jonathan.salwan@gmail.com>
> drivers/cdrom/cdrom.c: use kzalloc() for failing hardware
>
> Tyler Hicks <tyhicks@canonical.com>
> libceph: Fix NULL pointer dereference in auth client code
>
>
> -------------
>
> Diffstat:
>
> MAINTAINERS | 1 +
> Makefile | 4 ++--
> block/genhd.c | 2 +-
> crypto/algapi.c | 3 ++-
> drivers/block/nbd.c | 3 ++-
> drivers/cdrom/cdrom.c | 2 +-
> drivers/scsi/osd/osd_uld.c | 2 +-
> drivers/scsi/sd.c | 2 +-
> fs/hpfs/map.c | 3 ++-
> fs/hpfs/super.c | 8 +++++++-
> fs/nfsd/nfs4xdr.c | 2 +-
> net/ceph/auth_none.c | 6 ++++++
> 12 files changed, 27 insertions(+), 11 deletions(-)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [ 0/8] 3.0.86-stable review
2013-07-13 4:17 ` Satoru Takeuchi
@ 2013-07-13 4:48 ` Greg Kroah-Hartman
0 siblings, 0 replies; 17+ messages in thread
From: Greg Kroah-Hartman @ 2013-07-13 4:48 UTC (permalink / raw)
To: Satoru Takeuchi; +Cc: linux-kernel, torvalds, akpm, stable
On Sat, Jul 13, 2013 at 01:17:36PM +0900, Satoru Takeuchi wrote:
> At Thu, 11 Jul 2013 15:20:29 -0700,
> Greg Kroah-Hartman wrote:
> >
> > This is the start of the stable review cycle for the 3.0.86 release.
> > There are 8 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat Jul 13 22:18:05 UTC 2013.
> > Anything received after that time might be too late.
>
> This kernel can be built and boot without any problem.
> Building a kernel with this kernel also works fine.
>
> - Build Machine: debian jessy x86_64
> CPU: Intel(R) Core(TM) i5-2400 CPU @ 3.10GHz x 4
> memory: 8GB
>
> - Test machine: debian jessy x86_64(KVM guest on the Build Machine)
> vCPU: x2
> memory: 2GB
Thanks for testing all 4 of these releases and letting me know.
greg k-h
^ permalink raw reply [flat|nested] 17+ messages in thread