Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Michael Holzheu]

> On Tue, Jul 16, 2013 at 06:18:10PM +0200, Michael Holzheu wrote:
> > Hello Andrew,
> >
> > Here a new kdump patch series that we have discussed with Vivek and
> > Hatayama during the last months.
> >
> > Besides of the feature described below, this patch series also fixes a
> > regression on s390 that was introduced with the mmap patches for
> > /proc/vmcore (git commit 83086978c63afd7c73e1c).
> >
> > See also:
> > http://lists.infradead.org/pipermail/kexec/2013-July/009287.html
> >
> > Is it somehow possible to integrate this patch series into 3.11?
> 
> Hi Andrew,
> 
> Now /proc/vmcore mmap() patches are in but looks like they will break
> s390 kdump. mmap() patches use vmalloc() to allocate memory for elf
> notes and then use read_from_oldmem() to copy notes data from old
> memory to this newly allocated buffer. read_from_oldmem() in turn
> uses arch dependent copy_from_oldmem() function.
> 
> Look like on s390, copy_from_oldmem() can not copy data to vmalloc()
> space as they drop to real mode.
> 
> As allocating elf notes code is common both for mmap() and read() path,
> it will break kdump on s390.
> 
> Michael has done some cleanups to cope with that but in the process
> he has also stuffed in the support for zfcpdump and how to deal with
> HSA region etc. (I am not very happy about it though now. s390 seems
> to be having so may special case modes and swap logic etc that it
> is becoming hard to keep track what they are doing. I wished s390
> first did some cleanup w.r.t swap logic and deal with mmap() in pure
> kdump mode and then worry about taking care of zfcpdump).
> 
> Is it possible to push this series in 3.11 now? I suspect it is late now.
> Otherwise we might have to revert mmap() patches as in current form
> they will break s390 kdump.
> 
> Michael, Hatayama, in case this series can't go in 3.11, do you have other
> ideas where a small hack fix will allow kdump to work on s390 and we
> don't have to revert the mmap() patches.

Sure, we can somehow change the copy_from_oldmem() function that it
can copy to virtual memory. We have already discussed some options
on how to do that. Not nice but probably doable.

And we could either disable mmap for s390 by removing mmap_vmcore()
from the proc_vmcore_operations or push the also already discussed
ELF header swap trick in 3.11.

But this is all additional effort now and would not be necessary if we
integrate this patch series in 3.11.

Perhaps we should let Andrew decide here.

Michael

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Michael Holzheu]

> On Tue, Jul 16, 2013 at 06:18:10PM +0200, Michael Holzheu wrote:
> > Hello Andrew,
> >
> > Here a new kdump patch series that we have discussed with Vivek and
> > Hatayama during the last months.
> >
> > Besides of the feature described below, this patch series also fixes a
> > regression on s390 that was introduced with the mmap patches for
> > /proc/vmcore (git commit 83086978c63afd7c73e1c).
> >
> > See also:
> > http://lists.infradead.org/pipermail/kexec/2013-July/009287.html
> >
> > Is it somehow possible to integrate this patch series into 3.11?
> 
> Hi Andrew,
> 
> Now /proc/vmcore mmap() patches are in but looks like they will break
> s390 kdump. mmap() patches use vmalloc() to allocate memory for elf
> notes and then use read_from_oldmem() to copy notes data from old
> memory to this newly allocated buffer. read_from_oldmem() in turn
> uses arch dependent copy_from_oldmem() function.
> 
> Look like on s390, copy_from_oldmem() can not copy data to vmalloc()
> space as they drop to real mode.
> 
> As allocating elf notes code is common both for mmap() and read() path,
> it will break kdump on s390.
> 
> Michael has done some cleanups to cope with that but in the process
> he has also stuffed in the support for zfcpdump and how to deal with
> HSA region etc. (I am not very happy about it though now. s390 seems
> to be having so may special case modes and swap logic etc that it
> is becoming hard to keep track what they are doing. I wished s390
> first did some cleanup w.r.t swap logic and deal with mmap() in pure
> kdump mode and then worry about taking care of zfcpdump).
> 
> Is it possible to push this series in 3.11 now? I suspect it is late now.
> Otherwise we might have to revert mmap() patches as in current form
> they will break s390 kdump.
> 
> Michael, Hatayama, in case this series can't go in 3.11, do you have other
> ideas where a small hack fix will allow kdump to work on s390 and we
> don't have to revert the mmap() patches.

Sure, we can somehow change the copy_from_oldmem() function that it
can copy to virtual memory. We have already discussed some options
on how to do that. Not nice but probably doable.

And we could either disable mmap for s390 by removing mmap_vmcore()
from the proc_vmcore_operations or push the also already discussed
ELF header swap trick in 3.11.

But this is all additional effort now and would not be necessary if we
integrate this patch series in 3.11.

Perhaps we should let Andrew decide here.

Michael


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Vivek Goyal]

On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> > On Tue, Jul 16, 2013 at 06:18:10PM +0200, Michael Holzheu wrote:
> > > Hello Andrew,
> > >
> > > Here a new kdump patch series that we have discussed with Vivek and
> > > Hatayama during the last months.
> > >
> > > Besides of the feature described below, this patch series also fixes a
> > > regression on s390 that was introduced with the mmap patches for
> > > /proc/vmcore (git commit 83086978c63afd7c73e1c).
> > >
> > > See also:
> > > http://lists.infradead.org/pipermail/kexec/2013-July/009287.html
> > >
> > > Is it somehow possible to integrate this patch series into 3.11?
> > 
> > Hi Andrew,
> > 
> > Now /proc/vmcore mmap() patches are in but looks like they will break
> > s390 kdump. mmap() patches use vmalloc() to allocate memory for elf
> > notes and then use read_from_oldmem() to copy notes data from old
> > memory to this newly allocated buffer. read_from_oldmem() in turn
> > uses arch dependent copy_from_oldmem() function.
> > 
> > Look like on s390, copy_from_oldmem() can not copy data to vmalloc()
> > space as they drop to real mode.
> > 
> > As allocating elf notes code is common both for mmap() and read() path,
> > it will break kdump on s390.
> > 
> > Michael has done some cleanups to cope with that but in the process
> > he has also stuffed in the support for zfcpdump and how to deal with
> > HSA region etc. (I am not very happy about it though now. s390 seems
> > to be having so may special case modes and swap logic etc that it
> > is becoming hard to keep track what they are doing. I wished s390
> > first did some cleanup w.r.t swap logic and deal with mmap() in pure
> > kdump mode and then worry about taking care of zfcpdump).
> > 
> > Is it possible to push this series in 3.11 now? I suspect it is late now.
> > Otherwise we might have to revert mmap() patches as in current form
> > they will break s390 kdump.
> > 
> > Michael, Hatayama, in case this series can't go in 3.11, do you have other
> > ideas where a small hack fix will allow kdump to work on s390 and we
> > don't have to revert the mmap() patches.
> 
> Sure, we can somehow change the copy_from_oldmem() function that it
> can copy to virtual memory. We have already discussed some options
> on how to do that. Not nice but probably doable.
> 
> And we could either disable mmap for s390 by removing mmap_vmcore()
> from the proc_vmcore_operations or push the also already discussed
> ELF header swap trick in 3.11.
> 
> But this is all additional effort now and would not be necessary if we
> integrate this patch series in 3.11.
> 
> Perhaps we should let Andrew decide here.

Hi Michael,

Given the fact that andrew too prefers a fix to get s390 working at this
stage can we modify s390 copy_from_oldmem() to be able to copy to 
vmalloc() memory area.

For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
ELF header swap etc, let us now target that for 3.12.

Sounds reasonable?

Thanks
Vivek

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Vivek Goyal]

On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> > On Tue, Jul 16, 2013 at 06:18:10PM +0200, Michael Holzheu wrote:
> > > Hello Andrew,
> > >
> > > Here a new kdump patch series that we have discussed with Vivek and
> > > Hatayama during the last months.
> > >
> > > Besides of the feature described below, this patch series also fixes a
> > > regression on s390 that was introduced with the mmap patches for
> > > /proc/vmcore (git commit 83086978c63afd7c73e1c).
> > >
> > > See also:
> > > http://lists.infradead.org/pipermail/kexec/2013-July/009287.html
> > >
> > > Is it somehow possible to integrate this patch series into 3.11?
> > 
> > Hi Andrew,
> > 
> > Now /proc/vmcore mmap() patches are in but looks like they will break
> > s390 kdump. mmap() patches use vmalloc() to allocate memory for elf
> > notes and then use read_from_oldmem() to copy notes data from old
> > memory to this newly allocated buffer. read_from_oldmem() in turn
> > uses arch dependent copy_from_oldmem() function.
> > 
> > Look like on s390, copy_from_oldmem() can not copy data to vmalloc()
> > space as they drop to real mode.
> > 
> > As allocating elf notes code is common both for mmap() and read() path,
> > it will break kdump on s390.
> > 
> > Michael has done some cleanups to cope with that but in the process
> > he has also stuffed in the support for zfcpdump and how to deal with
> > HSA region etc. (I am not very happy about it though now. s390 seems
> > to be having so may special case modes and swap logic etc that it
> > is becoming hard to keep track what they are doing. I wished s390
> > first did some cleanup w.r.t swap logic and deal with mmap() in pure
> > kdump mode and then worry about taking care of zfcpdump).
> > 
> > Is it possible to push this series in 3.11 now? I suspect it is late now.
> > Otherwise we might have to revert mmap() patches as in current form
> > they will break s390 kdump.
> > 
> > Michael, Hatayama, in case this series can't go in 3.11, do you have other
> > ideas where a small hack fix will allow kdump to work on s390 and we
> > don't have to revert the mmap() patches.
> 
> Sure, we can somehow change the copy_from_oldmem() function that it
> can copy to virtual memory. We have already discussed some options
> on how to do that. Not nice but probably doable.
> 
> And we could either disable mmap for s390 by removing mmap_vmcore()
> from the proc_vmcore_operations or push the also already discussed
> ELF header swap trick in 3.11.
> 
> But this is all additional effort now and would not be necessary if we
> integrate this patch series in 3.11.
> 
> Perhaps we should let Andrew decide here.

Hi Michael,

Given the fact that andrew too prefers a fix to get s390 working at this
stage can we modify s390 copy_from_oldmem() to be able to copy to 
vmalloc() memory area.

For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
ELF header swap etc, let us now target that for 3.12.

Sounds reasonable?

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Michael Holzheu]

On Wed, 17 Jul 2013 17:42:07 -0400
Vivek Goyal <vgoyal@redhat.com> wrote:
> On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:

[snip]

> > But this is all additional effort now and would not be necessary if we
> > integrate this patch series in 3.11.
> > 
> > Perhaps we should let Andrew decide here.
> 
> Hi Michael,
> 
> Given the fact that andrew too prefers a fix to get s390 working at this
> stage can we modify s390 copy_from_oldmem() to be able to copy to 
> vmalloc() memory area.
> 
> For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> ELF header swap etc, let us now target that for 3.12.
> 
> Sounds reasonable?

Hi Vivek,

Ok this is not our preferred solution but we can't expect that life is
always easy ;-)

Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
two patches upstream for 3.11:

 * s390/kdump: Disable mmap for s390
 * s390/kdump: Allow copy_oldmem_page() copy to virtual memory

@Andrew:

Would you then take the "ELF header in new memory" patch series for 3.12?

Regards,
Michael

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Michael Holzheu]

On Wed, 17 Jul 2013 17:42:07 -0400
Vivek Goyal <vgoyal@redhat.com> wrote:
> On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:

[snip]

> > But this is all additional effort now and would not be necessary if we
> > integrate this patch series in 3.11.
> > 
> > Perhaps we should let Andrew decide here.
> 
> Hi Michael,
> 
> Given the fact that andrew too prefers a fix to get s390 working at this
> stage can we modify s390 copy_from_oldmem() to be able to copy to 
> vmalloc() memory area.
> 
> For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> ELF header swap etc, let us now target that for 3.12.
> 
> Sounds reasonable?

Hi Vivek,

Ok this is not our preferred solution but we can't expect that life is
always easy ;-)

Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
two patches upstream for 3.11:

 * s390/kdump: Disable mmap for s390
 * s390/kdump: Allow copy_oldmem_page() copy to virtual memory

@Andrew:

Would you then take the "ELF header in new memory" patch series for 3.12?

Regards,
Michael


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Martin Schwidefsky]

On Thu, 18 Jul 2013 12:40:04 +0200
Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:

> On Wed, 17 Jul 2013 17:42:07 -0400
> Vivek Goyal <vgoyal@redhat.com> wrote:
> > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> 
> [snip]
> 
> > > But this is all additional effort now and would not be necessary if we
> > > integrate this patch series in 3.11.
> > > 
> > > Perhaps we should let Andrew decide here.
> > 
> > Hi Michael,
> > 
> > Given the fact that andrew too prefers a fix to get s390 working at this
> > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > vmalloc() memory area.
> > 
> > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > ELF header swap etc, let us now target that for 3.12.
> > 
> > Sounds reasonable?
> 
> Hi Vivek,
> 
> Ok this is not our preferred solution but we can't expect that life is
> always easy ;-)
> 
> Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> two patches upstream for 3.11:
> 
>  * s390/kdump: Disable mmap for s390
>  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory

Patches have been added to 
  git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features

They will go upstream with my next pull request.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Martin Schwidefsky]

On Thu, 18 Jul 2013 12:40:04 +0200
Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:

> On Wed, 17 Jul 2013 17:42:07 -0400
> Vivek Goyal <vgoyal@redhat.com> wrote:
> > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> 
> [snip]
> 
> > > But this is all additional effort now and would not be necessary if we
> > > integrate this patch series in 3.11.
> > > 
> > > Perhaps we should let Andrew decide here.
> > 
> > Hi Michael,
> > 
> > Given the fact that andrew too prefers a fix to get s390 working at this
> > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > vmalloc() memory area.
> > 
> > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > ELF header swap etc, let us now target that for 3.12.
> > 
> > Sounds reasonable?
> 
> Hi Vivek,
> 
> Ok this is not our preferred solution but we can't expect that life is
> always easy ;-)
> 
> Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> two patches upstream for 3.11:
> 
>  * s390/kdump: Disable mmap for s390
>  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory

Patches have been added to 
  git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features

They will go upstream with my next pull request.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Vivek Goyal]

On Thu, Jul 18, 2013 at 12:40:04PM +0200, Michael Holzheu wrote:
> On Wed, 17 Jul 2013 17:42:07 -0400
> Vivek Goyal <vgoyal@redhat.com> wrote:
> > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> 
> [snip]
> 
> > > But this is all additional effort now and would not be necessary if we
> > > integrate this patch series in 3.11.
> > > 
> > > Perhaps we should let Andrew decide here.
> > 
> > Hi Michael,
> > 
> > Given the fact that andrew too prefers a fix to get s390 working at this
> > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > vmalloc() memory area.
> > 
> > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > ELF header swap etc, let us now target that for 3.12.
> > 
> > Sounds reasonable?
> 
> Hi Vivek,
> 
> Ok this is not our preferred solution but we can't expect that life is
> always easy ;-)
> 
> Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> two patches upstream for 3.11:
> 
>  * s390/kdump: Disable mmap for s390
>  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory
> 
> @Andrew:
> 
> Would you then take the "ELF header in new memory" patch series for 3.12?

Hi Michael,

Once this patch series gets merged for 3.12, can we first do some cleanup
of s390 code before we do further development there. Basically there is
no reason that s390 kdump should be any different than x86. So all the
logic of OLD base can go away. 

Only thing different about s390 is primarily zfcpdump w.r.t handling of
HSA region and creating of elf headers in 2nd kernel.

Thanks
Vivek

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Vivek Goyal]

On Thu, Jul 18, 2013 at 12:40:04PM +0200, Michael Holzheu wrote:
> On Wed, 17 Jul 2013 17:42:07 -0400
> Vivek Goyal <vgoyal@redhat.com> wrote:
> > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> 
> [snip]
> 
> > > But this is all additional effort now and would not be necessary if we
> > > integrate this patch series in 3.11.
> > > 
> > > Perhaps we should let Andrew decide here.
> > 
> > Hi Michael,
> > 
> > Given the fact that andrew too prefers a fix to get s390 working at this
> > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > vmalloc() memory area.
> > 
> > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > ELF header swap etc, let us now target that for 3.12.
> > 
> > Sounds reasonable?
> 
> Hi Vivek,
> 
> Ok this is not our preferred solution but we can't expect that life is
> always easy ;-)
> 
> Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> two patches upstream for 3.11:
> 
>  * s390/kdump: Disable mmap for s390
>  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory
> 
> @Andrew:
> 
> Would you then take the "ELF header in new memory" patch series for 3.12?

Hi Michael,

Once this patch series gets merged for 3.12, can we first do some cleanup
of s390 code before we do further development there. Basically there is
no reason that s390 kdump should be any different than x86. So all the
logic of OLD base can go away. 

Only thing different about s390 is primarily zfcpdump w.r.t handling of
HSA region and creating of elf headers in 2nd kernel.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Vivek Goyal]

On Thu, Jul 18, 2013 at 12:47:54PM +0200, Martin Schwidefsky wrote:
> On Thu, 18 Jul 2013 12:40:04 +0200
> Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:
> 
> > On Wed, 17 Jul 2013 17:42:07 -0400
> > Vivek Goyal <vgoyal@redhat.com> wrote:
> > > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> > 
> > [snip]
> > 
> > > > But this is all additional effort now and would not be necessary if we
> > > > integrate this patch series in 3.11.
> > > > 
> > > > Perhaps we should let Andrew decide here.
> > > 
> > > Hi Michael,
> > > 
> > > Given the fact that andrew too prefers a fix to get s390 working at this
> > > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > > vmalloc() memory area.
> > > 
> > > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > > ELF header swap etc, let us now target that for 3.12.
> > > 
> > > Sounds reasonable?
> > 
> > Hi Vivek,
> > 
> > Ok this is not our preferred solution but we can't expect that life is
> > always easy ;-)
> > 
> > Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> > two patches upstream for 3.11:
> > 
> >  * s390/kdump: Disable mmap for s390
> >  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory
> 
> Patches have been added to 
>   git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
> 
> They will go upstream with my next pull request.
> 

If everything related to crash dump is going through Andrew, wouldn't
it make sense that even these fixes go through him?

https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=5a74953ff56aa870d6913ef4d81934f5c620c59d

https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=191a2fa0a8d2bbb64c98f9b1976fcb37ee5eae6b

Thanks
Vivek

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Vivek Goyal]

On Thu, Jul 18, 2013 at 12:47:54PM +0200, Martin Schwidefsky wrote:
> On Thu, 18 Jul 2013 12:40:04 +0200
> Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:
> 
> > On Wed, 17 Jul 2013 17:42:07 -0400
> > Vivek Goyal <vgoyal@redhat.com> wrote:
> > > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> > 
> > [snip]
> > 
> > > > But this is all additional effort now and would not be necessary if we
> > > > integrate this patch series in 3.11.
> > > > 
> > > > Perhaps we should let Andrew decide here.
> > > 
> > > Hi Michael,
> > > 
> > > Given the fact that andrew too prefers a fix to get s390 working at this
> > > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > > vmalloc() memory area.
> > > 
> > > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > > ELF header swap etc, let us now target that for 3.12.
> > > 
> > > Sounds reasonable?
> > 
> > Hi Vivek,
> > 
> > Ok this is not our preferred solution but we can't expect that life is
> > always easy ;-)
> > 
> > Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> > two patches upstream for 3.11:
> > 
> >  * s390/kdump: Disable mmap for s390
> >  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory
> 
> Patches have been added to 
>   git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
> 
> They will go upstream with my next pull request.
> 

If everything related to crash dump is going through Andrew, wouldn't
it make sense that even these fixes go through him?

https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=5a74953ff56aa870d6913ef4d81934f5c620c59d

https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=191a2fa0a8d2bbb64c98f9b1976fcb37ee5eae6b

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Michael Holzheu]

On Thu, 18 Jul 2013 09:27:57 -0400
Vivek Goyal <vgoyal@redhat.com> wrote:

> On Thu, Jul 18, 2013 at 12:40:04PM +0200, Michael Holzheu wrote:
> > On Wed, 17 Jul 2013 17:42:07 -0400
> > Vivek Goyal <vgoyal@redhat.com> wrote:
> > > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> > 
> > [snip]
> > 
> > > > But this is all additional effort now and would not be necessary if we
> > > > integrate this patch series in 3.11.
> > > > 
> > > > Perhaps we should let Andrew decide here.
> > > 
> > > Hi Michael,
> > > 
> > > Given the fact that andrew too prefers a fix to get s390 working at this
> > > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > > vmalloc() memory area.
> > > 
> > > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > > ELF header swap etc, let us now target that for 3.12.
> > > 
> > > Sounds reasonable?
> > 
> > Hi Vivek,
> > 
> > Ok this is not our preferred solution but we can't expect that life is
> > always easy ;-)
> > 
> > Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> > two patches upstream for 3.11:
> > 
> >  * s390/kdump: Disable mmap for s390
> >  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory
> > 
> > @Andrew:
> > 
> > Would you then take the "ELF header in new memory" patch series for 3.12?
> 
> Hi Michael,
> 
> Once this patch series gets merged for 3.12, can we first do some cleanup
> of s390 code before we do further development there. Basically there is
> no reason that s390 kdump should be any different than x86. So all the
> logic of OLD base can go away. 

Hello Vivek,

You mean that we first integrate the agreed "ELF header in new memory"
patch series, then do the cleanup, and after that we discuss the further
development (storage keys)?

Michael

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Michael Holzheu]

On Thu, 18 Jul 2013 09:27:57 -0400
Vivek Goyal <vgoyal@redhat.com> wrote:

> On Thu, Jul 18, 2013 at 12:40:04PM +0200, Michael Holzheu wrote:
> > On Wed, 17 Jul 2013 17:42:07 -0400
> > Vivek Goyal <vgoyal@redhat.com> wrote:
> > > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> > 
> > [snip]
> > 
> > > > But this is all additional effort now and would not be necessary if we
> > > > integrate this patch series in 3.11.
> > > > 
> > > > Perhaps we should let Andrew decide here.
> > > 
> > > Hi Michael,
> > > 
> > > Given the fact that andrew too prefers a fix to get s390 working at this
> > > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > > vmalloc() memory area.
> > > 
> > > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > > ELF header swap etc, let us now target that for 3.12.
> > > 
> > > Sounds reasonable?
> > 
> > Hi Vivek,
> > 
> > Ok this is not our preferred solution but we can't expect that life is
> > always easy ;-)
> > 
> > Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> > two patches upstream for 3.11:
> > 
> >  * s390/kdump: Disable mmap for s390
> >  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory
> > 
> > @Andrew:
> > 
> > Would you then take the "ELF header in new memory" patch series for 3.12?
> 
> Hi Michael,
> 
> Once this patch series gets merged for 3.12, can we first do some cleanup
> of s390 code before we do further development there. Basically there is
> no reason that s390 kdump should be any different than x86. So all the
> logic of OLD base can go away. 

Hello Vivek,

You mean that we first integrate the agreed "ELF header in new memory"
patch series, then do the cleanup, and after that we discuss the further
development (storage keys)?

Michael


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Vivek Goyal]

On Thu, Jul 18, 2013 at 04:31:21PM +0200, Michael Holzheu wrote:

[..]
> > Hi Michael,
> > 
> > Once this patch series gets merged for 3.12, can we first do some cleanup
> > of s390 code before we do further development there. Basically there is
> > no reason that s390 kdump should be any different than x86. So all the
> > logic of OLD base can go away. 
> 
> Hello Vivek,
> 
> You mean that we first integrate the agreed "ELF header in new memory"
> patch series, then do the cleanup, and after that we discuss the further
> development (storage keys)?

Yes. 

Thanks
Vivek

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Vivek Goyal]

On Thu, Jul 18, 2013 at 04:31:21PM +0200, Michael Holzheu wrote:

[..]
> > Hi Michael,
> > 
> > Once this patch series gets merged for 3.12, can we first do some cleanup
> > of s390 code before we do further development there. Basically there is
> > no reason that s390 kdump should be any different than x86. So all the
> > logic of OLD base can go away. 
> 
> Hello Vivek,
> 
> You mean that we first integrate the agreed "ELF header in new memory"
> patch series, then do the cleanup, and after that we discuss the further
> development (storage keys)?

Yes. 

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Martin Schwidefsky]

On Thu, 18 Jul 2013 09:35:41 -0400
Vivek Goyal <vgoyal@redhat.com> wrote:

> On Thu, Jul 18, 2013 at 12:47:54PM +0200, Martin Schwidefsky wrote:
> > On Thu, 18 Jul 2013 12:40:04 +0200
> > Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:
> > 
> > > On Wed, 17 Jul 2013 17:42:07 -0400
> > > Vivek Goyal <vgoyal@redhat.com> wrote:
> > > > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> > > 
> > > [snip]
> > > 
> > > > > But this is all additional effort now and would not be necessary if we
> > > > > integrate this patch series in 3.11.
> > > > > 
> > > > > Perhaps we should let Andrew decide here.
> > > > 
> > > > Hi Michael,
> > > > 
> > > > Given the fact that andrew too prefers a fix to get s390 working at this
> > > > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > > > vmalloc() memory area.
> > > > 
> > > > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > > > ELF header swap etc, let us now target that for 3.12.
> > > > 
> > > > Sounds reasonable?
> > > 
> > > Hi Vivek,
> > > 
> > > Ok this is not our preferred solution but we can't expect that life is
> > > always easy ;-)
> > > 
> > > Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> > > two patches upstream for 3.11:
> > > 
> > >  * s390/kdump: Disable mmap for s390
> > >  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory
> > 
> > Patches have been added to 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
> > 
> > They will go upstream with my next pull request.
> > 
> 
> If everything related to crash dump is going through Andrew, wouldn't
> it make sense that even these fixes go through him?
> 
> https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=5a74953ff56aa870d6913ef4d81934f5c620c59d
> 
> https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=191a2fa0a8d2bbb64c98f9b1976fcb37ee5eae6b

Most of the architecture specific kdump patches for s390 have gone through me,
and these two fall into that category. If you insist we can route them over
Andrew, it just seems easier to me via the s390 tree.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Martin Schwidefsky]

On Thu, 18 Jul 2013 09:35:41 -0400
Vivek Goyal <vgoyal@redhat.com> wrote:

> On Thu, Jul 18, 2013 at 12:47:54PM +0200, Martin Schwidefsky wrote:
> > On Thu, 18 Jul 2013 12:40:04 +0200
> > Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:
> > 
> > > On Wed, 17 Jul 2013 17:42:07 -0400
> > > Vivek Goyal <vgoyal@redhat.com> wrote:
> > > > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> > > 
> > > [snip]
> > > 
> > > > > But this is all additional effort now and would not be necessary if we
> > > > > integrate this patch series in 3.11.
> > > > > 
> > > > > Perhaps we should let Andrew decide here.
> > > > 
> > > > Hi Michael,
> > > > 
> > > > Given the fact that andrew too prefers a fix to get s390 working at this
> > > > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > > > vmalloc() memory area.
> > > > 
> > > > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > > > ELF header swap etc, let us now target that for 3.12.
> > > > 
> > > > Sounds reasonable?
> > > 
> > > Hi Vivek,
> > > 
> > > Ok this is not our preferred solution but we can't expect that life is
> > > always easy ;-)
> > > 
> > > Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> > > two patches upstream for 3.11:
> > > 
> > >  * s390/kdump: Disable mmap for s390
> > >  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory
> > 
> > Patches have been added to 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
> > 
> > They will go upstream with my next pull request.
> > 
> 
> If everything related to crash dump is going through Andrew, wouldn't
> it make sense that even these fixes go through him?
> 
> https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=5a74953ff56aa870d6913ef4d81934f5c620c59d
> 
> https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=191a2fa0a8d2bbb64c98f9b1976fcb37ee5eae6b

Most of the architecture specific kdump patches for s390 have gone through me,
and these two fall into that category. If you insist we can route them over
Andrew, it just seems easier to me via the s390 tree.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Vivek Goyal]

On Fri, Jul 19, 2013 at 08:50:20AM +0200, Martin Schwidefsky wrote:
> On Thu, 18 Jul 2013 09:35:41 -0400
> Vivek Goyal <vgoyal@redhat.com> wrote:
> 
> > On Thu, Jul 18, 2013 at 12:47:54PM +0200, Martin Schwidefsky wrote:
> > > On Thu, 18 Jul 2013 12:40:04 +0200
> > > Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:
> > > 
> > > > On Wed, 17 Jul 2013 17:42:07 -0400
> > > > Vivek Goyal <vgoyal@redhat.com> wrote:
> > > > > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> > > > 
> > > > [snip]
> > > > 
> > > > > > But this is all additional effort now and would not be necessary if we
> > > > > > integrate this patch series in 3.11.
> > > > > > 
> > > > > > Perhaps we should let Andrew decide here.
> > > > > 
> > > > > Hi Michael,
> > > > > 
> > > > > Given the fact that andrew too prefers a fix to get s390 working at this
> > > > > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > > > > vmalloc() memory area.
> > > > > 
> > > > > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > > > > ELF header swap etc, let us now target that for 3.12.
> > > > > 
> > > > > Sounds reasonable?
> > > > 
> > > > Hi Vivek,
> > > > 
> > > > Ok this is not our preferred solution but we can't expect that life is
> > > > always easy ;-)
> > > > 
> > > > Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> > > > two patches upstream for 3.11:
> > > > 
> > > >  * s390/kdump: Disable mmap for s390
> > > >  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory
> > > 
> > > Patches have been added to 
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
> > > 
> > > They will go upstream with my next pull request.
> > > 
> > 
> > If everything related to crash dump is going through Andrew, wouldn't
> > it make sense that even these fixes go through him?
> > 
> > https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=5a74953ff56aa870d6913ef4d81934f5c620c59d
> > 
> > https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=191a2fa0a8d2bbb64c98f9b1976fcb37ee5eae6b
> 
> Most of the architecture specific kdump patches for s390 have gone through me,
> and these two fall into that category. If you insist we can route them over
> Andrew, it just seems easier to me via the s390 tree.
> 

In this case one patch is modifying proc/vmcore.c and that's not arch
specific change only.

Secondly, in this specific instance, these changes are in the context
of mmap() related changes which just were pushed. I find it easier
if fixes flow through same channel where previous big set of patches
flowed through.

Hence, I was expecting that Michael will route these fixes through
Andrew. But I am not too particular about it, so go ahead and
push it to Linus.

Thanks
Vivek

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Vivek Goyal]

On Fri, Jul 19, 2013 at 08:50:20AM +0200, Martin Schwidefsky wrote:
> On Thu, 18 Jul 2013 09:35:41 -0400
> Vivek Goyal <vgoyal@redhat.com> wrote:
> 
> > On Thu, Jul 18, 2013 at 12:47:54PM +0200, Martin Schwidefsky wrote:
> > > On Thu, 18 Jul 2013 12:40:04 +0200
> > > Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:
> > > 
> > > > On Wed, 17 Jul 2013 17:42:07 -0400
> > > > Vivek Goyal <vgoyal@redhat.com> wrote:
> > > > > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> > > > 
> > > > [snip]
> > > > 
> > > > > > But this is all additional effort now and would not be necessary if we
> > > > > > integrate this patch series in 3.11.
> > > > > > 
> > > > > > Perhaps we should let Andrew decide here.
> > > > > 
> > > > > Hi Michael,
> > > > > 
> > > > > Given the fact that andrew too prefers a fix to get s390 working at this
> > > > > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > > > > vmalloc() memory area.
> > > > > 
> > > > > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > > > > ELF header swap etc, let us now target that for 3.12.
> > > > > 
> > > > > Sounds reasonable?
> > > > 
> > > > Hi Vivek,
> > > > 
> > > > Ok this is not our preferred solution but we can't expect that life is
> > > > always easy ;-)
> > > > 
> > > > Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> > > > two patches upstream for 3.11:
> > > > 
> > > >  * s390/kdump: Disable mmap for s390
> > > >  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory
> > > 
> > > Patches have been added to 
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
> > > 
> > > They will go upstream with my next pull request.
> > > 
> > 
> > If everything related to crash dump is going through Andrew, wouldn't
> > it make sense that even these fixes go through him?
> > 
> > https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=5a74953ff56aa870d6913ef4d81934f5c620c59d
> > 
> > https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=191a2fa0a8d2bbb64c98f9b1976fcb37ee5eae6b
> 
> Most of the architecture specific kdump patches for s390 have gone through me,
> and these two fall into that category. If you insist we can route them over
> Andrew, it just seems easier to me via the s390 tree.
> 

In this case one patch is modifying proc/vmcore.c and that's not arch
specific change only.

Secondly, in this specific instance, these changes are in the context
of mmap() related changes which just were pushed. I find it easier
if fixes flow through same channel where previous big set of patches
flowed through.

Hence, I was expecting that Michael will route these fixes through
Andrew. But I am not too particular about it, so go ahead and
push it to Linus.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Martin Schwidefsky]

On Fri, 19 Jul 2013 09:35:18 -0400
Vivek Goyal <vgoyal@redhat.com> wrote:

> On Fri, Jul 19, 2013 at 08:50:20AM +0200, Martin Schwidefsky wrote:
> > On Thu, 18 Jul 2013 09:35:41 -0400
> > Vivek Goyal <vgoyal@redhat.com> wrote:
> > 
> > > On Thu, Jul 18, 2013 at 12:47:54PM +0200, Martin Schwidefsky wrote:
> > > > On Thu, 18 Jul 2013 12:40:04 +0200
> > > > Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:
> > > > 
> > > > > On Wed, 17 Jul 2013 17:42:07 -0400
> > > > > Vivek Goyal <vgoyal@redhat.com> wrote:
> > > > > > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> > > > > 
> > > > > [snip]
> > > > > 
> > > > > > > But this is all additional effort now and would not be necessary if we
> > > > > > > integrate this patch series in 3.11.
> > > > > > > 
> > > > > > > Perhaps we should let Andrew decide here.
> > > > > > 
> > > > > > Hi Michael,
> > > > > > 
> > > > > > Given the fact that andrew too prefers a fix to get s390 working at this
> > > > > > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > > > > > vmalloc() memory area.
> > > > > > 
> > > > > > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > > > > > ELF header swap etc, let us now target that for 3.12.
> > > > > > 
> > > > > > Sounds reasonable?
> > > > > 
> > > > > Hi Vivek,
> > > > > 
> > > > > Ok this is not our preferred solution but we can't expect that life is
> > > > > always easy ;-)
> > > > > 
> > > > > Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> > > > > two patches upstream for 3.11:
> > > > > 
> > > > >  * s390/kdump: Disable mmap for s390
> > > > >  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory
> > > > 
> > > > Patches have been added to 
> > > >   git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
> > > > 
> > > > They will go upstream with my next pull request.
> > > > 
> > > 
> > > If everything related to crash dump is going through Andrew, wouldn't
> > > it make sense that even these fixes go through him?
> > > 
> > > https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=5a74953ff56aa870d6913ef4d81934f5c620c59d
> > > 
> > > https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=191a2fa0a8d2bbb64c98f9b1976fcb37ee5eae6b
> > 
> > Most of the architecture specific kdump patches for s390 have gone through me,
> > and these two fall into that category. If you insist we can route them over
> > Andrew, it just seems easier to me via the s390 tree.
> > 
> 
> In this case one patch is modifying proc/vmcore.c and that's not arch
> specific change only.
> 
> Secondly, in this specific instance, these changes are in the context
> of mmap() related changes which just were pushed. I find it easier
> if fixes flow through same channel where previous big set of patches
> flowed through.
> 
> Hence, I was expecting that Michael will route these fixes through
> Andrew. But I am not too particular about it, so go ahead and
> push it to Linus.

The pull request is on its way.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Martin Schwidefsky]

On Fri, 19 Jul 2013 09:35:18 -0400
Vivek Goyal <vgoyal@redhat.com> wrote:

> On Fri, Jul 19, 2013 at 08:50:20AM +0200, Martin Schwidefsky wrote:
> > On Thu, 18 Jul 2013 09:35:41 -0400
> > Vivek Goyal <vgoyal@redhat.com> wrote:
> > 
> > > On Thu, Jul 18, 2013 at 12:47:54PM +0200, Martin Schwidefsky wrote:
> > > > On Thu, 18 Jul 2013 12:40:04 +0200
> > > > Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:
> > > > 
> > > > > On Wed, 17 Jul 2013 17:42:07 -0400
> > > > > Vivek Goyal <vgoyal@redhat.com> wrote:
> > > > > > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote:
> > > > > 
> > > > > [snip]
> > > > > 
> > > > > > > But this is all additional effort now and would not be necessary if we
> > > > > > > integrate this patch series in 3.11.
> > > > > > > 
> > > > > > > Perhaps we should let Andrew decide here.
> > > > > > 
> > > > > > Hi Michael,
> > > > > > 
> > > > > > Given the fact that andrew too prefers a fix to get s390 working at this
> > > > > > stage can we modify s390 copy_from_oldmem() to be able to copy to 
> > > > > > vmalloc() memory area.
> > > > > > 
> > > > > > For mmap(), let us disable it on s390. And rest of the cleanups w.r.t
> > > > > > ELF header swap etc, let us now target that for 3.12.
> > > > > > 
> > > > > > Sounds reasonable?
> > > > > 
> > > > > Hi Vivek,
> > > > > 
> > > > > Ok this is not our preferred solution but we can't expect that life is
> > > > > always easy ;-)
> > > > > 
> > > > > Our s390 kernel maintainer Martin Schwidefsky agreed to send the following
> > > > > two patches upstream for 3.11:
> > > > > 
> > > > >  * s390/kdump: Disable mmap for s390
> > > > >  * s390/kdump: Allow copy_oldmem_page() copy to virtual memory
> > > > 
> > > > Patches have been added to 
> > > >   git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
> > > > 
> > > > They will go upstream with my next pull request.
> > > > 
> > > 
> > > If everything related to crash dump is going through Andrew, wouldn't
> > > it make sense that even these fixes go through him?
> > > 
> > > https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=5a74953ff56aa870d6913ef4d81934f5c620c59d
> > > 
> > > https://git.kernel.org/cgit/linux/kernel/git/s390/linux.git/commit/?h=features&id=191a2fa0a8d2bbb64c98f9b1976fcb37ee5eae6b
> > 
> > Most of the architecture specific kdump patches for s390 have gone through me,
> > and these two fall into that category. If you insist we can route them over
> > Andrew, it just seems easier to me via the s390 tree.
> > 
> 
> In this case one patch is modifying proc/vmcore.c and that's not arch
> specific change only.
> 
> Secondly, in this specific instance, these changes are in the context
> of mmap() related changes which just were pushed. I find it easier
> if fixes flow through same channel where previous big set of patches
> flowed through.
> 
> Hence, I was expecting that Michael will route these fixes through
> Andrew. But I am not too particular about it, so go ahead and
> push it to Linus.

The pull request is on its way.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Andrew Morton]

On Tue, 16 Jul 2013 13:24:21 -0400 Vivek Goyal <vgoyal@redhat.com> wrote:

> Michael, Hatayama, in case this series can't go in 3.11, do you have other
> ideas where a small hack fix will allow kdump to work on s390 and we
> don't have to revert the mmap() patches.

This would certainly be the preferred option at this stage.

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Andrew Morton]

On Tue, 16 Jul 2013 13:24:21 -0400 Vivek Goyal <vgoyal@redhat.com> wrote:

> Michael, Hatayama, in case this series can't go in 3.11, do you have other
> ideas where a small hack fix will allow kdump to work on s390 and we
> don't have to revert the mmap() patches.

This would certainly be the preferred option at this stage.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Vivek Goyal]

On Tue, Jul 16, 2013 at 06:18:10PM +0200, Michael Holzheu wrote:
> Hello Andrew,
> 
> Here a new kdump patch series that we have discussed with Vivek and
> Hatayama during the last months.
> 
> Besides of the feature described below, this patch series also fixes a
> regression on s390 that was introduced with the mmap patches for
> /proc/vmcore (git commit 83086978c63afd7c73e1c).
> 
> See also:
> http://lists.infradead.org/pipermail/kexec/2013-July/009287.html
> 
> Is it somehow possible to integrate this patch series into 3.11?

Hi Andrew,

Now /proc/vmcore mmap() patches are in but looks like they will break
s390 kdump. mmap() patches use vmalloc() to allocate memory for elf
notes and then use read_from_oldmem() to copy notes data from old
memory to this newly allocated buffer. read_from_oldmem() in turn
uses arch dependent copy_from_oldmem() function.

Look like on s390, copy_from_oldmem() can not copy data to vmalloc()
space as they drop to real mode.

As allocating elf notes code is common both for mmap() and read() path,
it will break kdump on s390.

Michael has done some cleanups to cope with that but in the process
he has also stuffed in the support for zfcpdump and how to deal with
HSA region etc. (I am not very happy about it though now. s390 seems
to be having so may special case modes and swap logic etc that it
is becoming hard to keep track what they are doing. I wished s390
first did some cleanup w.r.t swap logic and deal with mmap() in pure
kdump mode and then worry about taking care of zfcpdump).

Is it possible to push this series in 3.11 now? I suspect it is late now.
Otherwise we might have to revert mmap() patches as in current form
they will break s390 kdump.

Michael, Hatayama, in case this series can't go in 3.11, do you have other
ideas where a small hack fix will allow kdump to work on s390 and we
don't have to revert the mmap() patches.

Thanks
Vivek

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Vivek Goyal]

On Tue, Jul 16, 2013 at 06:18:10PM +0200, Michael Holzheu wrote:
> Hello Andrew,
> 
> Here a new kdump patch series that we have discussed with Vivek and
> Hatayama during the last months.
> 
> Besides of the feature described below, this patch series also fixes a
> regression on s390 that was introduced with the mmap patches for
> /proc/vmcore (git commit 83086978c63afd7c73e1c).
> 
> See also:
> http://lists.infradead.org/pipermail/kexec/2013-July/009287.html
> 
> Is it somehow possible to integrate this patch series into 3.11?

Hi Andrew,

Now /proc/vmcore mmap() patches are in but looks like they will break
s390 kdump. mmap() patches use vmalloc() to allocate memory for elf
notes and then use read_from_oldmem() to copy notes data from old
memory to this newly allocated buffer. read_from_oldmem() in turn
uses arch dependent copy_from_oldmem() function.

Look like on s390, copy_from_oldmem() can not copy data to vmalloc()
space as they drop to real mode.

As allocating elf notes code is common both for mmap() and read() path,
it will break kdump on s390.

Michael has done some cleanups to cope with that but in the process
he has also stuffed in the support for zfcpdump and how to deal with
HSA region etc. (I am not very happy about it though now. s390 seems
to be having so may special case modes and swap logic etc that it
is becoming hard to keep track what they are doing. I wished s390
first did some cleanup w.r.t swap logic and deal with mmap() in pure
kdump mode and then worry about taking care of zfcpdump).

Is it possible to push this series in 3.11 now? I suspect it is late now.
Otherwise we might have to revert mmap() patches as in current form
they will break s390 kdump.

Michael, Hatayama, in case this series can't go in 3.11, do you have other
ideas where a small hack fix will allow kdump to work on s390 and we
don't have to revert the mmap() patches.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

[PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Michael Holzheu]

Hello Andrew,

Here a new kdump patch series that we have discussed with Vivek and
Hatayama during the last months.

Besides of the feature described below, this patch series also fixes a
regression on s390 that was introduced with the mmap patches for
/proc/vmcore (git commit 83086978c63afd7c73e1c).

See also:
http://lists.infradead.org/pipermail/kexec/2013-July/009287.html

Is it somehow possible to integrate this patch series into 3.11?

ChangeLog
=========
v6 => v7)

- Rebase to v3.11-rc1
- Return VM_FAULT_SIGBUS in fault handler for non s390
- Use __va() for buffer in fault handler

v5 => v6)

- Set elfcorehdr_addr to ELFCORE_ADDR_ERR after elfcorehdr_free()
- Fix OLDMEM_SIZE/ZFCPDUMP_HSA_SIZE confusion
- Remove return VM_FAULT_MAJOR/MINOR
- Use find_or_create_page() in mmap_vmcore_fault()
- Use kfree instead of vfree in elfcorehdr_free()

v4 => v5)

- Add weak function elfcorehdr_read_notes() to read ELF notes
- Rename weak functions for ELF header access and use "vmcorehdr_" prefix
- Generic vmcore code calls elfcorehdr_alloc() if elfcorehdr= is not specified
- Add vmcore fault handler for mmap of non-resident memory regions
- Add weak function remap_oldmem_pfn_range() to be used by zfcpdump for mmap

v3 => v4)

- Rebase to 3.10-rc2 + vmcore mmap patches v8

v2 => v3)

- Get rid of ELFCORE_ADDR_NEWMEM
- Make read_from_crash_header() only read from kernel
- Move read_from_crash_header() to weak function arch_read_from_crash_header()
- Implement read_from_crash_header() strong function for s390
- Set elfcorehdr_addr to address of new ELF header

v1 => v2)

- Rebase 3.10-rc2 + vmcore mmap patches
- Introduced arch_get/free_crash_header() and ELFCORE_ADDR_NEWMEM

Feature Description
===================
For s390 we want to use /proc/vmcore for our SCSI stand-alone
dump (zfcpdump). We have support where the first HSA_SIZE bytes are
saved into a hypervisor owned memory area (HSA) before the kdump
kernel is booted. When the kdump kernel starts, it is restricted
to use only HSA_SIZE bytes.

The advantages of this mechanism are:

* No crashkernel memory has to be defined in the old kernel.
* Early boot problems (before kexec_load has been done) can be dumped 
* Non-Linux systems can be dumped.

We modify the s390 copy_oldmem_page() function to read from the HSA memory
if memory below HSA_SIZE bytes is requested.

Since we cannot use the kexec tool to load the kernel in this scenario,
we have to build the ELF header in the 2nd (kdump/new) kernel.

So with the following patch set we would like to introduce the new
function that the ELF header for /proc/vmcore can be created in the 2nd
kernel memory.

The following steps are done during zfcpdump execution:

1.  Production system crashes
2.  User boots a SCSI disk that has been prepared with the zfcpdump tool
3.  Hypervisor saves CPU state of boot CPU and HSA_SIZE bytes of memory into HSA
4.  Boot loader loads kernel into low memory area
5.  Kernel boots and uses only HSA_SIZE bytes of memory
6.  Kernel saves registers of non-boot CPUs
7.  Kernel does memory detection for dump memory map
8.  Kernel creates ELF header for /proc/vmcore
9.  /proc/vmcore uses this header for initialization
10. The zfcpdump user space reads /proc/vmcore to write dump to SCSI disk
    - copy_oldmem_page() copies from HSA for memory below HSA_SIZE
    - copy_oldmem_page() copies from real memory for memory above HSA_SIZE
---
Jan Willeke (1):
  s390/vmcore: Implement remap_oldmem_pfn_range for s390

Michael Holzheu (4):
  vmcore: Introduce ELF header in new memory feature
  s390/vmcore: Use ELF header in new memory feature
  vmcore: Introduce remap_oldmem_pfn_range()
  s390/vmcore: Use vmcore for zfcpdump

 arch/s390/Kconfig             |   3 +-
 arch/s390/include/asm/sclp.h  |   1 +
 arch/s390/kernel/crash_dump.c | 228 ++++++++++++++++++++++++++++++++++--------
 drivers/s390/char/zcore.c     |   6 +-
 fs/proc/vmcore.c              | 152 ++++++++++++++++++++++++----
 include/linux/crash_dump.h    |   9 ++
 6 files changed, 333 insertions(+), 66 deletions(-)

-- 
1.8.2.3

[PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

[Michael Holzheu]

Hello Andrew,

Here a new kdump patch series that we have discussed with Vivek and
Hatayama during the last months.

Besides of the feature described below, this patch series also fixes a
regression on s390 that was introduced with the mmap patches for
/proc/vmcore (git commit 83086978c63afd7c73e1c).

See also:
http://lists.infradead.org/pipermail/kexec/2013-July/009287.html

Is it somehow possible to integrate this patch series into 3.11?

ChangeLog
=========
v6 => v7)

- Rebase to v3.11-rc1
- Return VM_FAULT_SIGBUS in fault handler for non s390
- Use __va() for buffer in fault handler

v5 => v6)

- Set elfcorehdr_addr to ELFCORE_ADDR_ERR after elfcorehdr_free()
- Fix OLDMEM_SIZE/ZFCPDUMP_HSA_SIZE confusion
- Remove return VM_FAULT_MAJOR/MINOR
- Use find_or_create_page() in mmap_vmcore_fault()
- Use kfree instead of vfree in elfcorehdr_free()

v4 => v5)

- Add weak function elfcorehdr_read_notes() to read ELF notes
- Rename weak functions for ELF header access and use "vmcorehdr_" prefix
- Generic vmcore code calls elfcorehdr_alloc() if elfcorehdr= is not specified
- Add vmcore fault handler for mmap of non-resident memory regions
- Add weak function remap_oldmem_pfn_range() to be used by zfcpdump for mmap

v3 => v4)

- Rebase to 3.10-rc2 + vmcore mmap patches v8

v2 => v3)

- Get rid of ELFCORE_ADDR_NEWMEM
- Make read_from_crash_header() only read from kernel
- Move read_from_crash_header() to weak function arch_read_from_crash_header()
- Implement read_from_crash_header() strong function for s390
- Set elfcorehdr_addr to address of new ELF header

v1 => v2)

- Rebase 3.10-rc2 + vmcore mmap patches
- Introduced arch_get/free_crash_header() and ELFCORE_ADDR_NEWMEM

Feature Description
===================
For s390 we want to use /proc/vmcore for our SCSI stand-alone
dump (zfcpdump). We have support where the first HSA_SIZE bytes are
saved into a hypervisor owned memory area (HSA) before the kdump
kernel is booted. When the kdump kernel starts, it is restricted
to use only HSA_SIZE bytes.

The advantages of this mechanism are:

* No crashkernel memory has to be defined in the old kernel.
* Early boot problems (before kexec_load has been done) can be dumped 
* Non-Linux systems can be dumped.

We modify the s390 copy_oldmem_page() function to read from the HSA memory
if memory below HSA_SIZE bytes is requested.

Since we cannot use the kexec tool to load the kernel in this scenario,
we have to build the ELF header in the 2nd (kdump/new) kernel.

So with the following patch set we would like to introduce the new
function that the ELF header for /proc/vmcore can be created in the 2nd
kernel memory.

The following steps are done during zfcpdump execution:

1.  Production system crashes
2.  User boots a SCSI disk that has been prepared with the zfcpdump tool
3.  Hypervisor saves CPU state of boot CPU and HSA_SIZE bytes of memory into HSA
4.  Boot loader loads kernel into low memory area
5.  Kernel boots and uses only HSA_SIZE bytes of memory
6.  Kernel saves registers of non-boot CPUs
7.  Kernel does memory detection for dump memory map
8.  Kernel creates ELF header for /proc/vmcore
9.  /proc/vmcore uses this header for initialization
10. The zfcpdump user space reads /proc/vmcore to write dump to SCSI disk
    - copy_oldmem_page() copies from HSA for memory below HSA_SIZE
    - copy_oldmem_page() copies from real memory for memory above HSA_SIZE
---
Jan Willeke (1):
  s390/vmcore: Implement remap_oldmem_pfn_range for s390

Michael Holzheu (4):
  vmcore: Introduce ELF header in new memory feature
  s390/vmcore: Use ELF header in new memory feature
  vmcore: Introduce remap_oldmem_pfn_range()
  s390/vmcore: Use vmcore for zfcpdump

 arch/s390/Kconfig             |   3 +-
 arch/s390/include/asm/sclp.h  |   1 +
 arch/s390/kernel/crash_dump.c | 228 ++++++++++++++++++++++++++++++++++--------
 drivers/s390/char/zcore.c     |   6 +-
 fs/proc/vmcore.c              | 152 ++++++++++++++++++++++++----
 include/linux/crash_dump.h    |   9 ++
 6 files changed, 333 insertions(+), 66 deletions(-)

-- 
1.8.2.3


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec