All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Lidza Louina <lidza.louina@gmail.com>
Cc: Mark Hounschell <markh@compro.net>,
	driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH] Adds Digi driver to staging.
Date: Wed, 17 Jul 2013 14:49:05 -0700	[thread overview]
Message-ID: <20130717214905.GA14660@kroah.com> (raw)
In-Reply-To: <20130717201801.GA3642@lidza-Satellite-L505D>

On Wed, Jul 17, 2013 at 04:18:01PM -0400, Lidza Louina wrote:
> This patch adds the Digi driver to staging. 

Which digi driver?  For what hardware?  What type of driver is it?
Please provide some more details here.

> It builds. Needs work done
> to adapt to the API changes.
> 
> Signed-off-by: Lidza Louina <lidza.louina@gmail.com>

If at all possible, can we attribute this to the original author(s)?
Are their names in the driver somewhere?

> ---
>  drivers/staging/dgnc/Makefile               |   95 +
>  drivers/staging/dgnc/Makefile.inc           |   81 +

How does it build in that there is no tie to the
drivers/staging/Makefile and drivers/staging/Kconfig files?

In looking at these files, it looks like this is still stand-alone,
which isn't ok for the kernel build process, this should be changed.

>  drivers/staging/dgnc/dgnc_cls.c             | 1412 +++++++++++
>  drivers/staging/dgnc/dgnc_driver.c          | 1028 ++++++++
>  drivers/staging/dgnc/dgnc_mgmt.c            |  313 +++
>  drivers/staging/dgnc/dgnc_neo.c             | 1977 +++++++++++++++
>  drivers/staging/dgnc/dgnc_proc.c            | 1551 ++++++++++++
>  drivers/staging/dgnc/dgnc_sysfs.c           |  761 ++++++
>  drivers/staging/dgnc/dgnc_trace.c           |  187 ++
>  drivers/staging/dgnc/dgnc_tty.c             | 3648 +++++++++++++++++++++++++++
>  drivers/staging/dgnc/include/CVS/Entries    |   13 +
>  drivers/staging/dgnc/include/CVS/Repository |    1 +
>  drivers/staging/dgnc/include/CVS/Root       |    1 +

No need to check CVS meta-files into a git tree :)

>  drivers/staging/dgnc/include/dgnc_cls.h     |   90 +
>  drivers/staging/dgnc/include/dgnc_driver.h  |  566 +++++
>  drivers/staging/dgnc/include/dgnc_kcompat.h |   91 +
>  drivers/staging/dgnc/include/dgnc_mgmt.h    |   37 +
>  drivers/staging/dgnc/include/dgnc_neo.h     |  157 ++
>  drivers/staging/dgnc/include/dgnc_pci.h     |   77 +
>  drivers/staging/dgnc/include/dgnc_proc.h    |  147 ++
>  drivers/staging/dgnc/include/dgnc_sysfs.h   |   49 +
>  drivers/staging/dgnc/include/dgnc_trace.h   |   45 +
>  drivers/staging/dgnc/include/dgnc_tty.h     |   42 +
>  drivers/staging/dgnc/include/dgnc_types.h   |   36 +
>  drivers/staging/dgnc/include/digi.h         |  419 +++
>  drivers/staging/dgnc/include/dpacompat.h    |  115 +

All of these .h files should be in the drivers/staging/dgnc/ directory,
no need to put the in a separate include directory.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2013-07-17 21:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 20:18 [PATCH] Adds Digi driver to staging Lidza Louina
2013-07-17 21:49 ` Greg KH [this message]
2013-07-18 12:26   ` Mark Hounschell
2013-07-18 17:40     ` Greg KH
2013-07-18 18:25       ` Mark Hounschell
2013-07-18 18:33         ` Greg KH
2013-07-18 18:38           ` Bill Pemberton
2013-07-18 20:16             ` Lidza Louina
2013-07-18 20:48             ` Lidza Louina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130717214905.GA14660@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=lidza.louina@gmail.com \
    --cc=markh@compro.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.