Re: [PATCH] Adds Digi driver to staging.

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Jul 18, 2013 at 02:25:11PM -0400, Mark Hounschell wrote:
> On 07/18/2013 01:40 PM, Greg KH wrote:
> > On Thu, Jul 18, 2013 at 08:26:55AM -0400, Mark Hounschell wrote:
> >> On 07/17/2013 05:49 PM, Greg KH wrote:
> >>> On Wed, Jul 17, 2013 at 04:18:01PM -0400, Lidza Louina wrote:
> >>>> This patch adds the Digi driver to staging.
> >>>
> >>> Which digi driver?  For what hardware?  What type of driver is it?
> >>> Please provide some more details here.
> >>>
> >>
> >>   From the readme:
> >>
> >>        This Digi software package includes device drivers for the PCI models
> >>        of the Digi Neo and ClassicBoard series of products.
> >>        It is currently supported on the following hardware platforms:
> >>
> >>        o Standard i386/i486 and Pentium PC (x86 32bit)
> >>        o x86 64bit
> >
> > I was "hinting" that this needed to be explained in the changelog entry.
> > The part about the architectures is not needed, as, unless something
> > really strange is going on in the driver, it should work on all cpus
> > that support PCI, right?
> >
> 
> That I cannot attest to. The readme also says:
> 
>      o Standard i386/i486 and Pentium PC (x86 32bit)
>       o x86 64bit
> 
> I can only personally vouch for Intel/Amd CPUs running in 32 bit mode.

I'll look at the driver code, but odds are, unless you are assuming a
specific endian format of some data, all should be fine on other cpu
types.

> >>>> It builds. Needs work done
> >>>> to adapt to the API changes.
> >>>>
> >>>> Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
> >>>
> >>> If at all possible, can we attribute this to the original author(s)?
> >>> Are their names in the driver somewhere?
> >>>
> >>
> >>    * Copyright 2003 Digi International (www.digi.com)
> >>    *      Scott H Kilau <Scott_Kilau at digi dot com>
> >
> > Cool, that's a good start.  Lidza, can you use this as the "From:" email
> > address for the initial import?  Then do follow-on patches that add it
> > to the build with your own Makefile and Kbuild files, and then any
> > follow-on patches fixing issues.  That way Scott gets the proper credit
> > for the initial code, and you get the credit for doing all of the work
> > to include it into the tree.
> >
> > thanks,
> >
> > greg k-h
> > .
> >
> 
> Just to insure there is no duplication of work going on, I see 4 Digi 
> drivers referenced at:
> 
> http://linuxdriverproject.org/mediawiki/index.php/Out_Of_Tree_Drivers#Multiport_Serial_Devices
> 
> Should I assume that info was put there prior to and expecting for Lidza 
> to start this project??

That's a wiki, I have no idea who wrote that, and I don't think it has
anything to do with Lidza's project, other than proof that it should be
done :)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel