All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Sathish N <sathish.n@globaledgesoft.com>
Cc: linux-bluetooth@vger.kernel.org, girish.br@globaledgesoft.com,
	ajay.kv@globaledgesoft.com, anderson.lizardo@openbossa.org
Subject: Re: [PATCH bluez] attrib: Fix interactive gatttool segfault
Date: Thu, 18 Jul 2013 14:16:46 +0300	[thread overview]
Message-ID: <20130718111646.GA4708@x220.p-661hnu-f1> (raw)
In-Reply-To: <1374144156-16351-1-git-send-email-sathish.n@globaledgesoft.com>

Hi Satish,

On Thu, Jul 18, 2013, Sathish N wrote:
> From: sathish N <sathish.n@globaledgesoft.com>

Since this seems to be your first submission let me confirm these git
author details: is this really how you want your author name to be, i.e.
with a lower case "s" and just "N" as your surname? At least in your
email "From" header your name was with a capital "S".

> ---
>  bluez/attrib/interactive.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

There seems to be something strange with your tree that generates this
extra bluez/* path component. It makes "git am" fail to apply this
patch:

Applying: attrib: Fix interactive gatttool segfault
error: bluez/attrib/interactive.c: does not exist in index
Patch failed at 0001 attrib: Fix interactive gatttool segfault

Besides the above issues the actual change to the code itself looks fine
to me.

Johan

  reply	other threads:[~2013-07-18 11:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-18 10:42 [PATCH bluez] attrib: Fix interactive gatttool segfault Sathish N
2013-07-18 11:16 ` Johan Hedberg [this message]
2013-07-18 14:03   ` Sathish N
2013-07-18 14:02 [PATCH BlueZ] attrib: Fix interactive gatttool Segfault Sathish Narasimman
2013-07-19  4:31 [PATCH BlueZ] attrib: Fix interactive gatttool segfault Sathish Narasimman
2013-07-19 11:03 ` Anderson Lizardo
2013-07-19 11:26 ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130718111646.GA4708@x220.p-661hnu-f1 \
    --to=johan.hedberg@gmail.com \
    --cc=ajay.kv@globaledgesoft.com \
    --cc=anderson.lizardo@openbossa.org \
    --cc=girish.br@globaledgesoft.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=sathish.n@globaledgesoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.