All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: Sathish Narasimman <sathish.n@globaledgesoft.com>
Cc: linux-bluetooth@vger.kernel.org, johan.hedberg@gmail.com,
	girish.br@globaledgesoft.com, ajay.kv@globaledgesoft.com
Subject: Re: [PATCH BlueZ] attrib: Fix interactive gatttool segfault
Date: Fri, 19 Jul 2013 07:03:56 -0400	[thread overview]
Message-ID: <CAJdJm_Ovac4BYhhRc-5H7t8wazeT28f0gvb5bOO8yzQ_rbuD-w@mail.gmail.com> (raw)
In-Reply-To: <1374208312-18661-1-git-send-email-sathish.n@globaledgesoft.com>

Hi Sathish,

On Fri, Jul 19, 2013 at 12:31 AM, Sathish Narasimman
<sathish.n@globaledgesoft.com> wrote:
> passing the special character single quote
>
> $gatttool -I
> [   ][                 ][LE]> '
> Segmentation fault (core dumped)
>
> Checking g_shell_parse_argv fail status(return FALSE on failure), works fine.
>
> hope the fix to the previous "git am" error is solved

"git am" on this patch worked here. But one small note (for future
patches; I think there is no need to resend this one as it is easily
fixed locally): if you need to put a comment like the above that you
don't want to appear on the GIT commit message, you should put it
after "---" so it is ignored by "git am". They way I do this is use
"git format-patch" to generate a *.patch file, then I edit this file
to add the note after the "---" and send the patch using git send-mail
<file>.patch.

Best Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil

  reply	other threads:[~2013-07-19 11:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19  4:31 [PATCH BlueZ] attrib: Fix interactive gatttool segfault Sathish Narasimman
2013-07-19 11:03 ` Anderson Lizardo [this message]
2013-07-19 11:26 ` Johan Hedberg
  -- strict thread matches above, loose matches on Subject: below --
2013-07-18 14:02 [PATCH BlueZ] attrib: Fix interactive gatttool Segfault Sathish Narasimman
2013-07-18 10:42 [PATCH bluez] attrib: Fix interactive gatttool segfault Sathish N
2013-07-18 11:16 ` Johan Hedberg
2013-07-18 14:03   ` Sathish N

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJdJm_Ovac4BYhhRc-5H7t8wazeT28f0gvb5bOO8yzQ_rbuD-w@mail.gmail.com \
    --to=anderson.lizardo@openbossa.org \
    --cc=ajay.kv@globaledgesoft.com \
    --cc=girish.br@globaledgesoft.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=sathish.n@globaledgesoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.