* [PATCH v4 1/7] xfs: create wrappers for converting kuid_t to/from uid_t
@ 2013-07-17 15:47 Dwight Engen
2013-07-19 5:19 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Dwight Engen @ 2013-07-17 15:47 UTC (permalink / raw)
To: xfs
Signed-off-by: Dwight Engen <dwight.engen@oracle.com>
---
fs/xfs/xfs_linux.h | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
index 800f896..761e4c0 100644
--- a/fs/xfs/xfs_linux.h
+++ b/fs/xfs/xfs_linux.h
@@ -159,6 +159,32 @@
#define MAX(a,b) (max(a,b))
#define howmany(x, y) (((x)+((y)-1))/(y))
+/* Kernel uid/gid conversion. These are used to convert to/from the on disk
+ * uid_t/gid_t types to the kuid_t/kgid_t types that the kernel uses internally.
+ * The conversion here is type only, the value will remain the same since we
+ * are converting to the init_user_ns. The uid is later mapped to a particular
+ * user namespace value when crossing the kernel/user boundary.
+ */
+static inline __uint32_t xfs_kuid_to_uid(kuid_t uid)
+{
+ return from_kuid(&init_user_ns, uid);
+}
+
+static inline kuid_t xfs_uid_to_kuid(__uint32_t uid)
+{
+ return make_kuid(&init_user_ns, uid);
+}
+
+static inline __uint32_t xfs_kgid_to_gid(kgid_t gid)
+{
+ return from_kgid(&init_user_ns, gid);
+}
+
+static inline kgid_t xfs_gid_to_kgid(__uint32_t gid)
+{
+ return make_kgid(&init_user_ns, gid);
+}
+
/*
* Various platform dependent calls that don't fit anywhere else
*/
--
1.8.1.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4 1/7] xfs: create wrappers for converting kuid_t to/from uid_t
2013-07-17 15:47 [PATCH v4 1/7] xfs: create wrappers for converting kuid_t to/from uid_t Dwight Engen
@ 2013-07-19 5:19 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2013-07-19 5:19 UTC (permalink / raw)
To: Dwight Engen; +Cc: xfs
On Wed, Jul 17, 2013 at 11:47:14AM -0400, Dwight Engen wrote:
> Signed-off-by: Dwight Engen <dwight.engen@oracle.com>
> ---
> fs/xfs/xfs_linux.h | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
> index 800f896..761e4c0 100644
> --- a/fs/xfs/xfs_linux.h
> +++ b/fs/xfs/xfs_linux.h
> @@ -159,6 +159,32 @@
> #define MAX(a,b) (max(a,b))
> #define howmany(x, y) (((x)+((y)-1))/(y))
>
> +/* Kernel uid/gid conversion. These are used to convert to/from the on disk
> + * uid_t/gid_t types to the kuid_t/kgid_t types that the kernel uses internally.
> + * The conversion here is type only, the value will remain the same since we
> + * are converting to the init_user_ns. The uid is later mapped to a particular
> + * user namespace value when crossing the kernel/user boundary.
> + */
> +static inline __uint32_t xfs_kuid_to_uid(kuid_t uid)
> +{
> + return from_kuid(&init_user_ns, uid);
> +}
> +
> +static inline kuid_t xfs_uid_to_kuid(__uint32_t uid)
> +{
> + return make_kuid(&init_user_ns, uid);
> +}
> +
> +static inline __uint32_t xfs_kgid_to_gid(kgid_t gid)
> +{
> + return from_kgid(&init_user_ns, gid);
> +}
> +
> +static inline kgid_t xfs_gid_to_kgid(__uint32_t gid)
> +{
> + return make_kgid(&init_user_ns, gid);
> +}
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-19 5:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-17 15:47 [PATCH v4 1/7] xfs: create wrappers for converting kuid_t to/from uid_t Dwight Engen
2013-07-19 5:19 ` Dave Chinner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.