* [PATCH] ARM: shmobile: lager-reference: Add LED6-LED8 to the device tree @ 2013-07-16 9:45 Laurent Pinchart 2013-07-23 1:24 ` Simon Horman 2014-03-17 2:18 ` Simon Horman 0 siblings, 2 replies; 12+ messages in thread From: Laurent Pinchart @ 2013-07-16 9:45 UTC (permalink / raw) To: linux-sh LED6 to LED8 are GPIO LEDs. Add corresponding DT nodes. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm/boot/dts/r8a7790-lager-reference.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+) The patch is based on renesas-devel-20130716. diff --git a/arch/arm/boot/dts/r8a7790-lager-reference.dts b/arch/arm/boot/dts/r8a7790-lager-reference.dts index fa5b81b..5ee71cf5 100644 --- a/arch/arm/boot/dts/r8a7790-lager-reference.dts +++ b/arch/arm/boot/dts/r8a7790-lager-reference.dts @@ -10,6 +10,7 @@ /dts-v1/; /include/ "r8a7790.dtsi" +#include <dt-bindings/gpio/gpio.h> / { model = "Lager"; @@ -28,4 +29,17 @@ #address-cells = <1>; #size-cells = <1>; }; + + leds { + compatible = "gpio-leds"; + led6 { + gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>; + }; + led7 { + gpios = <&gpio4 23 GPIO_ACTIVE_HIGH>; + }; + led8 { + gpios = <&gpio5 17 GPIO_ACTIVE_HIGH>; + }; + }; }; -- Regards, Laurent Pinchart ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: shmobile: lager-reference: Add LED6-LED8 to the device tree 2013-07-16 9:45 [PATCH] ARM: shmobile: lager-reference: Add LED6-LED8 to the device tree Laurent Pinchart @ 2013-07-23 1:24 ` Simon Horman 2014-03-17 2:18 ` Simon Horman 1 sibling, 0 replies; 12+ messages in thread From: Simon Horman @ 2013-07-23 1:24 UTC (permalink / raw) To: linux-sh On Tue, Jul 16, 2013 at 11:45:56AM +0200, Laurent Pinchart wrote: > LED6 to LED8 are GPIO LEDs. Add corresponding DT nodes. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm/boot/dts/r8a7790-lager-reference.dts | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > The patch is based on renesas-devel-20130716. Thanks, I have queued this up for v3.12 in the dt2 branch of the renesas tree. ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: shmobile: lager-reference: Work around core clock issues @ 2014-03-17 2:18 ` Simon Horman 0 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2014-03-17 2:18 UTC (permalink / raw) To: linux-arm-kernel Due to issues with runtime PM clock management, clocks not explicitly managed by their drivers may not be enabled at all, or be inadvertently disabled by the clk_disable_unused() late initcall. Until this is fixed, add a temporary workaround, calling shmobile_clk_workaround() with enable = true. For now this enables the clocks for: ether, msiof1, qspi_mod, and thermal. More clocks can be added if needed. Based on work for the koelsch board by eert Uytterhoeven. Cc: Geert Uytterhoeven <geert+renesas@linux-m68k.org> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- arch/arm/mach-shmobile/board-lager-reference.c | 11 +++++++++++ 1 file changed, 11 insertions(+) Based on renesas-devel-v3.14-rc6-20140314 diff --git a/arch/arm/mach-shmobile/board-lager-reference.c b/arch/arm/mach-shmobile/board-lager-reference.c index 7ff395e..313118c 100644 --- a/arch/arm/mach-shmobile/board-lager-reference.c +++ b/arch/arm/mach-shmobile/board-lager-reference.c @@ -108,9 +108,20 @@ static const struct clk_name clk_names[] __initconst = { { "lvds1", "lvds.1", "rcar-du-r8a7790" }, }; +/* + * This is a really crude hack to work around core platform clock issues + */ +static const struct clk_name clk_enables[] __initconst = { + { "ether", NULL, "ee700000.ethernet" }, + { "msiof1", NULL, "e6e10000.spi" }, + { "qspi_mod", NULL, "e6b10000.spi" }, + { "thermal", NULL, "e61f0000.thermal" }, +}; + static void __init lager_add_standard_devices(void) { shmobile_clk_workaround(clk_names, ARRAY_SIZE(clk_names), false); + shmobile_clk_workaround(clk_enables, ARRAY_SIZE(clk_enables), true); r8a7790_add_dt_devices(); of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); -- 1.8.5.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] ARM: shmobile: lager-reference: Work around core clock issues @ 2014-03-17 2:18 ` Simon Horman 0 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2014-03-17 2:18 UTC (permalink / raw) To: linux-arm-kernel Due to issues with runtime PM clock management, clocks not explicitly managed by their drivers may not be enabled at all, or be inadvertently disabled by the clk_disable_unused() late initcall. Until this is fixed, add a temporary workaround, calling shmobile_clk_workaround() with enable == true. For now this enables the clocks for: ether, msiof1, qspi_mod, and thermal. More clocks can be added if needed. Based on work for the koelsch board by eert Uytterhoeven. Cc: Geert Uytterhoeven <geert+renesas@linux-m68k.org> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- arch/arm/mach-shmobile/board-lager-reference.c | 11 +++++++++++ 1 file changed, 11 insertions(+) Based on renesas-devel-v3.14-rc6-20140314 diff --git a/arch/arm/mach-shmobile/board-lager-reference.c b/arch/arm/mach-shmobile/board-lager-reference.c index 7ff395e..313118c 100644 --- a/arch/arm/mach-shmobile/board-lager-reference.c +++ b/arch/arm/mach-shmobile/board-lager-reference.c @@ -108,9 +108,20 @@ static const struct clk_name clk_names[] __initconst = { { "lvds1", "lvds.1", "rcar-du-r8a7790" }, }; +/* + * This is a really crude hack to work around core platform clock issues + */ +static const struct clk_name clk_enables[] __initconst = { + { "ether", NULL, "ee700000.ethernet" }, + { "msiof1", NULL, "e6e10000.spi" }, + { "qspi_mod", NULL, "e6b10000.spi" }, + { "thermal", NULL, "e61f0000.thermal" }, +}; + static void __init lager_add_standard_devices(void) { shmobile_clk_workaround(clk_names, ARRAY_SIZE(clk_names), false); + shmobile_clk_workaround(clk_enables, ARRAY_SIZE(clk_enables), true); r8a7790_add_dt_devices(); of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); -- 1.8.5.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: shmobile: lager-reference: Work around core clock issues 2014-03-17 2:18 ` Simon Horman @ 2014-03-17 2:26 ` Kuninori Morimoto -1 siblings, 0 replies; 12+ messages in thread From: Kuninori Morimoto @ 2014-03-17 2:26 UTC (permalink / raw) To: linux-arm-kernel Hi Simon very tiny comment > Due to issues with runtime PM clock management, clocks not explicitly > managed by their drivers may not be enabled at all, or be inadvertently > disabled by the clk_disable_unused() late initcall. > > Until this is fixed, add a temporary workaround, calling > shmobile_clk_workaround() with enable = true. > > For now this enables the clocks for: ether, msiof1, qspi_mod, and > thermal. More clocks can be added if needed. > > Based on work for the koelsch board by eert Uytterhoeven. I guess - Based on work for the koelsch board by eert Uytterhoeven. + Based on work for the koelsch board by Geert Uytterhoeven. ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: shmobile: lager-reference: Work around core clock issues @ 2014-03-17 2:26 ` Kuninori Morimoto 0 siblings, 0 replies; 12+ messages in thread From: Kuninori Morimoto @ 2014-03-17 2:26 UTC (permalink / raw) To: linux-arm-kernel Hi Simon very tiny comment > Due to issues with runtime PM clock management, clocks not explicitly > managed by their drivers may not be enabled at all, or be inadvertently > disabled by the clk_disable_unused() late initcall. > > Until this is fixed, add a temporary workaround, calling > shmobile_clk_workaround() with enable == true. > > For now this enables the clocks for: ether, msiof1, qspi_mod, and > thermal. More clocks can be added if needed. > > Based on work for the koelsch board by eert Uytterhoeven. I guess - Based on work for the koelsch board by eert Uytterhoeven. + Based on work for the koelsch board by Geert Uytterhoeven. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: shmobile: lager-reference: Work around core clock issues 2014-03-17 2:26 ` Kuninori Morimoto @ 2014-03-17 3:44 ` Simon Horman -1 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2014-03-17 3:44 UTC (permalink / raw) To: linux-arm-kernel On Sun, Mar 16, 2014 at 07:26:07PM -0700, Kuninori Morimoto wrote: > > Hi Simon > > very tiny comment > > > Due to issues with runtime PM clock management, clocks not explicitly > > managed by their drivers may not be enabled at all, or be inadvertently > > disabled by the clk_disable_unused() late initcall. > > > > Until this is fixed, add a temporary workaround, calling > > shmobile_clk_workaround() with enable = true. > > > > For now this enables the clocks for: ether, msiof1, qspi_mod, and > > thermal. More clocks can be added if needed. > > > > Based on work for the koelsch board by eert Uytterhoeven. > > I guess > > - Based on work for the koelsch board by eert Uytterhoeven. > + Based on work for the koelsch board by Geert Uytterhoeven. Thanks! I'll fix that. ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: shmobile: lager-reference: Work around core clock issues @ 2014-03-17 3:44 ` Simon Horman 0 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2014-03-17 3:44 UTC (permalink / raw) To: linux-arm-kernel On Sun, Mar 16, 2014 at 07:26:07PM -0700, Kuninori Morimoto wrote: > > Hi Simon > > very tiny comment > > > Due to issues with runtime PM clock management, clocks not explicitly > > managed by their drivers may not be enabled at all, or be inadvertently > > disabled by the clk_disable_unused() late initcall. > > > > Until this is fixed, add a temporary workaround, calling > > shmobile_clk_workaround() with enable == true. > > > > For now this enables the clocks for: ether, msiof1, qspi_mod, and > > thermal. More clocks can be added if needed. > > > > Based on work for the koelsch board by eert Uytterhoeven. > > I guess > > - Based on work for the koelsch board by eert Uytterhoeven. > + Based on work for the koelsch board by Geert Uytterhoeven. Thanks! I'll fix that. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: shmobile: lager-reference: Work around core clock issues 2014-03-17 2:18 ` Simon Horman @ 2014-03-17 8:01 ` Geert Uytterhoeven -1 siblings, 0 replies; 12+ messages in thread From: Geert Uytterhoeven @ 2014-03-17 8:01 UTC (permalink / raw) To: linux-arm-kernel On Mon, Mar 17, 2014 at 3:18 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Due to issues with runtime PM clock management, clocks not explicitly > managed by their drivers may not be enabled at all, or be inadvertently > disabled by the clk_disable_unused() late initcall. > > Until this is fixed, add a temporary workaround, calling > shmobile_clk_workaround() with enable = true. > > For now this enables the clocks for: ether, msiof1, qspi_mod, and > thermal. More clocks can be added if needed. > > Based on work for the koelsch board by eert Uytterhoeven. > > Cc: Geert Uytterhoeven <geert+renesas@linux-m68k.org> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org> (if the typo reported by Morimoto-san gets fixed ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: shmobile: lager-reference: Work around core clock issues @ 2014-03-17 8:01 ` Geert Uytterhoeven 0 siblings, 0 replies; 12+ messages in thread From: Geert Uytterhoeven @ 2014-03-17 8:01 UTC (permalink / raw) To: linux-arm-kernel On Mon, Mar 17, 2014 at 3:18 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Due to issues with runtime PM clock management, clocks not explicitly > managed by their drivers may not be enabled at all, or be inadvertently > disabled by the clk_disable_unused() late initcall. > > Until this is fixed, add a temporary workaround, calling > shmobile_clk_workaround() with enable == true. > > For now this enables the clocks for: ether, msiof1, qspi_mod, and > thermal. More clocks can be added if needed. > > Based on work for the koelsch board by eert Uytterhoeven. > > Cc: Geert Uytterhoeven <geert+renesas@linux-m68k.org> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org> (if the typo reported by Morimoto-san gets fixed ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: shmobile: lager-reference: Work around core clock issues 2014-03-17 8:01 ` Geert Uytterhoeven @ 2014-03-17 8:21 ` Simon Horman -1 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2014-03-17 8:21 UTC (permalink / raw) To: linux-arm-kernel On Mon, Mar 17, 2014 at 09:01:30AM +0100, Geert Uytterhoeven wrote: > On Mon, Mar 17, 2014 at 3:18 AM, Simon Horman > <horms+renesas@verge.net.au> wrote: > > Due to issues with runtime PM clock management, clocks not explicitly > > managed by their drivers may not be enabled at all, or be inadvertently > > disabled by the clk_disable_unused() late initcall. > > > > Until this is fixed, add a temporary workaround, calling > > shmobile_clk_workaround() with enable = true. > > > > For now this enables the clocks for: ether, msiof1, qspi_mod, and > > thermal. More clocks can be added if needed. > > > > Based on work for the koelsch board by eert Uytterhoeven. > > > > Cc: Geert Uytterhoeven <geert+renesas@linux-m68k.org> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Acked-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org> > (if the typo reported by Morimoto-san gets fixed ;-) Indeed, sorry about misspelling your name. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: shmobile: lager-reference: Work around core clock issues @ 2014-03-17 8:21 ` Simon Horman 0 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2014-03-17 8:21 UTC (permalink / raw) To: linux-arm-kernel On Mon, Mar 17, 2014 at 09:01:30AM +0100, Geert Uytterhoeven wrote: > On Mon, Mar 17, 2014 at 3:18 AM, Simon Horman > <horms+renesas@verge.net.au> wrote: > > Due to issues with runtime PM clock management, clocks not explicitly > > managed by their drivers may not be enabled at all, or be inadvertently > > disabled by the clk_disable_unused() late initcall. > > > > Until this is fixed, add a temporary workaround, calling > > shmobile_clk_workaround() with enable == true. > > > > For now this enables the clocks for: ether, msiof1, qspi_mod, and > > thermal. More clocks can be added if needed. > > > > Based on work for the koelsch board by eert Uytterhoeven. > > > > Cc: Geert Uytterhoeven <geert+renesas@linux-m68k.org> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Acked-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org> > (if the typo reported by Morimoto-san gets fixed ;-) Indeed, sorry about misspelling your name. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-03-17 8:21 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-07-16 9:45 [PATCH] ARM: shmobile: lager-reference: Add LED6-LED8 to the device tree Laurent Pinchart 2013-07-23 1:24 ` Simon Horman 2014-03-17 2:18 ` [PATCH] ARM: shmobile: lager-reference: Work around core clock issues Simon Horman 2014-03-17 2:18 ` Simon Horman 2014-03-17 2:26 ` Kuninori Morimoto 2014-03-17 2:26 ` Kuninori Morimoto 2014-03-17 3:44 ` Simon Horman 2014-03-17 3:44 ` Simon Horman 2014-03-17 8:01 ` Geert Uytterhoeven 2014-03-17 8:01 ` Geert Uytterhoeven 2014-03-17 8:21 ` Simon Horman 2014-03-17 8:21 ` Simon Horman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.