* [PATCH] Fix a typo in pSeries_lpar_hpte_insert()
@ 2013-07-22 5:23 Denis Kirjanov
2013-07-22 15:24 ` Aneesh Kumar K.V
0 siblings, 1 reply; 3+ messages in thread
From: Denis Kirjanov @ 2013-07-22 5:23 UTC (permalink / raw)
To: aneesh.kumar; +Cc: Denis Kirjanov, linuxppc-dev
Fix a typo in pSeries_lpar_hpte_insert()
Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
---
arch/powerpc/platforms/pseries/lpar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/lpar.c b/arch/powerpc/platforms/pseries/lpar.c
index 0da39fe..c4112ed 100644
--- a/arch/powerpc/platforms/pseries/lpar.c
+++ b/arch/powerpc/platforms/pseries/lpar.c
@@ -136,7 +136,7 @@ static long pSeries_lpar_hpte_insert(unsigned long hpte_group,
flags = 0;
/* Make pHyp happy */
- if ((rflags & _PAGE_NO_CACHE) & !(rflags & _PAGE_WRITETHRU))
+ if ((rflags & _PAGE_NO_CACHE) && !(rflags & _PAGE_WRITETHRU))
hpte_r &= ~_PAGE_COHERENT;
if (firmware_has_feature(FW_FEATURE_XCMO) && !(hpte_r & HPTE_R_N))
flags |= H_COALESCE_CAND;
--
1.8.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix a typo in pSeries_lpar_hpte_insert()
2013-07-22 5:23 [PATCH] Fix a typo in pSeries_lpar_hpte_insert() Denis Kirjanov
@ 2013-07-22 15:24 ` Aneesh Kumar K.V
2013-07-23 13:42 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Aneesh Kumar K.V @ 2013-07-22 15:24 UTC (permalink / raw)
To: Denis Kirjanov; +Cc: Denis Kirjanov, linuxppc-dev
Denis Kirjanov <kda@linux-powerpc.org> writes:
> Fix a typo in pSeries_lpar_hpte_insert()
>
> Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
looks good
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
We may want to add the commit that introduced the change ?
801eb73f45371accc78ca9d6d22d647eeb722c11
> ---
> arch/powerpc/platforms/pseries/lpar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/lpar.c b/arch/powerpc/platforms/pseries/lpar.c
> index 0da39fe..c4112ed 100644
> --- a/arch/powerpc/platforms/pseries/lpar.c
> +++ b/arch/powerpc/platforms/pseries/lpar.c
> @@ -136,7 +136,7 @@ static long pSeries_lpar_hpte_insert(unsigned long hpte_group,
> flags = 0;
>
> /* Make pHyp happy */
> - if ((rflags & _PAGE_NO_CACHE) & !(rflags & _PAGE_WRITETHRU))
> + if ((rflags & _PAGE_NO_CACHE) && !(rflags & _PAGE_WRITETHRU))
> hpte_r &= ~_PAGE_COHERENT;
> if (firmware_has_feature(FW_FEATURE_XCMO) && !(hpte_r & HPTE_R_N))
> flags |= H_COALESCE_CAND;
> --
> 1.8.0.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix a typo in pSeries_lpar_hpte_insert()
2013-07-22 15:24 ` Aneesh Kumar K.V
@ 2013-07-23 13:42 ` Michael Ellerman
0 siblings, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2013-07-23 13:42 UTC (permalink / raw)
To: Aneesh Kumar K.V; +Cc: Denis Kirjanov, linuxppc-dev
On Mon, Jul 22, 2013 at 08:54:31PM +0530, Aneesh Kumar K.V wrote:
> Denis Kirjanov <kda@linux-powerpc.org> writes:
>
> > Fix a typo in pSeries_lpar_hpte_insert()
> >
> > Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
>
> looks good
>
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> We may want to add the commit that introduced the change ?
>
> 801eb73f45371accc78ca9d6d22d647eeb722c11
Yes, as well as describe what the typo is, and what the implications
are - ie. what was broken and is now fixed.
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-23 13:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-22 5:23 [PATCH] Fix a typo in pSeries_lpar_hpte_insert() Denis Kirjanov
2013-07-22 15:24 ` Aneesh Kumar K.V
2013-07-23 13:42 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.