build for pv-grub stubdom

build for pv-grub stubdom

[IAN DELANEY]

Does this

install -d -m0755 -p
"/mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/image//usr/lib/xen/boot"
install -m0644 -p mini-os-x86_32-grub/mini-os.gz
"/mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/image//usr/lib/xen/boot/pv-grub-x86_32.gz"
make: Leaving directory
`/mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom'
>>> Completed installing xen-pvgrub-4.3.0
>>> into /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/image/

 * QA Notice: make jobserver unavailable:
 * 
 * 	make[1]: warning: jobserver unavailable: using -j1.  Add `+'
   to parent make rule.
 * 	make[1]: warning: jobserver unavailable: using -j1.  Add `+'
   to parent make rule.

 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
   warning: implicit declaration of function
   ‘kill’ [-Wimplicit-function-declaration]
 * ../grub-upstream/stage2/builtins.c:1728:3: warning: implicit
   declaration of function ‘do_exit’ [-Wimplicit-function-declaration]
 * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:5:
   warning: implicit declaration of function
   ‘memcpy’ [-Wimplicit-function-declaration]
 * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:455:5:
   warning: implicit declaration of function
   ‘memmove’ [-Wimplicit-function-declaration]
 * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:457:5:
   warning: implicit declaration of function
   ‘memset’ [-Wimplicit-function-declaration]
 * ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
   warning: implicit declaration of function
   ‘kill’ [-Wimplicit-function-declaration]
 * ../../../../../newlib-1.16.0/newlib/libc/reent/fstat64r.c:65:3:
   warning: implicit declaration of function
   ‘_fstat64’ [-Wimplicit-function-declaration]
 * ../../../../../newlib-1.16.0/newlib/libc/reent/open64r.c:62:3:
   warning: implicit declaration of function
   ‘_open64’ [-Wimplicit-function-declaration]
 * ../../../../../newlib-1.16.0/newlib/libc/reent/lseek64r.c:61:3:
   warning: implicit declaration of function
   ‘lseek64’ [-Wimplicit-function-declaration]
 * ../../../../newlib-1.16.0/libgloss/i386/cygmon-gmon.c:355:7:
   warning: implicit declaration of function
   ‘profil’ [-Wimplicit-function-declaration]
 * ../grub-upstream/stage2/builtins.c:1728:3: warning: implicit
   declaration of function ‘do_exit’ [-Wimplicit-function-declaration]
 * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:5:
   warning: implicit declaration of function
   ‘memcpy’ [-Wimplicit-function-declaration]
 * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:455:5:
   warning: implicit declaration of function
   ‘memmove’ [-Wimplicit-function-declaration]
 * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:457:5:
   warning: implicit declaration of function
   ‘memset’ [-Wimplicit-function-declaration]


 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:14:
   warning: incompatible implicit declaration of built-in function
   ‘memcpy’ [enabled by default]
 * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:455:14:
   warning: incompatible implicit declaration of built-in function
   ‘memmove’ [enabled by default]
 * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:457:14:
   warning: incompatible implicit declaration of built-in function
   ‘memset’ [enabled by default]
 * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:14:
   warning: incompatible implicit declaration of built-in function
   ‘memcpy’ [enabled by default]
 * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:455:14:
   warning: incompatible implicit declaration of built-in function
   ‘memmove’ [enabled by default]
 * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:457:14:
   warning: incompatible implicit declaration of built-in function
   ‘memset’ [enabled by default]

 * Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: http://xen.org/


draw any concern from anyone?  These have been in place for a long time
in 4.x.x. Basically portage keep a memory of any and all gcc warnings
and lists them all in one list at the build's end. I highlighted them
before, thought I might 'try again'.

-- 
kind regards

Ian Delaney

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: build for pv-grub stubdom

[Ian Campbell]

On Mon, 2013-07-22 at 00:36 +0800, IAN DELANEY wrote:
> Does this
[...]
> draw any concern from anyone?  These have been in place for a long time
> in 4.x.x. Basically portage keep a memory of any and all gcc warnings
> and lists them all in one list at the build's end. I highlighted them
> before, thought I might 'try again'.

Thanks for bringing them up.

These mostly seem to be from 3rd party code included with Xen (mostly
newlib it seems). Unless there are upstream fixes which we could
backport (or resync to a new-newlib) I don't think we care all that
much. There are also plans afoot to replace newlib with something
better, so it might not even be worth doing that.

Ian.

Re: build for pv-grub stubdom

[Samuel Thibault]

Hello,

IAN DELANEY, le Mon 22 Jul 2013 00:36:43 +0800, a écrit :
>  * ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
>    warning: implicit declaration of function
>    ‘kill’ [-Wimplicit-function-declaration]
>    ‘_fstat64’ [-Wimplicit-function-declaration]
>    ‘_open64’ [-Wimplicit-function-declaration]
>    ‘lseek64’ [-Wimplicit-function-declaration]
>    ‘profil’ [-Wimplicit-function-declaration]

We don't actually provide these functions.

>  * ../grub-upstream/stage2/builtins.c:1728:3: warning: implicit
>    declaration of function ‘do_exit’ [-Wimplicit-function-declaration]

This should be fixed by this I guess:

diff --git a/stubdom/grub/config.h b/stubdom/grub/config.h
index 1649d51..15a6583 100644
--- a/stubdom/grub/config.h
+++ b/stubdom/grub/config.h
@@ -2,6 +2,7 @@
 #undef putchar
 #include <ctype.h>
 #include <string.h>
+#include <kernel.h>
 #define debug _debug
 #define grub_halt(a) do_exit()
 #define printf grub_printf

>  * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:5:
>    warning: implicit declaration of function
>    ‘memcpy’ [-Wimplicit-function-declaration]

And that, by that:

diff --git a/xen/include/xen/libelf.h b/xen/include/xen/libelf.h
index 2a6fa54..e65db6d 100644
--- a/xen/include/xen/libelf.h
+++ b/xen/include/xen/libelf.h
@@ -39,11 +39,13 @@ typedef int elf_negerrnoval; /* 0: ok; -EFOO: error */
 #ifdef __XEN__
 #include <public/elfnote.h>
 #include <public/features.h>
+#include <xen/string.h>
 #else
 #include <xen/elfnote.h>
 #include <xen/features.h>
 
 #include <stdarg.h>
+#include <string.h>
 
 struct elf_binary;
 typedef void elf_log_callback(struct elf_binary*, void *caller_data,

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: build for pv-grub stubdom

[Ian Campbell]

On Fri, 2013-07-26 at 15:55 +0200, Samuel Thibault wrote:
> Hello,
> 
> IAN DELANEY, le Mon 22 Jul 2013 00:36:43 +0800, a écrit :
> >  * ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
> >    warning: implicit declaration of function
> >    ‘kill’ [-Wimplicit-function-declaration]
> >    ‘_fstat64’ [-Wimplicit-function-declaration]
> >    ‘_open64’ [-Wimplicit-function-declaration]
> >    ‘lseek64’ [-Wimplicit-function-declaration]
> >    ‘profil’ [-Wimplicit-function-declaration]
> 
> We don't actually provide these functions.
> 
> >  * ../grub-upstream/stage2/builtins.c:1728:3: warning: implicit
> >    declaration of function ‘do_exit’ [-Wimplicit-function-declaration]
> 
> This should be fixed by this I guess:

Ian, can you confirm if these work. If so the Samuel please can I get a
S-o-b (and ideally a commit message so I don't have to fabricate one).

Thanks,
Ian.

> 
> diff --git a/stubdom/grub/config.h b/stubdom/grub/config.h
> index 1649d51..15a6583 100644
> --- a/stubdom/grub/config.h
> +++ b/stubdom/grub/config.h
> @@ -2,6 +2,7 @@
>  #undef putchar
>  #include <ctype.h>
>  #include <string.h>
> +#include <kernel.h>
>  #define debug _debug
>  #define grub_halt(a) do_exit()
>  #define printf grub_printf
> 
> >  * /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/work/xen-4.3.0/stubdom/include/xen/libelf/libelf.h:453:5:
> >    warning: implicit declaration of function
> >    ‘memcpy’ [-Wimplicit-function-declaration]
> 
> And that, by that:
> 
> diff --git a/xen/include/xen/libelf.h b/xen/include/xen/libelf.h
> index 2a6fa54..e65db6d 100644
> --- a/xen/include/xen/libelf.h
> +++ b/xen/include/xen/libelf.h
> @@ -39,11 +39,13 @@ typedef int elf_negerrnoval; /* 0: ok; -EFOO: error */
>  #ifdef __XEN__
>  #include <public/elfnote.h>
>  #include <public/features.h>
> +#include <xen/string.h>
>  #else
>  #include <xen/elfnote.h>
>  #include <xen/features.h>
>  
>  #include <stdarg.h>
> +#include <string.h>
>  
>  struct elf_binary;
>  typedef void elf_log_callback(struct elf_binary*, void *caller_data,
> 
> Samuel
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[PATCH] Fix stubdom undeclared function build warnings

[Samuel Thibault]

This includes a few headers to fix some missing function declarations.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

diff --git a/stubdom/grub/config.h b/stubdom/grub/config.h
index 1649d51..15a6583 100644
--- a/stubdom/grub/config.h
+++ b/stubdom/grub/config.h
@@ -2,6 +2,7 @@
 #undef putchar
 #include <ctype.h>
 #include <string.h>
+#include <kernel.h>
 #define debug _debug
 #define grub_halt(a) do_exit()
 #define printf grub_printf
diff --git a/xen/include/xen/libelf.h b/xen/include/xen/libelf.h
index 2a6fa54..e65db6d 100644
--- a/xen/include/xen/libelf.h
+++ b/xen/include/xen/libelf.h
@@ -39,11 +39,13 @@ typedef int elf_negerrnoval; /* 0: ok; -EFOO: error */
 #ifdef __XEN__
 #include <public/elfnote.h>
 #include <public/features.h>
+#include <xen/string.h>
 #else
 #include <xen/elfnote.h>
 #include <xen/features.h>
 
 #include <stdarg.h>
+#include <string.h>
 
 struct elf_binary;
 typedef void elf_log_callback(struct elf_binary*, void *caller_data,

Re: build for pv-grub stubdom

[Ian Campbell]

Adding the list back, please don't drop CCs.

On Wed, 2013-07-31 at 15:50 +0800, IAN DELANEY wrote:
> you caught me off guard somewhat here.  I thought from
> 
> < There are also plans afoot to replace newlib with something better,
> < so it might not even be worth doing that.
>  
> it was too trivial.

I did say "might not" and Samuel seemed happy to fix at least some of
them so we might as take those fixes.

>   You have killed a few off.  I added the patch by
> Samuel Thibault (same as what you sent) to xen-pvgrub which builds the
> stubdom and we're down to 
> 
> >>> Completed installing xen-pvgrub-4.3.0
> >>> into /mnt/gen2/TmpDir/portage/app-emulation/xen-pvgrub-4.3.0/image/
> 
>  * QA Notice: make jobserver unavailable:
>  * 
>  * 	make[1]: warning: jobserver unavailable: using -j1.  Add `+'
>    to parent make rule.
>  * 	make[1]: warning: jobserver unavailable: using -j1.  Add `+'
>    to parent make rule.
> 
>  * QA Notice: Package triggers severe warnings which indicate that it
>  *            may exhibit random runtime failures.
>  * ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
>    warning: implicit declaration of function
>    ‘kill’ [-Wimplicit-function-declaration]
>  * ../../../../../newlib-1.16.0/newlib/libc/reent/signalr.c:61:3:
>    warning: implicit declaration of function
>    ‘kill’ [-Wimplicit-function-declaration]
>  * ../../../../../newlib-1.16.0/newlib/libc/reent/fstat64r.c:65:3:
>    warning: implicit declaration of function
>    ‘_fstat64’ [-Wimplicit-function-declaration]
>  * ../../../../../newlib-1.16.0/newlib/libc/reent/lseek64r.c:61:3:
>    warning: implicit declaration of function
>    ‘lseek64’ [-Wimplicit-function-declaration]
>  * ../../../../../newlib-1.16.0/newlib/libc/reent/open64r.c:62:3:
>    warning: implicit declaration of function
>    ‘_open64’ [-Wimplicit-function-declaration]
>  * ../../../../newlib-1.16.0/libgloss/i386/cygmon-gmon.c:355:7:
>    warning: implicit declaration of function
>    ‘profil’ [-Wimplicit-function-declaration]

I think these are all the ones which Samuel indicated were simply not
supported by mini-os. We must not end up linking these files or else
there would be a link time error.

>  * Please do not file a Gentoo bug and instead report the above QA
>  * issues directly to the upstream developers of this software.

Hrm. I would rather hope that bugs would be reported to the Gentoo
maintainer who would take responsiblity with the upstream relationship
rather than pushing it onto the end users who may not be in a position
to make a good report about an issue seen with an ebuild.

Or maybe I misunderstand how Gentoo QA is structured and/or where/who
this suggestion is actually reported to.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: build for pv-grub stubdom

[Ian Campbell]

I've put the list back on the CC, plerase use reply to all.
On Wed, 2013-07-31 at 21:46 +0800, IAN DELANEY wrote:
> On Wed, 31 Jul 2013 13:05:24 +0100
> Ian Campbell <Ian.Campbell@citrix.com> wrote:
> 
> > Adding the list back, please don't drop CCs.
> > 
> 
> > 
> > I think these are all the ones which Samuel indicated were simply not
> > supported by mini-os. We must not end up linking these files or else
> > there would be a link time error.
> > 
> > >  * Please do not file a Gentoo bug and instead report the above QA
> > >  * issues directly to the upstream developers of this software.
> > 
> > Hrm. I would rather hope that bugs would be reported to the Gentoo
> > maintainer who would take responsiblity with the upstream relationship
> > rather than pushing it onto the end users who may not be in a position
> > to make a good report about an issue seen with an ebuild.
> > 
> > Or maybe I misunderstand how Gentoo QA is structured and/or where/who
> > this suggestion is actually reported to.
> > 
> > Ian.
> > 
> 
> Well gentoo QA is pretty 'low level' in this regard or instance. For 1
> I am the xen gentoo maintainer and it was me who observed and sent it,
> however your point remains valid in essence.  The portage package
> itself basically has a ready made list of various known gcc, build,
> test, install errors and actions them accordingly.  Some errors will
> have the msg prompting to report to gentoo bugzilla.  These ones have
> been determined to warrant pointing to upstream directly.  The point is
> somewhat moot since it's me bringing it to yr attention.

OK, that's fine. I was mostly concerned about a clueless but
enthusiastic user picking them up and sending them here with no context
or understanding or ability answer followup questions, which mostly jsut
wastes everyone's time.

> "We must not end up linking these files or else there would be a link
> time error" I have some trouble with from its technical aspect rather
> than a linguistic one.  It's not clear to me whether this is an
> observation of what's happening in the build process or, well,
> something else.  Either way many thanks for picking up on the issue(s).

Right, By "must not" I meant "we aren't in practice".

Ian.

Re: build for pv-grub stubdom

[IAN DELANEY]

On Wed, 31 Jul 2013 14:56:10 +0100
Ian Campbell <Ian.Campbell@citrix.com> wrote:

> You've dropped the list again. I'm going to reply publicly cutting out
> the bit about mva in case he takes offence on the comments about his
> English ;-). I've replied to just that bit below.
> 
 Actually mva was helpful and we got to the bottom of several of the
> issues he reported. He wasn't at all the sort of clueless user I
> mention in my public reply.
> 
> Ian.
> 

sorry Ian, (nice name) I'm a bit naive when it comes to email and CC, I
don't actually email much despite being s dev, I'm kind of a minor
player, however see I CCd to xen-devel@lists.xen.org, do you wish for
more?  I'm glad to see mva's input lead to bearing some nice fruit, and
he's definitely no clueless user.






-- 
kind regards

Ian Delaney

Re: [PATCH] Fix stubdom undeclared function build warnings

[Ian Campbell]

On Mon, 2013-07-29 at 11:18 +0200, Samuel Thibault wrote:
> This includes a few headers to fix some missing function declarations.

I inserted: 

../grub-upstream/stage2/builtins.c:1728:3: warning: implicit declaration of function ‘do_exit’ [-Wimplicit-function-declaration]
stubdom/include/xen/libelf/libelf.h:453:5: warning: implicit declaration of function ‘memcpy’ [-Wimplicit-function-declaration]

> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Acked + added a Reported-by for IAN + applied. 

> 
> diff --git a/stubdom/grub/config.h b/stubdom/grub/config.h
> index 1649d51..15a6583 100644
> --- a/stubdom/grub/config.h
> +++ b/stubdom/grub/config.h
> @@ -2,6 +2,7 @@
>  #undef putchar
>  #include <ctype.h>
>  #include <string.h>
> +#include <kernel.h>
>  #define debug _debug
>  #define grub_halt(a) do_exit()
>  #define printf grub_printf
> diff --git a/xen/include/xen/libelf.h b/xen/include/xen/libelf.h
> index 2a6fa54..e65db6d 100644
> --- a/xen/include/xen/libelf.h
> +++ b/xen/include/xen/libelf.h
> @@ -39,11 +39,13 @@ typedef int elf_negerrnoval; /* 0: ok; -EFOO: error */
>  #ifdef __XEN__
>  #include <public/elfnote.h>
>  #include <public/features.h>
> +#include <xen/string.h>
>  #else
>  #include <xen/elfnote.h>
>  #include <xen/features.h>
>  
>  #include <stdarg.h>
> +#include <string.h>
>  
>  struct elf_binary;
>  typedef void elf_log_callback(struct elf_binary*, void *caller_data,
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: build for pv-grub stubdom

[Samuel Thibault]

Ian Campbell, le Wed 31 Jul 2013 13:05:24 +0100, a écrit :
> I think these are all the ones which Samuel indicated were simply not
> supported by mini-os.

Yes.

Samuel