All of lore.kernel.org
 help / color / mirror / Atom feed
* Fwd: dib8000 scanning not working on 3.10.3
       [not found] <CAER7dwe+kkVoDbRt9Xj8+77tJnL29bxRzHbSPYOrck_HxVsENw@mail.gmail.com>
@ 2013-07-31 18:47 ` Luis Polasek
  2013-08-01 16:36   ` Ezequiel Garcia
  2013-12-10 18:38   ` Fwd: " Ezequiel Garcia
  0 siblings, 2 replies; 13+ messages in thread
From: Luis Polasek @ 2013-07-31 18:47 UTC (permalink / raw)
  To: linux-media; +Cc: jbucar

Hi, I just upgraded my kernel to 3.10.3, and dib8000 scanning does not
work anymore.

I tested using dvbscan (from dvb-apps/util/) and w_scan on a Prolink
Pixelview SBTVD (dib8000 module*).This tools worked very well on
version 3.9.9 , but now it does not produces any result, and also
there are no error messages in the logs (dmesg).

Can you please point me out to what is wrong in my kernel, or tell me
which tool did you used to test dvb scanning on this kernel version ?

Thanks and regards...


*: 9.863433] dvb-usb: Prolink Pixelview SBTVD successfully initialized
and connected.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fwd: dib8000 scanning not working on 3.10.3
  2013-07-31 18:47 ` Fwd: dib8000 scanning not working on 3.10.3 Luis Polasek
@ 2013-08-01 16:36   ` Ezequiel Garcia
  2013-08-01 17:15     ` Mauro Carvalho Chehab
  2013-12-10 18:38   ` Fwd: " Ezequiel Garcia
  1 sibling, 1 reply; 13+ messages in thread
From: Ezequiel Garcia @ 2013-08-01 16:36 UTC (permalink / raw)
  To: Luis Polasek; +Cc: linux-media, jbucar, Mauro Carvalho Chehab

Hi Luis,

(I'm Ccing Mauro, who mantains this driver and might know what's going on).

On Wed, Jul 31, 2013 at 03:47:10PM -0300, Luis Polasek wrote:
> Hi, I just upgraded my kernel to 3.10.3, and dib8000 scanning does not
> work anymore.
> 
> I tested using dvbscan (from dvb-apps/util/) and w_scan on a Prolink
> Pixelview SBTVD (dib8000 module*).This tools worked very well on
> version 3.9.9 , but now it does not produces any result, and also
> there are no error messages in the logs (dmesg).
> 

Please run a git bisect and report your findings.

Note that dibcom8000 shows just a handful of commit on 2013,
so you could start reverting those and see what happens.

-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: dib8000 scanning not working on 3.10.3
  2013-08-01 16:36   ` Ezequiel Garcia
@ 2013-08-01 17:15     ` Mauro Carvalho Chehab
  2013-08-05 19:11       ` Luis Polasek
       [not found]       ` <CAER7dwe9biLNZKtW6xQmD8J0Qmh4dMTi=chpUuQ_Dq5KKxJ5UQ@mail.gmail.com>
  0 siblings, 2 replies; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2013-08-01 17:15 UTC (permalink / raw)
  To: Ezequiel Garcia; +Cc: Luis Polasek, linux-media, jbucar, Mauro Carvalho Chehab

Em Thu, 1 Aug 2013 13:36:25 -0300
Ezequiel Garcia <ezequiel.garcia@free-electrons.com> escreveu:

> Hi Luis,
> 
> (I'm Ccing Mauro, who mantains this driver and might know what's going on).
> 
> On Wed, Jul 31, 2013 at 03:47:10PM -0300, Luis Polasek wrote:
> > Hi, I just upgraded my kernel to 3.10.3, and dib8000 scanning does not
> > work anymore.
> > 
> > I tested using dvbscan (from dvb-apps/util/) and w_scan on a Prolink
> > Pixelview SBTVD (dib8000 module*).This tools worked very well on
> > version 3.9.9 , but now it does not produces any result, and also
> > there are no error messages in the logs (dmesg).
> > 
> 
> Please run a git bisect and report your findings.
> 
> Note that dibcom8000 shows just a handful of commit on 2013,
> so you could start reverting those and see what happens.

Perhaps it is a failure at the DVBv3 emulation.

Did it also break using dvbv5-scan (part of v4l-utils)?

Regards,
Mauro
-- 

Cheers,
Mauro

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: dib8000 scanning not working on 3.10.3
  2013-08-01 17:15     ` Mauro Carvalho Chehab
@ 2013-08-05 19:11       ` Luis Polasek
       [not found]       ` <CAER7dwe9biLNZKtW6xQmD8J0Qmh4dMTi=chpUuQ_Dq5KKxJ5UQ@mail.gmail.com>
  1 sibling, 0 replies; 13+ messages in thread
From: Luis Polasek @ 2013-08-05 19:11 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Ezequiel Garcia, linux-media, jbucar, Mauro Carvalho Chehab

Hi Mauro, I have tested using dvb5-scan, and the results are the same
(no results, and no error logs) :(

 Do you have any clue why it is not working with this kernel version ?

Thanks and regards...

On Thu, Aug 1, 2013 at 2:15 PM, Mauro Carvalho Chehab
<m.chehab@samsung.com> wrote:
> Em Thu, 1 Aug 2013 13:36:25 -0300
> Ezequiel Garcia <ezequiel.garcia@free-electrons.com> escreveu:
>
>> Hi Luis,
>>
>> (I'm Ccing Mauro, who mantains this driver and might know what's going on).
>>
>> On Wed, Jul 31, 2013 at 03:47:10PM -0300, Luis Polasek wrote:
>> > Hi, I just upgraded my kernel to 3.10.3, and dib8000 scanning does not
>> > work anymore.
>> >
>> > I tested using dvbscan (from dvb-apps/util/) and w_scan on a Prolink
>> > Pixelview SBTVD (dib8000 module*).This tools worked very well on
>> > version 3.9.9 , but now it does not produces any result, and also
>> > there are no error messages in the logs (dmesg).
>> >
>>
>> Please run a git bisect and report your findings.
>>
>> Note that dibcom8000 shows just a handful of commit on 2013,
>> so you could start reverting those and see what happens.
>
> Perhaps it is a failure at the DVBv3 emulation.
>
> Did it also break using dvbv5-scan (part of v4l-utils)?
>
> Regards,
> Mauro
> --
>
> Cheers,
> Mauro

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: dib8000 scanning not working on 3.10.3
       [not found]       ` <CAER7dwe9biLNZKtW6xQmD8J0Qmh4dMTi=chpUuQ_Dq5KKxJ5UQ@mail.gmail.com>
@ 2013-08-05 20:26         ` Mauro Carvalho Chehab
  2013-08-07 18:48           ` Luis Polasek
  0 siblings, 1 reply; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2013-08-05 20:26 UTC (permalink / raw)
  To: Luis Polasek
  Cc: Ezequiel Garcia, linux-media, jbucar, Mauro Carvalho Chehab,
	Olivier GRENIE, Patrick BOETTCHER

Em Mon, 05 Aug 2013 16:09:56 -0300
Luis Polasek <lpolasek@gmail.com> escreveu:

> Hi Mauro, I have tested using dvb5-scan, and the results are the same (no
> results, and no error logs) :(
> 
>  Do you have any clue why it is not working with this kernel version ?

c/c Oliver and Patrick, who maintains this driver

There were a recent change on this driver, in order to support some newer
versions of this chipset. Perhaps those changes broke it for you.

commit 59501bb792c66b85fb7fdbd740e788e3afc70bbd
Author: Olivier Grenie <olivier.grenie@parrot.com>
Date:   Mon Dec 31 09:51:17 2012 -0300

    [media] dib7090p: improve the support of the dib7090 and dib7790
    
    The intend of this patch is to improve the support of the dib7090 and
    dib7790. The AGC1 min value is set to 32768 by default. The actual AGC1 min
    and the external attenuation are controled depending on the received RF
    level.
    
    Signed-off-by: Olivier Grenie <olivier.grenie@parrot.com>
    Signed-off-by: Patrick Boettcher <patrick.boettcher@parrot.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

commit f45f513a9325b52a5f3e26ee8d15471e8b692947
Author: Olivier Grenie <olivier.grenie@parrot.com>
Date:   Mon Dec 31 09:47:10 2012 -0300

    [media] dib7090p: remove the support for the dib7090E
    
    The intend of this patch is to remove the support for the dib7090E. The
    DiB7090E-package has never left prototype state and never made it to
    mass-prod-state.
    
    Signed-off-by: Olivier Grenie <olivier.grenie@parrot.com>
    Signed-off-by: Patrick Boettcher <patrick.boettcher@parrot.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Could you please revert those patches and see if they fix the issue?
Please try to revert this one first:
	http://git.linuxtv.org/media_tree.git/commitdiff_plain/59501bb792c66b85fb7fdbd740e788e3afc70bbd

If this doesn't solve, try to revert just this one:
	http://git.linuxtv.org/media_tree.git/commitdiff_plain/f45f513a9325b52a5f3e26ee8d15471e8b692947

then, try to revert both.

AFAIKT, those are the only changes that may be affecting isdb-t on dib8000
driver.

Thanks!
Mauro

> 
> Thanks and regards...
> 
> 
> On Thu, Aug 1, 2013 at 2:15 PM, Mauro Carvalho Chehab
> <m.chehab@samsung.com>wrote:
> 
> > Em Thu, 1 Aug 2013 13:36:25 -0300
> > Ezequiel Garcia <ezequiel.garcia@free-electrons.com> escreveu:
> >
> > > Hi Luis,
> > >
> > > (I'm Ccing Mauro, who mantains this driver and might know what's going
> > on).
> > >
> > > On Wed, Jul 31, 2013 at 03:47:10PM -0300, Luis Polasek wrote:
> > > > Hi, I just upgraded my kernel to 3.10.3, and dib8000 scanning does not
> > > > work anymore.
> > > >
> > > > I tested using dvbscan (from dvb-apps/util/) and w_scan on a Prolink
> > > > Pixelview SBTVD (dib8000 module*).This tools worked very well on
> > > > version 3.9.9 , but now it does not produces any result, and also
> > > > there are no error messages in the logs (dmesg).
> > > >
> > >
> > > Please run a git bisect and report your findings.
> > >
> > > Note that dibcom8000 shows just a handful of commit on 2013,
> > > so you could start reverting those and see what happens.
> >
> > Perhaps it is a failure at the DVBv3 emulation.
> >
> > Did it also break using dvbv5-scan (part of v4l-utils)?
> >
> > Regards,
> > Mauro
> > --
> >
> > Cheers,
> > Mauro
> >


-- 

Cheers,
Mauro

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: dib8000 scanning not working on 3.10.3
  2013-08-05 20:26         ` Mauro Carvalho Chehab
@ 2013-08-07 18:48           ` Luis Polasek
  2013-08-12 17:59             ` Ezequiel Garcia
  2013-08-22 17:47             ` Javier Búcar
  0 siblings, 2 replies; 13+ messages in thread
From: Luis Polasek @ 2013-08-07 18:48 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Ezequiel Garcia, linux-media, jbucar, Mauro Carvalho Chehab,
	Olivier GRENIE, Patrick BOETTCHER

Hi again Mauro, reverting both commits:

*  59501bb792c66b85fb7fdbd740e788e3afc70bbd
*  f45f513a9325b52a5f3e26ee8d15471e8b692947

The problem still exists, I am unable to get any result, and also no
error logs) :(

What shall I do to try to fix this ? Do you need more info on my current setup.

Thanks in advance and best regards...

On Mon, Aug 5, 2013 at 5:26 PM, Mauro Carvalho Chehab
<m.chehab@samsung.com> wrote:
> Em Mon, 05 Aug 2013 16:09:56 -0300
> Luis Polasek <lpolasek@gmail.com> escreveu:
>
>> Hi Mauro, I have tested using dvb5-scan, and the results are the same (no
>> results, and no error logs) :(
>>
>>  Do you have any clue why it is not working with this kernel version ?
>
> c/c Oliver and Patrick, who maintains this driver
>
> There were a recent change on this driver, in order to support some newer
> versions of this chipset. Perhaps those changes broke it for you.
>
> commit 59501bb792c66b85fb7fdbd740e788e3afc70bbd
> Author: Olivier Grenie <olivier.grenie@parrot.com>
> Date:   Mon Dec 31 09:51:17 2012 -0300
>
>     [media] dib7090p: improve the support of the dib7090 and dib7790
>
>     The intend of this patch is to improve the support of the dib7090 and
>     dib7790. The AGC1 min value is set to 32768 by default. The actual AGC1 min
>     and the external attenuation are controled depending on the received RF
>     level.
>
>     Signed-off-by: Olivier Grenie <olivier.grenie@parrot.com>
>     Signed-off-by: Patrick Boettcher <patrick.boettcher@parrot.com>
>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> commit f45f513a9325b52a5f3e26ee8d15471e8b692947
> Author: Olivier Grenie <olivier.grenie@parrot.com>
> Date:   Mon Dec 31 09:47:10 2012 -0300
>
>     [media] dib7090p: remove the support for the dib7090E
>
>     The intend of this patch is to remove the support for the dib7090E. The
>     DiB7090E-package has never left prototype state and never made it to
>     mass-prod-state.
>
>     Signed-off-by: Olivier Grenie <olivier.grenie@parrot.com>
>     Signed-off-by: Patrick Boettcher <patrick.boettcher@parrot.com>
>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> Could you please revert those patches and see if they fix the issue?
> Please try to revert this one first:
>         http://git.linuxtv.org/media_tree.git/commitdiff_plain/59501bb792c66b85fb7fdbd740e788e3afc70bbd
>
> If this doesn't solve, try to revert just this one:
>         http://git.linuxtv.org/media_tree.git/commitdiff_plain/f45f513a9325b52a5f3e26ee8d15471e8b692947
>
> then, try to revert both.
>
> AFAIKT, those are the only changes that may be affecting isdb-t on dib8000
> driver.
>
> Thanks!
> Mauro
>
>>
>> Thanks and regards...
>>
>>
>> On Thu, Aug 1, 2013 at 2:15 PM, Mauro Carvalho Chehab
>> <m.chehab@samsung.com>wrote:
>>
>> > Em Thu, 1 Aug 2013 13:36:25 -0300
>> > Ezequiel Garcia <ezequiel.garcia@free-electrons.com> escreveu:
>> >
>> > > Hi Luis,
>> > >
>> > > (I'm Ccing Mauro, who mantains this driver and might know what's going
>> > on).
>> > >
>> > > On Wed, Jul 31, 2013 at 03:47:10PM -0300, Luis Polasek wrote:
>> > > > Hi, I just upgraded my kernel to 3.10.3, and dib8000 scanning does not
>> > > > work anymore.
>> > > >
>> > > > I tested using dvbscan (from dvb-apps/util/) and w_scan on a Prolink
>> > > > Pixelview SBTVD (dib8000 module*).This tools worked very well on
>> > > > version 3.9.9 , but now it does not produces any result, and also
>> > > > there are no error messages in the logs (dmesg).
>> > > >
>> > >
>> > > Please run a git bisect and report your findings.
>> > >
>> > > Note that dibcom8000 shows just a handful of commit on 2013,
>> > > so you could start reverting those and see what happens.
>> >
>> > Perhaps it is a failure at the DVBv3 emulation.
>> >
>> > Did it also break using dvbv5-scan (part of v4l-utils)?
>> >
>> > Regards,
>> > Mauro
>> > --
>> >
>> > Cheers,
>> > Mauro
>> >
>
>
> --
>
> Cheers,
> Mauro

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: dib8000 scanning not working on 3.10.3
  2013-08-07 18:48           ` Luis Polasek
@ 2013-08-12 17:59             ` Ezequiel Garcia
  2013-08-22 17:47             ` Javier Búcar
  1 sibling, 0 replies; 13+ messages in thread
From: Ezequiel Garcia @ 2013-08-12 17:59 UTC (permalink / raw)
  To: Luis Polasek
  Cc: Mauro Carvalho Chehab, linux-media, jbucar,
	Mauro Carvalho Chehab, Olivier GRENIE, Patrick BOETTCHER

Hey Luis,

On Wed, Aug 07, 2013 at 03:48:33PM -0300, Luis Polasek wrote:
> Hi again Mauro, reverting both commits:
> 
> *  59501bb792c66b85fb7fdbd740e788e3afc70bbd
> *  f45f513a9325b52a5f3e26ee8d15471e8b692947
> 
> The problem still exists, I am unable to get any result, and also no
> error logs) :(
> 
> What shall I do to try to fix this ? Do you need more info on my current setup.
> 

Have you tried a git bisect? It's a PITA, but it's a safe
way to find the guilty commit.

Don't hesitate in asking for help if you're not sure how this is done.

PS: Try to avoid top-posting.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: dib8000 scanning not working on 3.10.3
  2013-08-07 18:48           ` Luis Polasek
  2013-08-12 17:59             ` Ezequiel Garcia
@ 2013-08-22 17:47             ` Javier Búcar
  2013-08-22 18:06               ` Ezequiel Garcia
  2013-08-22 18:23               ` Mauro Carvalho Chehab
  1 sibling, 2 replies; 13+ messages in thread
From: Javier Búcar @ 2013-08-22 17:47 UTC (permalink / raw)
  To: Luis Polasek
  Cc: Mauro Carvalho Chehab, Ezequiel Garcia, linux-media,
	Mauro Carvalho Chehab, Olivier GRENIE, Patrick BOETTCHER

Hello Mauro, we have the bad commit:

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=173a64cb3fcff1993b2aa8113e53fd379f6a968f

This is a very big commit. I don't known where to fix it. Can you help
me on fixing it
Thanks in advance
Javier

On Wed, Aug 7, 2013 at 3:48 PM, Luis Polasek <lpolasek@gmail.com> wrote:
> Hi again Mauro, reverting both commits:
>
> *  59501bb792c66b85fb7fdbd740e788e3afc70bbd
> *  f45f513a9325b52a5f3e26ee8d15471e8b692947
>
> The problem still exists, I am unable to get any result, and also no
> error logs) :(
>
> What shall I do to try to fix this ? Do you need more info on my current setup.
>
> Thanks in advance and best regards...
>
> On Mon, Aug 5, 2013 at 5:26 PM, Mauro Carvalho Chehab
> <m.chehab@samsung.com> wrote:
>> Em Mon, 05 Aug 2013 16:09:56 -0300
>> Luis Polasek <lpolasek@gmail.com> escreveu:
>>
>>> Hi Mauro, I have tested using dvb5-scan, and the results are the same (no
>>> results, and no error logs) :(
>>>
>>>  Do you have any clue why it is not working with this kernel version ?
>>
>> c/c Oliver and Patrick, who maintains this driver
>>
>> There were a recent change on this driver, in order to support some newer
>> versions of this chipset. Perhaps those changes broke it for you.
>>
>> commit 59501bb792c66b85fb7fdbd740e788e3afc70bbd
>> Author: Olivier Grenie <olivier.grenie@parrot.com>
>> Date:   Mon Dec 31 09:51:17 2012 -0300
>>
>>     [media] dib7090p: improve the support of the dib7090 and dib7790
>>
>>     The intend of this patch is to improve the support of the dib7090 and
>>     dib7790. The AGC1 min value is set to 32768 by default. The actual AGC1 min
>>     and the external attenuation are controled depending on the received RF
>>     level.
>>
>>     Signed-off-by: Olivier Grenie <olivier.grenie@parrot.com>
>>     Signed-off-by: Patrick Boettcher <patrick.boettcher@parrot.com>
>>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>>
>> commit f45f513a9325b52a5f3e26ee8d15471e8b692947
>> Author: Olivier Grenie <olivier.grenie@parrot.com>
>> Date:   Mon Dec 31 09:47:10 2012 -0300
>>
>>     [media] dib7090p: remove the support for the dib7090E
>>
>>     The intend of this patch is to remove the support for the dib7090E. The
>>     DiB7090E-package has never left prototype state and never made it to
>>     mass-prod-state.
>>
>>     Signed-off-by: Olivier Grenie <olivier.grenie@parrot.com>
>>     Signed-off-by: Patrick Boettcher <patrick.boettcher@parrot.com>
>>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>>
>> Could you please revert those patches and see if they fix the issue?
>> Please try to revert this one first:
>>         http://git.linuxtv.org/media_tree.git/commitdiff_plain/59501bb792c66b85fb7fdbd740e788e3afc70bbd
>>
>> If this doesn't solve, try to revert just this one:
>>         http://git.linuxtv.org/media_tree.git/commitdiff_plain/f45f513a9325b52a5f3e26ee8d15471e8b692947
>>
>> then, try to revert both.
>>
>> AFAIKT, those are the only changes that may be affecting isdb-t on dib8000
>> driver.
>>
>> Thanks!
>> Mauro
>>
>>>
>>> Thanks and regards...
>>>
>>>
>>> On Thu, Aug 1, 2013 at 2:15 PM, Mauro Carvalho Chehab
>>> <m.chehab@samsung.com>wrote:
>>>
>>> > Em Thu, 1 Aug 2013 13:36:25 -0300
>>> > Ezequiel Garcia <ezequiel.garcia@free-electrons.com> escreveu:
>>> >
>>> > > Hi Luis,
>>> > >
>>> > > (I'm Ccing Mauro, who mantains this driver and might know what's going
>>> > on).
>>> > >
>>> > > On Wed, Jul 31, 2013 at 03:47:10PM -0300, Luis Polasek wrote:
>>> > > > Hi, I just upgraded my kernel to 3.10.3, and dib8000 scanning does not
>>> > > > work anymore.
>>> > > >
>>> > > > I tested using dvbscan (from dvb-apps/util/) and w_scan on a Prolink
>>> > > > Pixelview SBTVD (dib8000 module*).This tools worked very well on
>>> > > > version 3.9.9 , but now it does not produces any result, and also
>>> > > > there are no error messages in the logs (dmesg).
>>> > > >
>>> > >
>>> > > Please run a git bisect and report your findings.
>>> > >
>>> > > Note that dibcom8000 shows just a handful of commit on 2013,
>>> > > so you could start reverting those and see what happens.
>>> >
>>> > Perhaps it is a failure at the DVBv3 emulation.
>>> >
>>> > Did it also break using dvbv5-scan (part of v4l-utils)?
>>> >
>>> > Regards,
>>> > Mauro
>>> > --
>>> >
>>> > Cheers,
>>> > Mauro
>>> >
>>
>>
>> --
>>
>> Cheers,
>> Mauro

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: dib8000 scanning not working on 3.10.3
  2013-08-22 17:47             ` Javier Búcar
@ 2013-08-22 18:06               ` Ezequiel Garcia
  2013-08-22 18:23               ` Mauro Carvalho Chehab
  1 sibling, 0 replies; 13+ messages in thread
From: Ezequiel Garcia @ 2013-08-22 18:06 UTC (permalink / raw)
  To: Javier Búcar
  Cc: Luis Polasek, Mauro Carvalho Chehab, linux-media,
	Mauro Carvalho Chehab, Olivier GRENIE, Patrick BOETTCHER

Mauro, Javier,

On Thu, Aug 22, 2013 at 02:47:33PM -0300, Javier Búcar wrote:
> 
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=173a64cb3fcff1993b2aa8113e53fd379f6a968f
> 
> This is a very big commit. I don't known where to fix it. Can you help

That's not a commit: that's a monster :-(

That should have been heavily splitted. Now a user (Javier and Luis)
is allegedly reporting a regression, but that commit is almost
impossible to understand, and probably very difficult to revert.

I hate to get grumpy, but this does not look nice!
Even the commit log sucks: what does ""dib8000: enhancement"" suppose to mean?

Javier/Luis: (for the second time) please try to avoid top-posting
in the future, it breaks the thread discussion.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: dib8000 scanning not working on 3.10.3
  2013-08-22 17:47             ` Javier Búcar
  2013-08-22 18:06               ` Ezequiel Garcia
@ 2013-08-22 18:23               ` Mauro Carvalho Chehab
  2013-08-26 13:48                 ` Luis Polasek
  1 sibling, 1 reply; 13+ messages in thread
From: Mauro Carvalho Chehab @ 2013-08-22 18:23 UTC (permalink / raw)
  To: Javier Búcar
  Cc: Luis Polasek, Ezequiel Garcia, linux-media,
	Mauro Carvalho Chehab, Olivier GRENIE, Patrick BOETTCHER

Em Thu, 22 Aug 2013 14:47:33 -0300
Javier Búcar <jbucar@lifia.info.unlp.edu.ar> escreveu:

> Hello Mauro, we have the bad commit:
> 
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=173a64cb3fcff1993b2aa8113e53fd379f6a968f
> 
> This is a very big commit. I don't known where to fix it. Can you help
> me on fixing it

Hmm.... So, the error is on this patch?

	author	Patrick Boettcher <pboettcher@kernellabs.com>	2013-04-22 15:45:52 (GMT)
	[media] dib8000: enhancement

	The intend of this patch is to improve the support of the dib8000. 

	Signed-off-by: Olivier Grenie <olivier.grenie@parrot.com> 
	Signed-off-by: Patrick Boettcher <patrick.boettcher@parrot.com> 
	Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> 

If so, then we need either Olivier or Patrick's help, as I don't have any
documentation about the dib8000 chips.

You can still take a look there at the code that checks for the
chipset version, like:
	if (state->revision == 0x8090) {
		<some code for newer version>
	} else {
		<some code for the old version>
	}

If the code for the old version remains the same as before the patch.
Where it doesn't remains the same, then it could be the source of the
troubles.

I suggest you to check what state->revision shows on your specific device,
in order to do such analysis.

I'll try latter to do some tests with the devices I have, but this could
take some time, as I'm really busy those days.

Regards,
Mauro


> Thanks in advance
> Javier
> 
> On Wed, Aug 7, 2013 at 3:48 PM, Luis Polasek <lpolasek@gmail.com> wrote:
> > Hi again Mauro, reverting both commits:
> >
> > *  59501bb792c66b85fb7fdbd740e788e3afc70bbd
> > *  f45f513a9325b52a5f3e26ee8d15471e8b692947
> >
> > The problem still exists, I am unable to get any result, and also no
> > error logs) :(
> >
> > What shall I do to try to fix this ? Do you need more info on my current setup.
> >
> > Thanks in advance and best regards...
> >
> > On Mon, Aug 5, 2013 at 5:26 PM, Mauro Carvalho Chehab
> > <m.chehab@samsung.com> wrote:
> >> Em Mon, 05 Aug 2013 16:09:56 -0300
> >> Luis Polasek <lpolasek@gmail.com> escreveu:
> >>
> >>> Hi Mauro, I have tested using dvb5-scan, and the results are the same (no
> >>> results, and no error logs) :(
> >>>
> >>>  Do you have any clue why it is not working with this kernel version ?
> >>
> >> c/c Oliver and Patrick, who maintains this driver
> >>
> >> There were a recent change on this driver, in order to support some newer
> >> versions of this chipset. Perhaps those changes broke it for you.
> >>
> >> commit 59501bb792c66b85fb7fdbd740e788e3afc70bbd
> >> Author: Olivier Grenie <olivier.grenie@parrot.com>
> >> Date:   Mon Dec 31 09:51:17 2012 -0300
> >>
> >>     [media] dib7090p: improve the support of the dib7090 and dib7790
> >>
> >>     The intend of this patch is to improve the support of the dib7090 and
> >>     dib7790. The AGC1 min value is set to 32768 by default. The actual AGC1 min
> >>     and the external attenuation are controled depending on the received RF
> >>     level.
> >>
> >>     Signed-off-by: Olivier Grenie <olivier.grenie@parrot.com>
> >>     Signed-off-by: Patrick Boettcher <patrick.boettcher@parrot.com>
> >>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> >>
> >> commit f45f513a9325b52a5f3e26ee8d15471e8b692947
> >> Author: Olivier Grenie <olivier.grenie@parrot.com>
> >> Date:   Mon Dec 31 09:47:10 2012 -0300
> >>
> >>     [media] dib7090p: remove the support for the dib7090E
> >>
> >>     The intend of this patch is to remove the support for the dib7090E. The
> >>     DiB7090E-package has never left prototype state and never made it to
> >>     mass-prod-state.
> >>
> >>     Signed-off-by: Olivier Grenie <olivier.grenie@parrot.com>
> >>     Signed-off-by: Patrick Boettcher <patrick.boettcher@parrot.com>
> >>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> >>
> >> Could you please revert those patches and see if they fix the issue?
> >> Please try to revert this one first:
> >>         http://git.linuxtv.org/media_tree.git/commitdiff_plain/59501bb792c66b85fb7fdbd740e788e3afc70bbd
> >>
> >> If this doesn't solve, try to revert just this one:
> >>         http://git.linuxtv.org/media_tree.git/commitdiff_plain/f45f513a9325b52a5f3e26ee8d15471e8b692947
> >>
> >> then, try to revert both.
> >>
> >> AFAIKT, those are the only changes that may be affecting isdb-t on dib8000
> >> driver.
> >>
> >> Thanks!
> >> Mauro
> >>
> >>>
> >>> Thanks and regards...
> >>>
> >>>
> >>> On Thu, Aug 1, 2013 at 2:15 PM, Mauro Carvalho Chehab
> >>> <m.chehab@samsung.com>wrote:
> >>>
> >>> > Em Thu, 1 Aug 2013 13:36:25 -0300
> >>> > Ezequiel Garcia <ezequiel.garcia@free-electrons.com> escreveu:
> >>> >
> >>> > > Hi Luis,
> >>> > >
> >>> > > (I'm Ccing Mauro, who mantains this driver and might know what's going
> >>> > on).
> >>> > >
> >>> > > On Wed, Jul 31, 2013 at 03:47:10PM -0300, Luis Polasek wrote:
> >>> > > > Hi, I just upgraded my kernel to 3.10.3, and dib8000 scanning does not
> >>> > > > work anymore.
> >>> > > >
> >>> > > > I tested using dvbscan (from dvb-apps/util/) and w_scan on a Prolink
> >>> > > > Pixelview SBTVD (dib8000 module*).This tools worked very well on
> >>> > > > version 3.9.9 , but now it does not produces any result, and also
> >>> > > > there are no error messages in the logs (dmesg).
> >>> > > >
> >>> > >
> >>> > > Please run a git bisect and report your findings.
> >>> > >
> >>> > > Note that dibcom8000 shows just a handful of commit on 2013,
> >>> > > so you could start reverting those and see what happens.
> >>> >
> >>> > Perhaps it is a failure at the DVBv3 emulation.
> >>> >
> >>> > Did it also break using dvbv5-scan (part of v4l-utils)?
> >>> >
> >>> > Regards,
> >>> > Mauro
> >>> > --
> >>> >
> >>> > Cheers,
> >>> > Mauro
> >>> >
> >>
> >>
> >> --
> >>
> >> Cheers,
> >> Mauro


-- 

Cheers,
Mauro

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: dib8000 scanning not working on 3.10.3
  2013-08-22 18:23               ` Mauro Carvalho Chehab
@ 2013-08-26 13:48                 ` Luis Polasek
  0 siblings, 0 replies; 13+ messages in thread
From: Luis Polasek @ 2013-08-26 13:48 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Javier Búcar, Ezequiel Garcia, linux-media,
	Mauro Carvalho Chehab, Olivier GRENIE, Patrick BOETTCHER

On Thu, Aug 22, 2013 at 3:23 PM, Mauro Carvalho Chehab
<m.chehab@samsung.com> wrote:
> Em Thu, 22 Aug 2013 14:47:33 -0300
> Javier Búcar <jbucar@lifia.info.unlp.edu.ar> escreveu:
>
>> Hello Mauro, we have the bad commit:
>>
>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=173a64cb3fcff1993b2aa8113e53fd379f6a968f
>>
>> This is a very big commit. I don't known where to fix it. Can you help
>> me on fixing it
>
> Hmm.... So, the error is on this patch?
>
>         author  Patrick Boettcher <pboettcher@kernellabs.com>   2013-04-22 15:45:52 (GMT)
>         [media] dib8000: enhancement
>
>         The intend of this patch is to improve the support of the dib8000.
>
>         Signed-off-by: Olivier Grenie <olivier.grenie@parrot.com>
>         Signed-off-by: Patrick Boettcher <patrick.boettcher@parrot.com>
>         Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> If so, then we need either Olivier or Patrick's help, as I don't have any
> documentation about the dib8000 chips.
>
> You can still take a look there at the code that checks for the
> chipset version, like:
>         if (state->revision == 0x8090) {
>                 <some code for newer version>
>         } else {
>                 <some code for the old version>
>         }
>
> If the code for the old version remains the same as before the patch.
> Where it doesn't remains the same, then it could be the source of the
> troubles.
>
> I suggest you to check what state->revision shows on your specific device,
> in order to do such analysis.
>
> I'll try latter to do some tests with the devices I have, but this could
> take some time, as I'm really busy those days.

The PixelView DiB8000B revision is:
   Vendor ID: 0x1b3
   Product ID: 0x8001

Thanks and regards...

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fwd: dib8000 scanning not working on 3.10.3
  2013-07-31 18:47 ` Fwd: dib8000 scanning not working on 3.10.3 Luis Polasek
  2013-08-01 16:36   ` Ezequiel Garcia
@ 2013-12-10 18:38   ` Ezequiel Garcia
       [not found]     ` <CAJmEX9Cxrm=8FdDAWngNA=v1j8idqcMYtNcNxByGKUNdMk95JA@mail.gmail.com>
  1 sibling, 1 reply; 13+ messages in thread
From: Ezequiel Garcia @ 2013-12-10 18:38 UTC (permalink / raw)
  To: Luis Polasek; +Cc: linux-media, jbucar

Hi Luis,

On Wed, Jul 31, 2013 at 03:47:10PM -0300, Luis Polasek wrote:
> Hi, I just upgraded my kernel to 3.10.3, and dib8000 scanning does not
> work anymore.
> 

I'm just wondering, is this issue still present in mainline kernel?
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: Fwd: dib8000 scanning not working on 3.10.3
       [not found]     ` <CAJmEX9Cxrm=8FdDAWngNA=v1j8idqcMYtNcNxByGKUNdMk95JA@mail.gmail.com>
@ 2013-12-11 13:27       ` Ezequiel Garcia
  0 siblings, 0 replies; 13+ messages in thread
From: Ezequiel Garcia @ 2013-12-11 13:27 UTC (permalink / raw)
  To: Javier Búcar; +Cc: Luis Polasek, linux-media

Hi Javier,

On Tue, Dec 10, 2013 at 04:46:16PM -0200, Javier Búcar wrote:
> 
> The issue remain on kernel 3.12.3

I'll try to push a fixed kernel (with some patches reverted), so you can
try.

Will you be able to try a mainline-like kernel? I'll push a git branch,
so it'll be something like this:

  git://git.free-electrons.com/users/ezequiel-garcia/linux/

It won't happen anytime soon, but I'll try to do it before the end of
the year.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2013-12-11 13:27 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAER7dwe+kkVoDbRt9Xj8+77tJnL29bxRzHbSPYOrck_HxVsENw@mail.gmail.com>
2013-07-31 18:47 ` Fwd: dib8000 scanning not working on 3.10.3 Luis Polasek
2013-08-01 16:36   ` Ezequiel Garcia
2013-08-01 17:15     ` Mauro Carvalho Chehab
2013-08-05 19:11       ` Luis Polasek
     [not found]       ` <CAER7dwe9biLNZKtW6xQmD8J0Qmh4dMTi=chpUuQ_Dq5KKxJ5UQ@mail.gmail.com>
2013-08-05 20:26         ` Mauro Carvalho Chehab
2013-08-07 18:48           ` Luis Polasek
2013-08-12 17:59             ` Ezequiel Garcia
2013-08-22 17:47             ` Javier Búcar
2013-08-22 18:06               ` Ezequiel Garcia
2013-08-22 18:23               ` Mauro Carvalho Chehab
2013-08-26 13:48                 ` Luis Polasek
2013-12-10 18:38   ` Fwd: " Ezequiel Garcia
     [not found]     ` <CAJmEX9Cxrm=8FdDAWngNA=v1j8idqcMYtNcNxByGKUNdMk95JA@mail.gmail.com>
2013-12-11 13:27       ` Ezequiel Garcia

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.