From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> To: Thierry Reding <thierry.reding@gmail.com> Cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org, Grant Likely <grant.likely@secretlab.ca>, Rob Herring <rob.herring@calxeda.com>, Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Gregory Clement <gregory.clement@free-electrons.com>, Ezequiel Garcia <ezequiel.garcia@free-electrons.com>, linux-arm-kernel@lists.infradead.org, Maen Suleiman <maen@marvell.com>, Lior Amsalem <alior@marvell.com> Subject: Re: [PATCHv5 08/11] ARM: pci: add ->add_bus() and ->remove_bus() hooks to hw_pci Date: Wed, 7 Aug 2013 11:13:54 +0200 [thread overview] Message-ID: <20130807111354.5e29a74c@skate> (raw) In-Reply-To: <20130725165302.GA27802@dhcp-172-17-186-34.nvidia.com> Dear Thierry Reding, On Thu, 25 Jul 2013 09:53:03 -0700, Thierry Reding wrote: > I just noticed two minor issues, see below. > > > diff --git a/arch/arm/include/asm/mach/pci.h b/arch/arm/include/asm/mach/pci.h > [...] > > @@ -36,6 +36,8 @@ struct hw_pci { > > resource_size_t start, > > resource_size_t size, > > resource_size_t align); > > + void (*add_bus)(struct pci_bus *bus); > > + void (*remove_bus)(struct pci_bus *bus); > > This hunk... > > > @@ -63,6 +65,8 @@ struct pci_sys_data { > > resource_size_t start, > > resource_size_t size, > > resource_size_t align); > > + void (*add_bus)(struct pci_bus *bus); > > + void (*remove_bus)(struct pci_bus *bus); > > void *private_data; /* platform controller private data */ > > }; > > and this one use inconsistent indentation (spaces instead of tabs). Hum, I must be missing something here. Looking at the patch you're quoting, and my code, I see one tab before 'void' in both cases, and spaces between 'void' and the (*function) in both cases. Am I missing something here? > > diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c > [...] > > @@ -464,6 +478,8 @@ static void pcibios_init_hw(struct device *parent, struct hw_pci *hw, > > sys->swizzle = hw->swizzle; > > sys->map_irq = hw->map_irq; > > sys->align_resource = hw->align_resource; > > + sys->add_bus = hw->add_bus; > > + sys->remove_bus = hw->remove_bus; > > And this one aligns the '=' sign, whereas none of the other assignments > do. Right, will be fixed as part of PATCHv7. Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv5 08/11] ARM: pci: add ->add_bus() and ->remove_bus() hooks to hw_pci Date: Wed, 7 Aug 2013 11:13:54 +0200 [thread overview] Message-ID: <20130807111354.5e29a74c@skate> (raw) In-Reply-To: <20130725165302.GA27802@dhcp-172-17-186-34.nvidia.com> Dear Thierry Reding, On Thu, 25 Jul 2013 09:53:03 -0700, Thierry Reding wrote: > I just noticed two minor issues, see below. > > > diff --git a/arch/arm/include/asm/mach/pci.h b/arch/arm/include/asm/mach/pci.h > [...] > > @@ -36,6 +36,8 @@ struct hw_pci { > > resource_size_t start, > > resource_size_t size, > > resource_size_t align); > > + void (*add_bus)(struct pci_bus *bus); > > + void (*remove_bus)(struct pci_bus *bus); > > This hunk... > > > @@ -63,6 +65,8 @@ struct pci_sys_data { > > resource_size_t start, > > resource_size_t size, > > resource_size_t align); > > + void (*add_bus)(struct pci_bus *bus); > > + void (*remove_bus)(struct pci_bus *bus); > > void *private_data; /* platform controller private data */ > > }; > > and this one use inconsistent indentation (spaces instead of tabs). Hum, I must be missing something here. Looking at the patch you're quoting, and my code, I see one tab before 'void' in both cases, and spaces between 'void' and the (*function) in both cases. Am I missing something here? > > diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c > [...] > > @@ -464,6 +478,8 @@ static void pcibios_init_hw(struct device *parent, struct hw_pci *hw, > > sys->swizzle = hw->swizzle; > > sys->map_irq = hw->map_irq; > > sys->align_resource = hw->align_resource; > > + sys->add_bus = hw->add_bus; > > + sys->remove_bus = hw->remove_bus; > > And this one aligns the '=' sign, whereas none of the other assignments > do. Right, will be fixed as part of PATCHv7. Thanks, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
next prev parent reply other threads:[~2013-08-07 9:15 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-15 11:52 [PATCHv5 00/11] MSI support for Marvell EBU PCIe driver Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 11:52 ` [PATCHv5 01/11] irqdomain: add irq_alloc_mapping() function Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-16 8:31 ` Thomas Petazzoni 2013-07-16 8:31 ` Thomas Petazzoni 2013-07-28 4:11 ` Grant Likely 2013-07-28 4:11 ` Grant Likely 2013-07-15 11:52 ` [PATCHv5 02/11] PCI: use weak functions for MSI arch-specific functions Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-25 18:37 ` Thierry Reding 2013-07-25 18:37 ` Thierry Reding 2013-07-25 18:37 ` Thierry Reding 2013-07-25 20:27 ` Bjorn Helgaas 2013-07-25 20:27 ` Bjorn Helgaas 2013-07-25 20:27 ` Bjorn Helgaas 2013-07-15 11:52 ` [PATCHv5 03/11] PCI: remove ARCH_SUPPORTS_MSI kconfig option Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 11:52 ` [PATCHv5 04/11] PCI: Introduce new MSI chip infrastructure Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-25 18:40 ` Thierry Reding 2013-07-25 18:40 ` Thierry Reding 2013-07-25 20:26 ` Bjorn Helgaas 2013-07-25 20:26 ` Bjorn Helgaas 2013-07-15 11:52 ` [PATCHv5 05/11] of: pci: add registry of MSI chips Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 16:12 ` Rob Herring 2013-07-15 16:12 ` Rob Herring 2013-07-28 4:33 ` Grant Likely 2013-07-28 4:33 ` Grant Likely 2013-07-28 14:27 ` Thomas Petazzoni 2013-07-28 14:27 ` Thomas Petazzoni 2013-07-29 6:54 ` Thierry Reding 2013-07-29 6:54 ` Thierry Reding 2013-07-29 12:26 ` Thomas Petazzoni 2013-07-29 12:26 ` Thomas Petazzoni 2013-07-29 12:58 ` Thierry Reding 2013-07-29 12:58 ` Thierry Reding 2013-07-29 13:04 ` Thomas Petazzoni 2013-07-29 13:04 ` Thomas Petazzoni 2013-08-01 9:17 ` Thomas Petazzoni 2013-08-01 9:17 ` Thomas Petazzoni 2013-07-31 15:14 ` Thomas Petazzoni 2013-07-31 15:14 ` Thomas Petazzoni 2013-07-15 11:52 ` [PATCHv5 06/11] irqchip: armada-370-xp: properly request resources Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 11:52 ` [PATCHv5 07/11] irqchip: armada-370-xp: implement MSI support Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 11:52 ` [PATCHv5 08/11] ARM: pci: add ->add_bus() and ->remove_bus() hooks to hw_pci Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-16 8:29 ` Thomas Petazzoni 2013-07-16 8:29 ` Thomas Petazzoni 2013-07-25 16:53 ` Thierry Reding 2013-07-25 16:53 ` Thierry Reding 2013-08-07 9:13 ` Thomas Petazzoni [this message] 2013-08-07 9:13 ` Thomas Petazzoni 2013-08-07 13:37 ` Thierry Reding 2013-08-07 13:37 ` Thierry Reding 2013-08-07 15:06 ` Thomas Petazzoni 2013-08-07 15:06 ` Thomas Petazzoni 2013-07-25 16:57 ` Thierry Reding 2013-07-25 16:57 ` Thierry Reding 2013-07-26 8:13 ` Thomas Petazzoni 2013-07-26 8:13 ` Thomas Petazzoni 2013-07-26 11:49 ` Jason Cooper 2013-07-26 11:49 ` Jason Cooper 2013-07-26 22:46 ` Russell King - ARM Linux 2013-07-26 22:46 ` Russell King - ARM Linux 2013-07-29 12:31 ` Thierry Reding 2013-07-29 12:31 ` Thierry Reding 2013-07-15 11:52 ` [PATCHv5 09/11] ARM: mvebu: the MPIC now provides MSI controller features Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 11:52 ` [PATCHv5 10/11] PCI: mvebu: add support for MSI Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 11:52 ` [PATCHv5 11/11] ARM: mvebu: link PCIe controllers to the MSI controller Thomas Petazzoni 2013-07-15 11:52 ` Thomas Petazzoni 2013-07-15 15:34 ` [PATCHv5 00/11] MSI support for Marvell EBU PCIe driver Stephen Warren 2013-07-15 15:34 ` Stephen Warren 2013-07-15 16:27 ` Thierry Reding 2013-07-15 16:27 ` Thierry Reding 2013-07-16 8:33 ` Thomas Petazzoni 2013-07-16 8:33 ` Thomas Petazzoni 2013-07-16 21:05 ` Thierry Reding 2013-07-16 21:05 ` Thierry Reding 2013-07-16 21:43 ` Thomas Petazzoni 2013-07-16 21:43 ` Thomas Petazzoni 2013-07-23 0:30 ` Bjorn Helgaas 2013-07-23 0:30 ` Bjorn Helgaas 2013-07-15 17:33 ` Jason Cooper 2013-07-15 17:33 ` Jason Cooper 2013-07-16 8:43 ` Thomas Petazzoni 2013-07-16 8:43 ` Thomas Petazzoni 2013-07-16 13:15 ` Jason Cooper 2013-07-16 13:15 ` Jason Cooper 2013-07-16 13:39 ` Thomas Petazzoni 2013-07-16 13:39 ` Thomas Petazzoni 2013-07-25 18:49 ` Thierry Reding 2013-07-25 18:49 ` Thierry Reding 2013-07-25 19:02 ` Jason Cooper 2013-07-25 19:02 ` Jason Cooper
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130807111354.5e29a74c@skate \ --to=thomas.petazzoni@free-electrons.com \ --cc=alior@marvell.com \ --cc=andrew@lunn.ch \ --cc=bhelgaas@google.com \ --cc=ezequiel.garcia@free-electrons.com \ --cc=grant.likely@secretlab.ca \ --cc=gregory.clement@free-electrons.com \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pci@vger.kernel.org \ --cc=maen@marvell.com \ --cc=rob.herring@calxeda.com \ --cc=tglx@linutronix.de \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.