Re: [PATCH lttng-ust] Add trace instrumentation for some pthread functions.

[Mathieu Desnoyers <mathieu.desnoyers@efficios.com>]

* Stefan Seefeld (stefan_seefeld@mentor.com) wrote:
> On 08/07/2013 11:52 AM, Mathieu Desnoyers wrote:
> > * Stefan Seefeld (stefan_seefeld@mentor.com) wrote:
> >> Sorry for the incomplete patch. Here is a corrected one.
> >>
> >> 	Stefan
> > You can add my
> >
> > Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> >
> > To you patch changelog.
> >
> > Can you keep it around and resubmit after we release 2.3-final in a few
> > weeks ?
> 
> Why can't this be comitted to a devel branch, if it isn't fit to go into
> master ?

Because master is currently in feature freeze for the 2.3-rc cycle, and
as a maintainer I'm not keeping any devel/staging branch: this
responsibility currently belongs to the contributors. The new features
flow into master between the end of the release candidate cycle (final
version) and the start of the next rc cycle. See the recent discussion
on the release process on lttng-dev for more details. Feedback is
welcome.

> (Also, does this imply that the malloc patch made it into the
> 2.3 release ?)

Yes, the malloc patch made it into the 2.3 release mainly because it's
fixing incomplete coverage of the already existing malloc/free-related
instrumentation.

The difference with pthread instrumentation is that it's really a new
feature in every possible sense of the term: new kind of library
functions are instrumented, new problems may arise, new files are added,
new shared objects are added. This is exactly what we don't want to add
during rc.

Please note that as soon as you get my acked-by, you can consider this
patch accepted. It's just that we don't have the staging branches to
keep them around, nor the manpower to maintain a 3rd branch in parallel
with the current stable+rc.

Thoughts ?

Thanks,

Mathieu

> 
>     Stefan
> 
> 
> -- 
> Stefan Seefeld
> CodeSourcery / Mentor Graphics
> http://www.mentor.com/embedded-software/
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com