Re: [PATCH lttng-ust] Add trace instrumentation for some pthread functions.

From: "Jérémie Galarneau" <jeremie.galarneau@efficios.com>
To: Stefan Seefeld <stefan_seefeld@mentor.com>
Cc: lttng-dev@lists.lttng.org
Subject: Re: [PATCH lttng-ust] Add trace instrumentation for some pthread functions.
Date: Wed, 31 Jul 2013 18:00:14 -0400	[thread overview]
Message-ID: <CA+jJMxsoH8Rz6fwZJOPnG-4xvB2w8GO5eqi0JDtHUy7iM-n2WA__6343.51987760073$1375308085$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <51F97688.30704@mentor.com>

Hi Stefan,

Please inline your patches in the future as it makes the review process simpler.
There are a number of stylistic problems, mostly misplaced braces.

You can run your patches through the checkpatch.pl script found in
lttng-tools/extras. It will spot most coding-style related problems
right away.

Also, I think lttng-ust-pthread-mutex.c may be a more appropriate name
than pthread.c

Thanks,
Jérémie

On Wed, Jul 31, 2013 at 4:41 PM, Stefan Seefeld
<stefan_seefeld@mentor.com> wrote:
> The attached patch introduces a pthread wrapper library with initial
> instrumentation for pthread_mutex_lock, pthread_mutex_trylock, and
> pthread_mutex_unlock.
> New tracepoints are introduced for each of those. For the lock function,
> two distinct tracepoints are emitted: one before the lock is requested,
> another after it has been acquired.
>
> --
> Stefan Seefeld
> CodeSourcery / Mentor Graphics
> http://www.mentor.com/embedded-software/
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>

-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com