All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
	Ike Pan <ike.pan@canonical.com>, Wolfram Sang <wsa@the-dreams.de>,
	Nadav Haklai <nadavh@marvell.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	David Marlin <dmarlin@redhat.com>,
	Yehuda Yitschak <yehuday@marvell.com>,
	Tawfik Bayouk <tawfik@marvell.com>,
	"dann.frazier@canonical.com" <dann.frazier@canonical.com>,
	Eran Ben-Avi <benavi@marvell.com>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	Leif Lindholm <Leif.Lindholm@arm.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Jason Cooper <jason@lakedaemon.net>,
	"jcm@redhat.com" <jcm@redhat.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	"vanhoof@canonical.com" <vanhoof@canonical.com>,
	Piotr Ziecik <kosmo@semihalf.com>,
	Nicolas
Subject: Re: [PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support
Date: Thu, 8 Aug 2013 17:43:23 +0100	[thread overview]
Message-ID: <20130808164323.GD27325@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <5203B97A.8060605@free-electrons.com>

On Thu, Aug 08, 2013 at 04:30:02PM +0100, Gregory CLEMENT wrote:
> On 07/08/2013 17:57, Jason Cooper wrote:
> > On Wed, Aug 07, 2013 at 04:35:46PM +0200, Wolfram Sang wrote:
> >>
> >>> But we shouldn't use it alone: we should always use:
> >>> compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
> >>>
> >>> From my point of view using  "marvell,mv78230-i2c" alone is an error.
> >>>
> >>> Wolfram what is your opinion on it?
> >>
> >> It is not strictly an error, but risky. If you use an older Kernel
> >> version (or other OS) which only offers "mv64xxx" you will have no
> >> match. Although the driver theoretically could have basic support for
> >> all mv64xxx variants skipping all additional features of later IP
> >> revisions.
> > 
> > I agree here.  The driver is advertising what IP blocks it can handle,
> > so it makes sense to add both strings since it can handle both.
> 
> Wolfram,
> so beside remarks about the compatibility strings. I didn't any other
> comment since the v3 which was 7 weeks ago.
> 
> Does it mean that once I will have added the handle of this string,
> you will be able to take the series for the 3.12 kernel?

Please could you also ensure the new string is documented in
Documentation/devicetree, with a brief description of what it implies
about the hardware beyond the exiting "marvell,mv64xxx-i2c" string.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support
Date: Thu, 8 Aug 2013 17:43:23 +0100	[thread overview]
Message-ID: <20130808164323.GD27325@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <5203B97A.8060605@free-electrons.com>

On Thu, Aug 08, 2013 at 04:30:02PM +0100, Gregory CLEMENT wrote:
> On 07/08/2013 17:57, Jason Cooper wrote:
> > On Wed, Aug 07, 2013 at 04:35:46PM +0200, Wolfram Sang wrote:
> >>
> >>> But we shouldn't use it alone: we should always use:
> >>> compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
> >>>
> >>> From my point of view using  "marvell,mv78230-i2c" alone is an error.
> >>>
> >>> Wolfram what is your opinion on it?
> >>
> >> It is not strictly an error, but risky. If you use an older Kernel
> >> version (or other OS) which only offers "mv64xxx" you will have no
> >> match. Although the driver theoretically could have basic support for
> >> all mv64xxx variants skipping all additional features of later IP
> >> revisions.
> > 
> > I agree here.  The driver is advertising what IP blocks it can handle,
> > so it makes sense to add both strings since it can handle both.
> 
> Wolfram,
> so beside remarks about the compatibility strings. I didn't any other
> comment since the v3 which was 7 weeks ago.
> 
> Does it mean that once I will have added the handle of this string,
> you will be able to take the series for the 3.12 kernel?

Please could you also ensure the new string is documented in
Documentation/devicetree, with a brief description of what it implies
about the hardware beyond the exiting "marvell,mv64xxx-i2c" string.

Thanks,
Mark.

  reply	other threads:[~2013-08-08 16:43 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15 14:24 [PATCH 0/3] i2c-mv64xxx: Fixes and new feature for controlers embedded in Aramda XP Gregory CLEMENT
2013-07-15 14:24 ` Gregory CLEMENT
     [not found] ` <1373898278-4805-1-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-07-15 14:24   ` [PATCH 1/3] i2c-mv64xxx: Add I2C Transaction Generator support Gregory CLEMENT
2013-07-15 14:24     ` Gregory CLEMENT
     [not found]     ` <1373898278-4805-2-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-07-16  8:05       ` Maxime Ripard
2013-07-16  8:05         ` Maxime Ripard
2013-08-06 12:05         ` Gregory CLEMENT
2013-08-06 12:05           ` Gregory CLEMENT
     [not found]           ` <5200E684.5080003-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-08-06 16:21             ` Maxime Ripard
2013-08-06 16:21               ` Maxime Ripard
2013-08-06 17:55             ` Thomas Petazzoni
2013-08-06 17:55               ` Thomas Petazzoni
2013-08-07 14:35             ` Wolfram Sang
2013-08-07 14:35               ` Wolfram Sang
2013-08-07 15:57               ` Jason Cooper
2013-08-07 15:57                 ` Jason Cooper
     [not found]                 ` <20130807155700.GE19280-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2013-08-08 15:30                   ` Gregory CLEMENT
2013-08-08 15:30                     ` Gregory CLEMENT
2013-08-08 16:43                     ` Mark Rutland [this message]
2013-08-08 16:43                       ` Mark Rutland
2013-08-08 17:02                       ` Jason Cooper
2013-08-08 17:02                         ` Jason Cooper
2013-08-08 17:09                         ` Mark Rutland
2013-08-08 17:09                           ` Mark Rutland
2013-08-08 17:17                           ` Jason Cooper
2013-08-08 17:17                             ` Jason Cooper
     [not found]                     ` <5203B97A.8060605-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-08-09 13:22                       ` Wolfram Sang
2013-08-09 13:22                         ` Wolfram Sang
2013-07-15 14:24   ` [PATCH 2/3] i2c-mv64xxx: Fix timing issue on Armada XP (errata FE-8471889) Gregory CLEMENT
2013-07-15 14:24     ` Gregory CLEMENT
2013-07-15 14:24   ` [PATCH 3/3] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c Gregory CLEMENT
2013-07-15 14:24     ` Gregory CLEMENT
     [not found]     ` <1373898278-4805-4-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-08-03 17:36       ` Jason Cooper
2013-08-03 17:36         ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130808164323.GD27325@e106331-lin.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=Leif.Lindholm@arm.com \
    --cc=alior@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=benavi@marvell.com \
    --cc=dann.frazier@canonical.com \
    --cc=dmarlin@redhat.com \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=ike.pan@canonical.com \
    --cc=jason@lakedaemon.net \
    --cc=jcm@redhat.com \
    --cc=kosmo@semihalf.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=nadavh@marvell.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=tawfik@marvell.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=vanhoof@canonical.com \
    --cc=wsa@the-dreams.de \
    --cc=yehuday@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.