All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Keeping <john@keeping.me.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
	Ramkumar Ramachandra <artagnon@gmail.com>,
	Stefan Beller <stefanbeller@googlemail.com>,
	Git List <git@vger.kernel.org>
Subject: Re: [PATCH] whatchanged: document its historical nature
Date: Mon, 12 Aug 2013 08:50:00 +0100	[thread overview]
Message-ID: <20130812074959.GJ2337@serenity.lan> (raw)
In-Reply-To: <7vtxiy4m6o.fsf@alter.siamese.dyndns.org>

On Fri, Aug 09, 2013 at 01:57:19PM -0700, Junio C Hamano wrote:
> John Keeping <john@keeping.me.uk> writes:
> 
> >> +New users are encouraged to use linkgit:git-log[1] instead.  The
> >> +`whatchanged` command is essentially the same as linkgit:git-log[1]
> >> +run with different defaults that shows a --raw diff outputat the
> >
> > s/outputat/output at/
> 
> Thanks.
> 
> > Although I wonder if it would be better to say
> >
> >     New users are encouraged to use linkgit:git-log[1] instead.  The
> >     `whatchanged` command is essentially the same as linkgit:git-log[1]
> >     with the `--raw` option specified.
> 
> But that is different from the truth, no?  "git whatchanged -p" will
> not behave as if "git whatchanged -p" with the "--raw" specified.
> The 'raw' kicks in only as a default.

Hmm, I hadn't realised that specifying "-p" would disable the "--raw".
I still find the last sentence of the original patch slightly awkward
though.  How about

    New users are encouraged to use linkgit:git-log[1] instead.  The
    `whatchanged` command is essentially the same as linkgit:git-log[1]
    but defaults to ``raw'' diff output and does not show merge
    commits.

?

  reply	other threads:[~2013-08-12  7:50 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07 16:00 Remove old forgotten command: whatchanged Ramkumar Ramachandra
2013-08-07 16:51 ` Stefan Beller
2013-08-07 17:50   ` Junio C Hamano
2013-08-07 21:50     ` Stefan Beller
2013-08-08  6:39       ` Junio C Hamano
2013-08-08  4:30     ` Ramkumar Ramachandra
2013-08-08 15:03       ` Matthieu Moy
2013-08-08 15:13         ` Ramkumar Ramachandra
2013-08-08 15:24           ` Matthieu Moy
2013-08-08 17:23             ` Junio C Hamano
2013-08-09 20:01               ` [PATCH] whatchanged: document its historical nature Junio C Hamano
2013-08-09 20:14                 ` John Keeping
2013-08-09 20:57                   ` Junio C Hamano
2013-08-12  7:50                     ` John Keeping [this message]
2013-08-13 15:56                       ` Junio C Hamano
2013-08-10  7:04                 ` Ramkumar Ramachandra
2013-08-08 17:51         ` Remove old forgotten command: whatchanged Damien Robert
2013-08-08 18:05           ` Ramkumar Ramachandra
2013-08-08 18:06           ` Matthieu Moy
2013-08-08 19:09             ` John Keeping
2013-08-08 19:27             ` Junio C Hamano
2013-08-09  8:29               ` Matthieu Moy
2013-08-09 17:28                 ` Junio C Hamano
2013-08-13  7:58                   ` Matthieu Moy
2013-08-13 16:00                     ` Junio C Hamano
2013-08-08 19:19           ` Junio C Hamano
2013-08-09  0:04             ` Damien Robert
2013-08-09  0:11               ` Junio C Hamano
2013-08-07 18:01 ` Kyle J. McKay
2013-08-07 18:31   ` John Keeping
2013-08-07 18:48     ` Kyle J. McKay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130812074959.GJ2337@serenity.lan \
    --to=john@keeping.me.uk \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stefanbeller@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.