All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <stefanbeller@googlemail.com>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
	Git List <git@vger.kernel.org>
Subject: Re: Remove old forgotten command: whatchanged
Date: Wed, 07 Aug 2013 10:50:37 -0700	[thread overview]
Message-ID: <7vtxj1crv6.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <52027B17.7040602@googlemail.com> (Stefan Beller's message of "Wed, 07 Aug 2013 18:51:35 +0200")

Stefan Beller <stefanbeller@googlemail.com> writes:

> I'd deprecate it first for a year or such and remove it then.
> In the meantime we could implement already remove the code
> and change it to:
>
> + int cmd_whatchanged(int argc, const char **argv, const char *prefix)
> + {
> + 	return cmd_log(argc, argv, prefix)
> + }
>
> Also we should make sure everything git whatchanged can do,
> can easily be done with git log <options>.

That's even worse than "deprecating".

Your first step already changes the behaviour for people who really
use the command, without telling them _why_ the behaviour has
suddenly changed at all, while not helping *ANYBODY*.

The only thing it does is to scratch an irrelevant itch by people
who peek the codebase and find an old command whose existence does
not even hurt them.  They may have too much time on their hand, but
that is not an excuse to waste other people's time by adding extra
makework on our plate, or changing the behaviour for people who use
the command without explanation.

Feeling irritated somewhat...

  reply	other threads:[~2013-08-07 17:50 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07 16:00 Remove old forgotten command: whatchanged Ramkumar Ramachandra
2013-08-07 16:51 ` Stefan Beller
2013-08-07 17:50   ` Junio C Hamano [this message]
2013-08-07 21:50     ` Stefan Beller
2013-08-08  6:39       ` Junio C Hamano
2013-08-08  4:30     ` Ramkumar Ramachandra
2013-08-08 15:03       ` Matthieu Moy
2013-08-08 15:13         ` Ramkumar Ramachandra
2013-08-08 15:24           ` Matthieu Moy
2013-08-08 17:23             ` Junio C Hamano
2013-08-09 20:01               ` [PATCH] whatchanged: document its historical nature Junio C Hamano
2013-08-09 20:14                 ` John Keeping
2013-08-09 20:57                   ` Junio C Hamano
2013-08-12  7:50                     ` John Keeping
2013-08-13 15:56                       ` Junio C Hamano
2013-08-10  7:04                 ` Ramkumar Ramachandra
2013-08-08 17:51         ` Remove old forgotten command: whatchanged Damien Robert
2013-08-08 18:05           ` Ramkumar Ramachandra
2013-08-08 18:06           ` Matthieu Moy
2013-08-08 19:09             ` John Keeping
2013-08-08 19:27             ` Junio C Hamano
2013-08-09  8:29               ` Matthieu Moy
2013-08-09 17:28                 ` Junio C Hamano
2013-08-13  7:58                   ` Matthieu Moy
2013-08-13 16:00                     ` Junio C Hamano
2013-08-08 19:19           ` Junio C Hamano
2013-08-09  0:04             ` Damien Robert
2013-08-09  0:11               ` Junio C Hamano
2013-08-07 18:01 ` Kyle J. McKay
2013-08-07 18:31   ` John Keeping
2013-08-07 18:48     ` Kyle J. McKay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vtxj1crv6.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=stefanbeller@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.