From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Felipe Tonello <eu@felipetonello.com>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] ALSA: Added jack detection KControl support
Date: Mon, 12 Aug 2013 11:54:47 +0100 [thread overview]
Message-ID: <20130812105447.GQ6427@sirena.org.uk> (raw)
In-Reply-To: <s5hli47yz01.wl%tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
On Mon, Aug 12, 2013 at 12:39:10PM +0200, Takashi Iwai wrote:
> But, don't get me wrong: I'm not against the action itself, the
> removal of input jack support in HD-audio. I myself did propose this
> once ago. Again, what's missing in your approach is the proper
> process.
> - Think whether removal of input-jack support is really needed for
> HD-audio;
> for example, if you integrate snd_jack stuff to support both
> input-jack and kctl jack, HD-audio driver can use it solely instead
> of calling snd_kctl stuff. Then both input and kctl jacks will be
> supported automagically.
I think this is the best approach - just get everything using jack.c for
all types of jack and deal with things there. We've also got extcon
based reporting to consider, having a single place where all the
userspace interfaces are implemented will mean we can just add that.
This is why I put everything in jack.c in the first place :(
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Felipe Tonello <eu@felipetonello.com>
Subject: Re: [PATCH v3 1/2] ALSA: Added jack detection KControl support
Date: Mon, 12 Aug 2013 11:54:47 +0100 [thread overview]
Message-ID: <20130812105447.GQ6427@sirena.org.uk> (raw)
In-Reply-To: <s5hli47yz01.wl%tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 939 bytes --]
On Mon, Aug 12, 2013 at 12:39:10PM +0200, Takashi Iwai wrote:
> But, don't get me wrong: I'm not against the action itself, the
> removal of input jack support in HD-audio. I myself did propose this
> once ago. Again, what's missing in your approach is the proper
> process.
> - Think whether removal of input-jack support is really needed for
> HD-audio;
> for example, if you integrate snd_jack stuff to support both
> input-jack and kctl jack, HD-audio driver can use it solely instead
> of calling snd_kctl stuff. Then both input and kctl jacks will be
> supported automagically.
I think this is the best approach - just get everything using jack.c for
all types of jack and deal with things there. We've also got extcon
based reporting to consider, having a single place where all the
userspace interfaces are implemented will mean we can just add that.
This is why I put everything in jack.c in the first place :(
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-08-12 10:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 7:59 [PATCH v2 0/2] ALSA: Implement core jack support for kcontrol Felipe F. Tonello
2013-08-02 7:59 ` Felipe F. Tonello
2013-08-02 7:59 ` [PATCH v2 1/2] ALSA: Added jack detection KControl support Felipe F. Tonello
2013-08-07 16:45 ` Mark Brown
2013-08-07 16:45 ` Mark Brown
2013-08-07 23:06 ` Felipe Tonello
2013-08-08 5:45 ` Takashi Iwai
2013-08-09 6:21 ` [PATCH v3 " Felipe F. Tonello
2013-08-09 6:21 ` Felipe F. Tonello
2013-08-09 13:52 ` Takashi Iwai
2013-08-09 13:52 ` Takashi Iwai
2013-08-09 16:39 ` Mark Brown
2013-08-09 16:51 ` Takashi Iwai
2013-08-09 17:36 ` Felipe Tonello
2013-08-09 17:36 ` Felipe Tonello
2013-08-12 10:39 ` Takashi Iwai
2013-08-12 10:54 ` Mark Brown [this message]
2013-08-12 10:54 ` Mark Brown
2013-08-12 18:34 ` Felipe Tonello
2013-08-02 7:59 ` [PATCH v2 2/2] ALSA: SoC: Fix jack names according new API Felipe F. Tonello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812105447.GQ6427@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=eu@felipetonello.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.