All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] rt_sigaction: headers are included in a uniform way
@ 2013-08-13  4:50 Stanislav Kholmanskikh
  2013-08-13 16:11 ` chrubis
  0 siblings, 1 reply; 4+ messages in thread
From: Stanislav Kholmanskikh @ 2013-08-13  4:50 UTC (permalink / raw)
  To: ltp-list; +Cc: vasily.isaenko

Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
 include/ltp_signal.h                               |   17 ++++++++++++++++
 .../kernel/syscalls/rt_sigaction/rt_sigaction02.c  |   21 +------------------
 .../kernel/syscalls/rt_sigaction/rt_sigaction03.c  |    2 +
 3 files changed, 21 insertions(+), 19 deletions(-)

diff --git a/include/ltp_signal.h b/include/ltp_signal.h
index 95134e9..e6fb2e0 100644
--- a/include/ltp_signal.h
+++ b/include/ltp_signal.h
@@ -34,7 +34,24 @@
 #include <stdio.h>
 #include "config.h"
 
+/*
+ * For all but __mips__:
+ *
+ * _COMPAT_NSIG / _COMPAT_NSIG_BPW == 2.
+ *
+ * For __mips__:
+ *
+ * _COMPAT_NSIG / _COMPAT_NSIG_BPW == 4.
+ *
+ * See asm/compat.h under the kernel source for more details.
+ *
+ * Multiply that by a fudge factor of 4 and you have your SIGSETSIZE.
+ */
+#if defined __mips__
+#define SIGSETSIZE 16
+#else
 #define SIGSETSIZE (_NSIG / 8)
+#endif
 
 #ifdef LTP_RT_SIG_TEST
 
diff --git a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
index 5beabef..0e2915e 100644
--- a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
+++ b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
@@ -46,28 +46,11 @@
 #include <sys/syscall.h>
 #include <string.h>
 
+#define LTP_RT_SIG_TEST
 #include "test.h"
 #include "usctest.h"
 #include "linux_syscall_numbers.h"
-
-/*
- * For all but __mips__:
- *
- * _COMPAT_NSIG / _COMPAT_NSIG_BPW == 2.
- *
- * For __mips__:
- *
- * _COMPAT_NSIG / _COMPAT_NSIG_BPW == 4.
- *
- * See asm/compat.h under the kernel source for more details.
- *
- * Multiply that by a fudge factor of 4 and you have your SIGSETSIZE.
- */
-#if defined (__mips__)
-#define SIGSETSIZE 16
-#else
-#define SIGSETSIZE 8
-#endif
+#include "ltp_signal.h"
 
 #define INVAL_STRUCT -1
 
diff --git a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
index 646c37d..b160f2b 100644
--- a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
+++ b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
@@ -46,9 +46,11 @@
 #include <sys/syscall.h>
 #include <string.h>
 
+#define LTP_RT_SIG_TEST
 #include "test.h"
 #include "usctest.h"
 #include "linux_syscall_numbers.h"
+#include "ltp_signal.h"
 
 #define INVAL_SIGSETSIZE -1
 
-- 
1.7.1


------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [LTP] [PATCH] rt_sigaction: headers are included in a uniform way
  2013-08-13  4:50 [LTP] [PATCH] rt_sigaction: headers are included in a uniform way Stanislav Kholmanskikh
@ 2013-08-13 16:11 ` chrubis
  2013-08-14  7:31   ` [LTP] [PATCH V2] " Stanislav Kholmanskikh
  0 siblings, 1 reply; 4+ messages in thread
From: chrubis @ 2013-08-13 16:11 UTC (permalink / raw)
  To: Stanislav Kholmanskikh; +Cc: vasily.isaenko, ltp-list

Hi!
> diff --git a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
> index 5beabef..0e2915e 100644
> --- a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
> +++ b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
> @@ -46,28 +46,11 @@
>  #include <sys/syscall.h>
>  #include <string.h>
>  
> +#define LTP_RT_SIG_TEST

As far as I see these two testcases does not use the interface exposed
after this is defined. If this is so there is no need to define it here.

> diff --git a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
> index 646c37d..b160f2b 100644
> --- a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
> +++ b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
> @@ -46,9 +46,11 @@
>  #include <sys/syscall.h>
>  #include <string.h>
>  
> +#define LTP_RT_SIG_TEST

Here as well.


Otherwise it looks ok.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [LTP] [PATCH V2] rt_sigaction: headers are included in a uniform way
  2013-08-13 16:11 ` chrubis
@ 2013-08-14  7:31   ` Stanislav Kholmanskikh
  2013-08-14  9:34     ` chrubis
  0 siblings, 1 reply; 4+ messages in thread
From: Stanislav Kholmanskikh @ 2013-08-14  7:31 UTC (permalink / raw)
  To: ltp-list; +Cc: vasily.isaenko

Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
 include/ltp_signal.h                               |   17 +++++++++++++++++
 .../kernel/syscalls/rt_sigaction/rt_sigaction02.c  |   20 +-------------------
 .../kernel/syscalls/rt_sigaction/rt_sigaction03.c  |    1 +
 3 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/include/ltp_signal.h b/include/ltp_signal.h
index 95134e9..e6fb2e0 100644
--- a/include/ltp_signal.h
+++ b/include/ltp_signal.h
@@ -34,7 +34,24 @@
 #include <stdio.h>
 #include "config.h"
 
+/*
+ * For all but __mips__:
+ *
+ * _COMPAT_NSIG / _COMPAT_NSIG_BPW == 2.
+ *
+ * For __mips__:
+ *
+ * _COMPAT_NSIG / _COMPAT_NSIG_BPW == 4.
+ *
+ * See asm/compat.h under the kernel source for more details.
+ *
+ * Multiply that by a fudge factor of 4 and you have your SIGSETSIZE.
+ */
+#if defined __mips__
+#define SIGSETSIZE 16
+#else
 #define SIGSETSIZE (_NSIG / 8)
+#endif
 
 #ifdef LTP_RT_SIG_TEST
 
diff --git a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
index 5beabef..b89324f 100644
--- a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
+++ b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction02.c
@@ -49,25 +49,7 @@
 #include "test.h"
 #include "usctest.h"
 #include "linux_syscall_numbers.h"
-
-/*
- * For all but __mips__:
- *
- * _COMPAT_NSIG / _COMPAT_NSIG_BPW == 2.
- *
- * For __mips__:
- *
- * _COMPAT_NSIG / _COMPAT_NSIG_BPW == 4.
- *
- * See asm/compat.h under the kernel source for more details.
- *
- * Multiply that by a fudge factor of 4 and you have your SIGSETSIZE.
- */
-#if defined (__mips__)
-#define SIGSETSIZE 16
-#else
-#define SIGSETSIZE 8
-#endif
+#include "ltp_signal.h"
 
 #define INVAL_STRUCT -1
 
diff --git a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
index 646c37d..279f342 100644
--- a/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
+++ b/testcases/kernel/syscalls/rt_sigaction/rt_sigaction03.c
@@ -49,6 +49,7 @@
 #include "test.h"
 #include "usctest.h"
 #include "linux_syscall_numbers.h"
+#include "ltp_signal.h"
 
 #define INVAL_SIGSETSIZE -1
 
-- 
1.7.1


------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [LTP] [PATCH V2] rt_sigaction: headers are included in a uniform way
  2013-08-14  7:31   ` [LTP] [PATCH V2] " Stanislav Kholmanskikh
@ 2013-08-14  9:34     ` chrubis
  0 siblings, 0 replies; 4+ messages in thread
From: chrubis @ 2013-08-14  9:34 UTC (permalink / raw)
  To: Stanislav Kholmanskikh; +Cc: vasily.isaenko, ltp-list

Hi!
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> ---
>  include/ltp_signal.h                               |   17 +++++++++++++++++
>  .../kernel/syscalls/rt_sigaction/rt_sigaction02.c  |   20 +-------------------
>  .../kernel/syscalls/rt_sigaction/rt_sigaction03.c  |    1 +
>  3 files changed, 19 insertions(+), 19 deletions(-)

Pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-08-14  9:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-13  4:50 [LTP] [PATCH] rt_sigaction: headers are included in a uniform way Stanislav Kholmanskikh
2013-08-13 16:11 ` chrubis
2013-08-14  7:31   ` [LTP] [PATCH V2] " Stanislav Kholmanskikh
2013-08-14  9:34     ` chrubis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.