From: Sascha Hauer <s.hauer@pengutronix.de>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Nicolin Chen <b42378@freescale.com>,
ian.campbell@citrix.com, pawel.moll@arm.com,
galak@codeaurora.org, broonie@kernel.org, lars@metafoo.de,
p.zabel@pengutronix.de, linuxppc-dev@lists.ozlabs.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
timur@tabi.org, rob.herring@calxeda.com, shawn.guo@linaro.org,
festevam@gmail.com, swarren@wwwdotorg.org, mark.rutland@arm.com
Subject: Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver
Date: Sat, 17 Aug 2013 17:00:02 +0200 [thread overview]
Message-ID: <20130817150002.GU26614@pengutronix.de> (raw)
In-Reply-To: <137675716.iLf1T1CVZo@flatron>
On Sat, Aug 17, 2013 at 02:26:40PM +0200, Tomasz Figa wrote:
> > You mean tx<0-7>.
> >
> > Also I would make this option required. Use a dummy clock for mux inputs
> > that are grounded for a specific SoC.
>
> Why do you need a dummy clock?
>
> The driver can simply try to grab all the possible clocks and discard
> those that failed, so you can just keep those grounded clocks unspecified.
We don't need dummy clocks. My motivation saying this that I was afraid
people try to configure the driver by skipping the clocks they don't
want from the devicetree.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, lars@metafoo.de,
ian.campbell@citrix.com, pawel.moll@arm.com,
swarren@wwwdotorg.org, festevam@gmail.com,
Nicolin Chen <b42378@freescale.com>,
timur@tabi.org, rob.herring@calxeda.com, broonie@kernel.org,
p.zabel@pengutronix.de, galak@codeaurora.org,
shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver
Date: Sat, 17 Aug 2013 17:00:02 +0200 [thread overview]
Message-ID: <20130817150002.GU26614@pengutronix.de> (raw)
In-Reply-To: <137675716.iLf1T1CVZo@flatron>
On Sat, Aug 17, 2013 at 02:26:40PM +0200, Tomasz Figa wrote:
> > You mean tx<0-7>.
> >
> > Also I would make this option required. Use a dummy clock for mux inputs
> > that are grounded for a specific SoC.
>
> Why do you need a dummy clock?
>
> The driver can simply try to grab all the possible clocks and discard
> those that failed, so you can just keep those grounded clocks unspecified.
We don't need dummy clocks. My motivation saying this that I was afraid
people try to configure the driver by skipping the clocks they don't
want from the devicetree.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-08-17 15:00 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 11:26 [PATCH v5 0/2] Add freescale S/PDIF CPU DAI and machine drivers Nicolin Chen
2013-08-15 11:26 ` Nicolin Chen
2013-08-15 11:26 ` Nicolin Chen
2013-08-15 11:26 ` [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver Nicolin Chen
2013-08-15 11:26 ` Nicolin Chen
2013-08-15 11:26 ` Nicolin Chen
2013-08-15 12:18 ` Tomasz Figa
2013-08-15 12:18 ` Tomasz Figa
2013-08-15 12:18 ` Tomasz Figa
2013-08-16 4:43 ` Nicolin Chen
2013-08-16 7:08 ` Sascha Hauer
2013-08-16 8:01 ` Nicolin Chen
2013-08-16 8:56 ` Sascha Hauer
2013-08-16 9:53 ` Nicolin Chen
2013-08-16 10:11 ` Sascha Hauer
2013-08-16 10:16 ` Nicolin Chen
2013-08-17 12:28 ` Tomasz Figa
2013-08-17 12:28 ` Tomasz Figa
2013-08-17 14:53 ` Sascha Hauer
2013-08-17 14:53 ` Sascha Hauer
2013-08-17 15:17 ` Tomasz Figa
2013-08-17 15:17 ` Tomasz Figa
2013-08-19 9:35 ` Mark Rutland
2013-08-19 9:35 ` Mark Rutland
2013-08-20 0:06 ` Mike Turquette
2013-08-20 0:06 ` Mike Turquette
2013-08-20 0:06 ` Mike Turquette
2013-08-21 8:50 ` Mark Rutland
2013-08-21 8:50 ` Mark Rutland
2013-08-21 21:34 ` Tomasz Figa
2013-08-21 21:34 ` Tomasz Figa
2013-08-22 7:19 ` Mike Turquette
2013-08-22 7:19 ` Mike Turquette
2013-08-22 7:19 ` Mike Turquette
2013-08-22 12:09 ` Mark Rutland
2013-08-22 12:09 ` Mark Rutland
2013-08-22 21:00 ` Sascha Hauer
2013-08-22 21:00 ` Sascha Hauer
2013-08-22 22:43 ` Mike Turquette
2013-08-22 22:43 ` Mike Turquette
2013-08-22 22:43 ` Mike Turquette
2013-08-22 22:49 ` Tomasz Figa
2013-08-22 22:49 ` Tomasz Figa
2013-08-23 6:34 ` Sascha Hauer
2013-08-23 6:34 ` Sascha Hauer
2013-08-23 12:58 ` Mark Rutland
2013-08-23 12:58 ` Mark Rutland
2013-08-23 14:01 ` [alsa-devel] " Sascha Hauer
2013-08-23 14:01 ` Sascha Hauer
2013-08-23 14:01 ` Sascha Hauer
2013-08-23 14:57 ` [alsa-devel] " Mark Rutland
2013-08-23 14:57 ` Mark Rutland
2013-08-23 21:41 ` Mike Turquette
2013-08-23 21:41 ` Mike Turquette
2013-08-23 21:41 ` Mike Turquette
2013-08-24 0:20 ` [alsa-devel] " Mark Brown
2013-08-24 0:20 ` Mark Brown
2013-08-24 0:20 ` Mark Brown
2013-08-23 12:44 ` Mark Rutland
2013-08-23 12:44 ` Mark Rutland
2013-08-17 12:26 ` Tomasz Figa
2013-08-17 12:26 ` Tomasz Figa
2013-08-17 15:00 ` Sascha Hauer [this message]
2013-08-17 15:00 ` Sascha Hauer
2013-08-17 15:13 ` Tomasz Figa
2013-08-17 15:13 ` Tomasz Figa
2013-08-17 15:14 ` Sascha Hauer
2013-08-17 15:14 ` Sascha Hauer
2013-08-17 12:56 ` Tomasz Figa
2013-08-17 12:56 ` Tomasz Figa
2013-08-17 15:14 ` Sascha Hauer
2013-08-17 15:14 ` Sascha Hauer
2013-08-17 15:38 ` Tomasz Figa
2013-08-17 15:38 ` Tomasz Figa
2013-08-15 11:26 ` [PATCH v5 2/2] ASoC: fsl: Add S/PDIF machine driver Nicolin Chen
2013-08-15 11:26 ` Nicolin Chen
2013-08-15 11:26 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130817150002.GU26614@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=b42378@freescale.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=galak@codeaurora.org \
--cc=ian.campbell@citrix.com \
--cc=lars@metafoo.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=timur@tabi.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.