From: Wolfram Sang <wsa@the-dreams.de>
To: Hein Tibosch <hein_tibosch@yahoo.es>
Cc: balbi@ti.com, Grygorii Strashko <grygorii.strashko@ti.com>,
Tony Lindgren <tony@atomide.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c-omap: always send stop after nack
Date: Mon, 19 Aug 2013 14:11:23 +0200 [thread overview]
Message-ID: <20130819121123.GA4540@katana> (raw)
In-Reply-To: <51E57211.2040001@yahoo.es>
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
Hi,
> > Which means your original patch starts to make a lot more sense. I
> > wonder is this is really what we should be doing though - breaking out
> > of the loop, I mean.
Yup, that is fine. I applied the old patch with Acks from Hein and
Felipe to -next. Thanks!
> It looks like TI's i2c-davinci will have the same problem as i2c-omap,
> and will need the same change.
Somebody up for this?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Hein Tibosch <hein_tibosch-mRCrAkd8dF0@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
Grygorii Strashko
<grygorii.strashko-l0cyMroinI0@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
linux-i2c <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-omap <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c-omap: always send stop after nack
Date: Mon, 19 Aug 2013 14:11:23 +0200 [thread overview]
Message-ID: <20130819121123.GA4540@katana> (raw)
In-Reply-To: <51E57211.2040001-mRCrAkd8dF0@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
Hi,
> > Which means your original patch starts to make a lot more sense. I
> > wonder is this is really what we should be doing though - breaking out
> > of the loop, I mean.
Yup, that is fine. I applied the old patch with Acks from Hein and
Felipe to -next. Thanks!
> It looks like TI's i2c-davinci will have the same problem as i2c-omap,
> and will need the same change.
Somebody up for this?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-19 12:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 8:19 [PATCH] i2c-omap: always send stop after nack Hein Tibosch
2013-07-16 9:03 ` Felipe Balbi
2013-07-16 9:33 ` Hein Tibosch
2013-07-16 9:33 ` Hein Tibosch
2013-07-16 9:42 ` Felipe Balbi
2013-07-16 9:42 ` Felipe Balbi
2013-07-16 11:01 ` Grygorii Strashko
2013-07-16 11:01 ` Grygorii Strashko
2013-07-16 11:27 ` Felipe Balbi
2013-07-16 11:27 ` Felipe Balbi
2013-07-16 12:08 ` Grygorii Strashko
2013-07-16 12:08 ` Grygorii Strashko
2013-07-16 13:00 ` Felipe Balbi
2013-07-16 13:00 ` Felipe Balbi
2013-07-16 16:17 ` Hein Tibosch
2013-08-19 12:11 ` Wolfram Sang [this message]
2013-08-19 12:11 ` Wolfram Sang
2013-08-19 13:57 ` Felipe Balbi
2013-08-19 13:57 ` Felipe Balbi
2013-08-19 14:05 ` Wolfram Sang
2013-08-20 16:39 ` Grygorii Strashko
2013-08-20 16:39 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819121123.GA4540@katana \
--to=wsa@the-dreams.de \
--cc=balbi@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=hein_tibosch@yahoo.es \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.