* [patch -next] drm/prime: double lock typo
@ 2013-08-23 20:46 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-08-23 20:46 UTC (permalink / raw)
To: David Airlie; +Cc: dri-devel, Daniel Vetter, kernel-janitors
There is a typo so deadlocks on error instead of unlocking.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 7ae2bfc..276d470 100644
--- a/drivers/gpu/drm/drm_prime.c
+++ b/drivers/gpu/drm/drm_prime.c
@@ -552,7 +552,7 @@ fail:
*/
drm_gem_handle_delete(file_priv, *handle);
out_unlock:
- mutex_lock(&dev->object_name_lock);
+ mutex_unlock(&dev->object_name_lock);
out_put:
dma_buf_put(dma_buf);
mutex_unlock(&file_priv->prime.lock);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch -next] drm/prime: double lock typo
@ 2013-08-23 20:46 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-08-23 20:46 UTC (permalink / raw)
To: David Airlie; +Cc: dri-devel, Daniel Vetter, kernel-janitors
There is a typo so deadlocks on error instead of unlocking.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 7ae2bfc..276d470 100644
--- a/drivers/gpu/drm/drm_prime.c
+++ b/drivers/gpu/drm/drm_prime.c
@@ -552,7 +552,7 @@ fail:
*/
drm_gem_handle_delete(file_priv, *handle);
out_unlock:
- mutex_lock(&dev->object_name_lock);
+ mutex_unlock(&dev->object_name_lock);
out_put:
dma_buf_put(dma_buf);
mutex_unlock(&file_priv->prime.lock);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch -next] drm/prime: double lock typo
2013-08-23 20:46 ` Dan Carpenter
@ 2013-08-23 22:53 ` Daniel Vetter
-1 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2013-08-23 22:53 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David Airlie, dri-devel, Daniel Vetter, kernel-janitors
On Fri, Aug 23, 2013 at 11:46:02PM +0300, Dan Carpenter wrote:
> There is a typo so deadlocks on error instead of unlocking.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 7ae2bfc..276d470 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -552,7 +552,7 @@ fail:
> */
> drm_gem_handle_delete(file_priv, *handle);
> out_unlock:
> - mutex_lock(&dev->object_name_lock);
> + mutex_unlock(&dev->object_name_lock);
Duh. Unfortunately exercising error paths is pretty hard :( So thanks for
catching this.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch -next] drm/prime: double lock typo
@ 2013-08-23 22:53 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2013-08-23 22:53 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David Airlie, dri-devel, Daniel Vetter, kernel-janitors
On Fri, Aug 23, 2013 at 11:46:02PM +0300, Dan Carpenter wrote:
> There is a typo so deadlocks on error instead of unlocking.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 7ae2bfc..276d470 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -552,7 +552,7 @@ fail:
> */
> drm_gem_handle_delete(file_priv, *handle);
> out_unlock:
> - mutex_lock(&dev->object_name_lock);
> + mutex_unlock(&dev->object_name_lock);
Duh. Unfortunately exercising error paths is pretty hard :( So thanks for
catching this.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-23 22:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-23 20:46 [patch -next] drm/prime: double lock typo Dan Carpenter
2013-08-23 20:46 ` Dan Carpenter
2013-08-23 22:53 ` Daniel Vetter
2013-08-23 22:53 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.