Re: [RFC patch 1/3] [Babeltrace python bindings] Added missing call to _bt_ctf_get_decl_from_def() when calling _bt_ctf_get_int_len().

Re: [RFC patch 1/3] [Babeltrace python bindings] Added missing call to _bt_ctf_get_decl_from_def() when calling _bt_ctf_get_int_len().

[Jérémie Galarneau]

Something I forgot to mention when reviewing your first submission and
that applies to all patches from the series: we normally use the
present tense in the subject. Also, the subject line should not exceed
80 characters.
I don't know if Mathieu will prefer you resubmit or if he will make
the change himself.

Acked-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

Thanks,
Jérémie

On Tue, Aug 20, 2013 at 3:46 AM, Amit Margalit <AMITM@il.ibm.com> wrote:
> The python code that called _bt_ctf_get_int_len() failed to wrap self._d
> with the call to _bt_ctf_get_decl_from_def.
>
>
>
> Amit Margalit
> IBM XIV - Storage Reinvented
> XIV-NAS Development Team
> Tel. 03-689-7774
> Fax. 03-689-7230
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

Re: [RFC patch 1/3] [Babeltrace python bindings] Added missing call to _bt_ctf_get_decl_from_def() when calling _bt_ctf_get_int_len().

[Mathieu Desnoyers]

All 3 patches of this series merged. I applied the comments from Jeremie
myself. Please take them into consideration for future patches.

Thank you !

Mathieu

* Amit Margalit (AMITM@il.ibm.com) wrote:
> The python code that called _bt_ctf_get_int_len() failed to wrap self._d 
> with the call to _bt_ctf_get_decl_from_def.
> 
> 
> 
> Amit Margalit
> IBM XIV - Storage Reinvented
> XIV-NAS Development Team
> Tel. 03-689-7774
> Fax. 03-689-7230

> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev


-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

[RFC patch 1/3] [Babeltrace python bindings] Added missing call to _bt_ctf_get_decl_from_def() when calling _bt_ctf_get_int_len().

[Amit Margalit]

[-- Attachment #1.1: Type: text/plain, Size: 222 bytes --]

The python code that called _bt_ctf_get_int_len() failed to wrap self._d 
with the call to _bt_ctf_get_decl_from_def.



Amit Margalit
IBM XIV - Storage Reinvented
XIV-NAS Development Team
Tel. 03-689-7774
Fax. 03-689-7230

[-- Attachment #1.2: Type: text/html, Size: 783 bytes --]

[-- Attachment #2: 0001-Added-missing-call-to-_bt_ctf_get_decl_from_def-when.patch --]
[-- Type: application/octet-stream, Size: 853 bytes --]

From a6d0f3b22a0b78c323836ce635288bd8784e9601 Mon Sep 17 00:00:00 2001
From: Amit Margalit <amitm@il.ibm.com>
Date: Tue, 20 Aug 2013 09:29:02 +0300
Subject: [PATCH 1/3] Added missing call to _bt_ctf_get_decl_from_def() when
 calling _bt_ctf_get_int_len().

Signed-off-by: Amit Margalit <amitm@il.ibm.com>
---
 bindings/python/babeltrace.i.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bindings/python/babeltrace.i.in b/bindings/python/babeltrace.i.in
index dd2dacc..16dbbbd 100644
--- a/bindings/python/babeltrace.i.in
+++ b/bindings/python/babeltrace.i.in
@@ -866,7 +866,7 @@ class ctf:
 			Return the size, in bits, of an int or a negative
 			value on error.
 			"""
-			return _bt_ctf_get_int_len(self._d)
+			return _bt_ctf_get_int_len(_bt_ctf_get_decl_from_def(self._d))
 
 		def get_encoding(self):
 			"""
-- 
1.7.11.7


[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev