* [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error
@ 2013-08-27 16:48 Yongbok Kim
2013-08-27 19:48 ` Richard Henderson
2013-08-28 21:03 ` Aurelien Jarno
0 siblings, 2 replies; 4+ messages in thread
From: Yongbok Kim @ 2013-08-27 16:48 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, yongbok.kim, james.hogan, aurelien
From: James Hogan <james.hogan@imgtec.com>
In get_physical_address() is a qemu_log() call inside an #if 0 block.
When enabled the following build error is hit:
target-mips/helper.c In function ‘get_physical_address’:
target-mips/helper.c:220:13: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘hwaddr’ [-Werror=format]
Fix the *physical (hwaddr) formatting by using "%"HWADDR_PRIx instead of
TARGET_FMT_lx.
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
---
target-mips/helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-mips/helper.c b/target-mips/helper.c
index 6feef7b..33e0e88 100644
--- a/target-mips/helper.c
+++ b/target-mips/helper.c
@@ -193,7 +193,7 @@ static int get_physical_address (CPUMIPSState *env, hwaddr *physical,
}
}
#if 0
- qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n",
+ qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n",
address, rw, access_type, *physical, *prot, ret);
#endif
--
1.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error
2013-08-27 16:48 [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error Yongbok Kim
@ 2013-08-27 19:48 ` Richard Henderson
2013-08-28 8:28 ` James Hogan
2013-08-28 21:03 ` Aurelien Jarno
1 sibling, 1 reply; 4+ messages in thread
From: Richard Henderson @ 2013-08-27 19:48 UTC (permalink / raw)
To: Yongbok Kim; +Cc: qemu-trivial, james.hogan, qemu-devel, aurelien
On 08/27/2013 09:48 AM, Yongbok Kim wrote:
> #if 0
> - qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n",
> + qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n",
> address, rw, access_type, *physical, *prot, ret);
> #endif
While by itself correct, consider converting this to the trace infrastructure
(with uint64_t instead of hwaddr).
If it's not worth a trace, it's probably not worth keeping at all.
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error
2013-08-27 19:48 ` Richard Henderson
@ 2013-08-28 8:28 ` James Hogan
0 siblings, 0 replies; 4+ messages in thread
From: James Hogan @ 2013-08-28 8:28 UTC (permalink / raw)
To: Richard Henderson; +Cc: Yongbok Kim, qemu-trivial, qemu-devel, aurelien
On 27/08/13 20:48, Richard Henderson wrote:
> On 08/27/2013 09:48 AM, Yongbok Kim wrote:
>> #if 0
>> - qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n",
>> + qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n",
>> address, rw, access_type, *physical, *prot, ret);
>> #endif
>
> While by itself correct, consider converting this to the trace infrastructure
> (with uint64_t instead of hwaddr).
>
> If it's not worth a trace, it's probably not worth keeping at all.
True. I suspect it isn't worth a trace (I just happened to be modifying
that function so tried it out to test my changes - and anybody doing
that can easily add a temporary qemu_log/fprintf message themselves).
Cheers
James
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error
2013-08-27 16:48 [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error Yongbok Kim
2013-08-27 19:48 ` Richard Henderson
@ 2013-08-28 21:03 ` Aurelien Jarno
1 sibling, 0 replies; 4+ messages in thread
From: Aurelien Jarno @ 2013-08-28 21:03 UTC (permalink / raw)
To: Yongbok Kim; +Cc: qemu-trivial, james.hogan, qemu-devel
On Tue, Aug 27, 2013 at 05:48:36PM +0100, Yongbok Kim wrote:
> From: James Hogan <james.hogan@imgtec.com>
>
> In get_physical_address() is a qemu_log() call inside an #if 0 block.
> When enabled the following build error is hit:
>
> target-mips/helper.c In function ‘get_physical_address’:
> target-mips/helper.c:220:13: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘hwaddr’ [-Werror=format]
>
> Fix the *physical (hwaddr) formatting by using "%"HWADDR_PRIx instead of
> TARGET_FMT_lx.
>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
> ---
> target-mips/helper.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-mips/helper.c b/target-mips/helper.c
> index 6feef7b..33e0e88 100644
> --- a/target-mips/helper.c
> +++ b/target-mips/helper.c
> @@ -193,7 +193,7 @@ static int get_physical_address (CPUMIPSState *env, hwaddr *physical,
> }
> }
> #if 0
> - qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n",
> + qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n",
> address, rw, access_type, *physical, *prot, ret);
> #endif
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-28 21:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-27 16:48 [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error Yongbok Kim
2013-08-27 19:48 ` Richard Henderson
2013-08-28 8:28 ` James Hogan
2013-08-28 21:03 ` Aurelien Jarno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.