* [PATCH] ASoC: dapm: Fix auto-disable for inverted controls
@ 2013-08-30 15:39 Lars-Peter Clausen
2013-08-30 15:42 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2013-08-30 15:39 UTC (permalink / raw)
To: Mark Brown; +Cc: Bard Liao, Stephen Warren, linux-kernel, Lars-Peter Clausen
We need to make sure that the control's cached value is initialized to the same
value as the control's widget->on_val. Otherwise updates might be lost.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
sound/soc/soc-dapm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 548b1c9..c17c14c 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -229,6 +229,8 @@ static int dapm_kcontrol_data_alloc(struct snd_soc_dapm_widget *widget,
template.id = snd_soc_dapm_kcontrol;
template.name = kcontrol->id.name;
+ data->value = template.on_val;
+
data->widget = snd_soc_dapm_new_control(widget->dapm,
&template);
if (!data->widget) {
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: dapm: Fix auto-disable for inverted controls
2013-08-30 15:39 [PATCH] ASoC: dapm: Fix auto-disable for inverted controls Lars-Peter Clausen
@ 2013-08-30 15:42 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-08-30 15:42 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Bard Liao, Stephen Warren, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
On Fri, Aug 30, 2013 at 05:39:33PM +0200, Lars-Peter Clausen wrote:
> We need to make sure that the control's cached value is initialized to the same
> value as the control's widget->on_val. Otherwise updates might be lost.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-30 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-30 15:39 [PATCH] ASoC: dapm: Fix auto-disable for inverted controls Lars-Peter Clausen
2013-08-30 15:42 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.