All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Olof Johansson <olof@lixom.net>
Cc: "Jon Medhurst (Tixy)" <tixy@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: vexpress: Add CCI node to TC2 device-tree
Date: Fri, 30 Aug 2013 18:36:37 +0100	[thread overview]
Message-ID: <20130830173636.GB10045@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <CAOesGMhwqqOuSwVEukpfqM00BV2i=fQRhLUaf-wf-iVGR_mNbg@mail.gmail.com>

On Fri, Aug 30, 2013 at 05:30:17PM +0100, Olof Johansson wrote:
> On Fri, Aug 30, 2013 at 9:13 AM, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> 
> > Now that MCPM and CPU idle are heading to mainline, it should get queued asap,
> > thanks for that, probably as a fix at -rc1, since it is quite late now.
> 
> This is not a regression, it's a missing piece of a feature. It's not
> post-rc1 material.

It is an incomplete dts, which has been true since the dts file for TC2 has
been merged in the kernel or better since the CCI bindings got merged in
the kernel.

> It's also an indication that nobody actually tested the feature branch
> before the pull request was sent. Hrmpf.

It has been tested and we were aware that the dts in the kernel was missing
the CCI node, we were not really sure about what to do given the ongoing
discussions on dts in the kernel and so on and considered that we might
get the patch in as a fix eventually; we made a mistake, sorry.

> Shouldn't you be updating some vexpress_defconfig and probably
> multi_v7_defconfig to at least get some build coverage for this as
> well, by the way?
> 
> I really should hold this off for 3.13, but I'll apply it to the late/
> branch anyway.

Thanks,
Lorenzo

WARNING: multiple messages have this Message-ID (diff)
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: vexpress: Add CCI node to TC2 device-tree
Date: Fri, 30 Aug 2013 18:36:37 +0100	[thread overview]
Message-ID: <20130830173636.GB10045@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <CAOesGMhwqqOuSwVEukpfqM00BV2i=fQRhLUaf-wf-iVGR_mNbg@mail.gmail.com>

On Fri, Aug 30, 2013 at 05:30:17PM +0100, Olof Johansson wrote:
> On Fri, Aug 30, 2013 at 9:13 AM, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> 
> > Now that MCPM and CPU idle are heading to mainline, it should get queued asap,
> > thanks for that, probably as a fix at -rc1, since it is quite late now.
> 
> This is not a regression, it's a missing piece of a feature. It's not
> post-rc1 material.

It is an incomplete dts, which has been true since the dts file for TC2 has
been merged in the kernel or better since the CCI bindings got merged in
the kernel.

> It's also an indication that nobody actually tested the feature branch
> before the pull request was sent. Hrmpf.

It has been tested and we were aware that the dts in the kernel was missing
the CCI node, we were not really sure about what to do given the ongoing
discussions on dts in the kernel and so on and considered that we might
get the patch in as a fix eventually; we made a mistake, sorry.

> Shouldn't you be updating some vexpress_defconfig and probably
> multi_v7_defconfig to at least get some build coverage for this as
> well, by the way?
> 
> I really should hold this off for 3.13, but I'll apply it to the late/
> branch anyway.

Thanks,
Lorenzo

  parent reply	other threads:[~2013-08-30 17:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30 14:26 [PATCH] ARM: dts: vexpress: Add CCI node to TC2 device-tree Jon Medhurst (Tixy)
2013-08-30 14:26 ` Jon Medhurst (Tixy)
2013-08-30 15:48 ` Pawel Moll
2013-08-30 15:48   ` Pawel Moll
2013-08-30 16:13 ` Lorenzo Pieralisi
2013-08-30 16:13   ` Lorenzo Pieralisi
2013-08-30 16:30   ` Olof Johansson
2013-08-30 16:30     ` Olof Johansson
2013-08-30 16:36     ` Pawel Moll
2013-08-30 16:36       ` Pawel Moll
2013-08-30 17:36     ` Lorenzo Pieralisi [this message]
2013-08-30 17:36       ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130830173636.GB10045@e102568-lin.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=Pawel.Moll@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=olof@lixom.net \
    --cc=tixy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.