All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: xillybus: fix format string usage
@ 2013-09-11  4:38 Kees Cook
  0 siblings, 0 replies; only message in thread
From: Kees Cook @ 2013-09-11  4:38 UTC (permalink / raw)
  To: linux-kernel
  Cc: Greg Kroah-Hartman, Eli Billauer, Wei Yongjun, Masanari Iida, devel

Makes sure format string cannot leak into device_create() call.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 drivers/staging/xillybus/xillybus_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/xillybus/xillybus_core.c b/drivers/staging/xillybus/xillybus_core.c
index efc5698..7db6f03 100644
--- a/drivers/staging/xillybus/xillybus_core.c
+++ b/drivers/staging/xillybus/xillybus_core.c
@@ -2054,7 +2054,7 @@ static int xillybus_init_chrdev(struct xilly_endpoint *endpoint,
 				       NULL,
 				       MKDEV(major, i),
 				       NULL,
-				       devname);
+				       "%s", devname);
 
 		if (IS_ERR(device)) {
 			pr_warn("xillybus: Failed to create %s "
-- 
1.7.9.5


-- 
Kees Cook
Chrome OS Security

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-09-11  4:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-11  4:38 [PATCH] staging: xillybus: fix format string usage Kees Cook

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.