* [PATCH] xen-netback: fix possible format string flaw
@ 2013-09-11 4:39 Kees Cook
0 siblings, 0 replies; 6+ messages in thread
From: Kees Cook @ 2013-09-11 4:39 UTC (permalink / raw)
To: linux-kernel; +Cc: xen-devel, Ian Campbell, netdev
This makes sure a format string cannot accidentally leak into the
kthread_run() call.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/net/xen-netback/interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 625c6f4..77fee1d 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -406,7 +406,7 @@ int xenvif_connect(struct xenvif *vif, unsigned long tx_ring_ref,
init_waitqueue_head(&vif->wq);
vif->task = kthread_create(xenvif_kthread,
- (void *)vif, vif->dev->name);
+ (void *)vif, "%s", vif->dev->name);
if (IS_ERR(vif->task)) {
pr_warn("Could not allocate kthread for %s\n", vif->dev->name);
err = PTR_ERR(vif->task);
--
1.7.9.5
--
Kees Cook
Chrome OS Security
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xen-netback: fix possible format string flaw
2013-09-11 7:18 ` Ian Campbell
@ 2013-09-12 21:20 ` David Miller
2013-09-12 21:20 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2013-09-12 21:20 UTC (permalink / raw)
To: Ian.Campbell; +Cc: keescook, linux-kernel, xen-devel, netdev
From: Ian Campbell <Ian.Campbell@citrix.com>
Date: Wed, 11 Sep 2013 08:18:13 +0100
> On Tue, 2013-09-10 at 21:39 -0700, Kees Cook wrote:
>> This makes sure a format string cannot accidentally leak into the
>> kthread_run() call.
>>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen-netback: fix possible format string flaw
2013-09-11 7:18 ` Ian Campbell
2013-09-12 21:20 ` David Miller
@ 2013-09-12 21:20 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2013-09-12 21:20 UTC (permalink / raw)
To: Ian.Campbell; +Cc: xen-devel, netdev, keescook, linux-kernel
From: Ian Campbell <Ian.Campbell@citrix.com>
Date: Wed, 11 Sep 2013 08:18:13 +0100
> On Tue, 2013-09-10 at 21:39 -0700, Kees Cook wrote:
>> This makes sure a format string cannot accidentally leak into the
>> kthread_run() call.
>>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen-netback: fix possible format string flaw
2013-09-11 4:39 Kees Cook
2013-09-11 7:18 ` Ian Campbell
@ 2013-09-11 7:18 ` Ian Campbell
2013-09-12 21:20 ` David Miller
2013-09-12 21:20 ` David Miller
1 sibling, 2 replies; 6+ messages in thread
From: Ian Campbell @ 2013-09-11 7:18 UTC (permalink / raw)
To: Kees Cook; +Cc: linux-kernel, xen-devel, netdev
On Tue, 2013-09-10 at 21:39 -0700, Kees Cook wrote:
> This makes sure a format string cannot accidentally leak into the
> kthread_run() call.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Thanks.
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen-netback: fix possible format string flaw
2013-09-11 4:39 Kees Cook
@ 2013-09-11 7:18 ` Ian Campbell
2013-09-11 7:18 ` Ian Campbell
1 sibling, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2013-09-11 7:18 UTC (permalink / raw)
To: Kees Cook; +Cc: xen-devel, linux-kernel, netdev
On Tue, 2013-09-10 at 21:39 -0700, Kees Cook wrote:
> This makes sure a format string cannot accidentally leak into the
> kthread_run() call.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Thanks.
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] xen-netback: fix possible format string flaw
@ 2013-09-11 4:39 Kees Cook
2013-09-11 7:18 ` Ian Campbell
2013-09-11 7:18 ` Ian Campbell
0 siblings, 2 replies; 6+ messages in thread
From: Kees Cook @ 2013-09-11 4:39 UTC (permalink / raw)
To: linux-kernel; +Cc: Ian Campbell, xen-devel, netdev
This makes sure a format string cannot accidentally leak into the
kthread_run() call.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/net/xen-netback/interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 625c6f4..77fee1d 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -406,7 +406,7 @@ int xenvif_connect(struct xenvif *vif, unsigned long tx_ring_ref,
init_waitqueue_head(&vif->wq);
vif->task = kthread_create(xenvif_kthread,
- (void *)vif, vif->dev->name);
+ (void *)vif, "%s", vif->dev->name);
if (IS_ERR(vif->task)) {
pr_warn("Could not allocate kthread for %s\n", vif->dev->name);
err = PTR_ERR(vif->task);
--
1.7.9.5
--
Kees Cook
Chrome OS Security
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-12 21:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-11 4:39 [PATCH] xen-netback: fix possible format string flaw Kees Cook
2013-09-11 4:39 Kees Cook
2013-09-11 7:18 ` Ian Campbell
2013-09-11 7:18 ` Ian Campbell
2013-09-12 21:20 ` David Miller
2013-09-12 21:20 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.