All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/vlv: disable rc6p and rc6pp residency reporting on BYT
@ 2013-09-11 20:43 Jesse Barnes
  2013-09-11 21:54 ` Chris Wilson
  2013-09-12 20:38 ` Daniel Vetter
  0 siblings, 2 replies; 6+ messages in thread
From: Jesse Barnes @ 2013-09-11 20:43 UTC (permalink / raw)
  To: intel-gfx

Unsupported; we just do RC6.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/i915_sysfs.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c
index c8c4112..a813905 100644
--- a/drivers/gpu/drm/i915/i915_sysfs.c
+++ b/drivers/gpu/drm/i915/i915_sysfs.c
@@ -65,6 +65,8 @@ show_rc6p_ms(struct device *kdev, struct device_attribute *attr, char *buf)
 {
 	struct drm_minor *dminor = container_of(kdev, struct drm_minor, kdev);
 	u32 rc6p_residency = calc_residency(dminor->dev, GEN6_GT_GFX_RC6p);
+	if (IS_VALLEYVIEW(dminor->dev))
+		rc6p_residency = 0;
 	return snprintf(buf, PAGE_SIZE, "%u\n", rc6p_residency);
 }
 
@@ -73,6 +75,8 @@ show_rc6pp_ms(struct device *kdev, struct device_attribute *attr, char *buf)
 {
 	struct drm_minor *dminor = container_of(kdev, struct drm_minor, kdev);
 	u32 rc6pp_residency = calc_residency(dminor->dev, GEN6_GT_GFX_RC6pp);
+	if (IS_VALLEYVIEW(dminor->dev))
+		rc6pp_residency = 0;
 	return snprintf(buf, PAGE_SIZE, "%u\n", rc6pp_residency);
 }
 
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/vlv: disable rc6p and rc6pp residency reporting on BYT
  2013-09-11 20:43 [PATCH] drm/i915/vlv: disable rc6p and rc6pp residency reporting on BYT Jesse Barnes
@ 2013-09-11 21:54 ` Chris Wilson
  2013-09-11 22:04   ` Jesse Barnes
  2013-09-12 20:38 ` Daniel Vetter
  1 sibling, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2013-09-11 21:54 UTC (permalink / raw)
  To: Jesse Barnes; +Cc: intel-gfx

On Wed, Sep 11, 2013 at 01:43:20PM -0700, Jesse Barnes wrote:
> Unsupported; we just do RC6.

Same for Haswell, right?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/vlv: disable rc6p and rc6pp residency reporting on BYT
  2013-09-11 21:54 ` Chris Wilson
@ 2013-09-11 22:04   ` Jesse Barnes
  0 siblings, 0 replies; 6+ messages in thread
From: Jesse Barnes @ 2013-09-11 22:04 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

On Wed, 11 Sep 2013 22:54:54 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Wed, Sep 11, 2013 at 01:43:20PM -0700, Jesse Barnes wrote:
> > Unsupported; we just do RC6.
> 
> Same for Haswell, right?

Dunno... didn't check.  Paulo?

-- 
Jesse Barnes, Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/vlv: disable rc6p and rc6pp residency reporting on BYT
  2013-09-11 20:43 [PATCH] drm/i915/vlv: disable rc6p and rc6pp residency reporting on BYT Jesse Barnes
  2013-09-11 21:54 ` Chris Wilson
@ 2013-09-12 20:38 ` Daniel Vetter
  2013-09-12 20:52   ` Jesse Barnes
  1 sibling, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2013-09-12 20:38 UTC (permalink / raw)
  To: Jesse Barnes; +Cc: intel-gfx

On Wed, Sep 11, 2013 at 01:43:20PM -0700, Jesse Barnes wrote:
> Unsupported; we just do RC6.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

You only change the sysfs stuff here, so I wondered where the hunk for
intel_pm.c is. And noticed that we don't actually obey the enable_rc6
parameter! Aside: We don't do any such force-to-0 stuff on other
platforms, so why do we need this?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/vlv: disable rc6p and rc6pp residency reporting on BYT
  2013-09-12 20:38 ` Daniel Vetter
@ 2013-09-12 20:52   ` Jesse Barnes
  2013-09-20  7:46     ` Daniel Vetter
  0 siblings, 1 reply; 6+ messages in thread
From: Jesse Barnes @ 2013-09-12 20:52 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

On Thu, 12 Sep 2013 22:38:41 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Wed, Sep 11, 2013 at 01:43:20PM -0700, Jesse Barnes wrote:
> > Unsupported; we just do RC6.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> You only change the sysfs stuff here, so I wondered where the hunk for
> intel_pm.c is. And noticed that we don't actually obey the enable_rc6
> parameter! Aside: We don't do any such force-to-0 stuff on other
> platforms, so why do we need this?

Gosh all these questions for such a simple patch.

I was just annoyed that the sysfs rc6 residency test was getting bogus
values from registers that happened to be there but don't correlate
with rc6.

-- 
Jesse Barnes, Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/vlv: disable rc6p and rc6pp residency reporting on BYT
  2013-09-12 20:52   ` Jesse Barnes
@ 2013-09-20  7:46     ` Daniel Vetter
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2013-09-20  7:46 UTC (permalink / raw)
  To: Jesse Barnes; +Cc: intel-gfx

On Thu, Sep 12, 2013 at 01:52:36PM -0700, Jesse Barnes wrote:
> On Thu, 12 Sep 2013 22:38:41 +0200
> Daniel Vetter <daniel@ffwll.ch> wrote:
> 
> > On Wed, Sep 11, 2013 at 01:43:20PM -0700, Jesse Barnes wrote:
> > > Unsupported; we just do RC6.
> > > 
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > 
> > You only change the sysfs stuff here, so I wondered where the hunk for
> > intel_pm.c is. And noticed that we don't actually obey the enable_rc6
> > parameter! Aside: We don't do any such force-to-0 stuff on other
> > platforms, so why do we need this?
> 
> Gosh all these questions for such a simple patch.
> 
> I was just annoyed that the sysfs rc6 residency test was getting bogus
> values from registers that happened to be there but don't correlate
> with rc6.

Queued for -next, thanks for the patch. I've also pimped the commit
message a bit to explain what's going on.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-20  7:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-11 20:43 [PATCH] drm/i915/vlv: disable rc6p and rc6pp residency reporting on BYT Jesse Barnes
2013-09-11 21:54 ` Chris Wilson
2013-09-11 22:04   ` Jesse Barnes
2013-09-12 20:38 ` Daniel Vetter
2013-09-12 20:52   ` Jesse Barnes
2013-09-20  7:46     ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.