From: "Pali Rohár" <pali.rohar@gmail.com>
To: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, freemangordon@abv.bg,
aaro.koskinen@iki.fi, pavel@ucw.cz
Subject: Re: [PATCH 4/4] RX-51: Add platform function and data for bq24150a charger
Date: Tue, 24 Sep 2013 19:05:47 +0200 [thread overview]
Message-ID: <201309241905.48301@pali> (raw)
In-Reply-To: <20130923204714.GB22995@earth.universe>
[-- Attachment #1: Type: Text/Plain, Size: 1674 bytes --]
On Monday 23 September 2013 22:47:15 Sebastian Reichel wrote:
> On Mon, Sep 23, 2013 at 10:06:46PM +0200, Pali Rohár wrote:
> > On Monday 23 September 2013 22:00:09 Sebastian Reichel wrote:
> > > On Mon, Sep 23, 2013 at 09:16:18PM +0200, Pali Rohár wrote:
> > > > It is not as simple as it looks. This is reason why I
> > > > submited this patch long time after I submited bq2415x
> > > > driver.
> > > >
> > > > Problem is that for rx51 is needed specific function
> > > > which connect to two drivers (bq2415x and isp1704) plus
> > > > it call specific rx51 board functions.
> > > >
> > > > Something which cannot be in DT (unless DT support C/ASM
> > > > code).
> > >
> > > mh could isp1704 driver expose the data via the regulator
> > > framework?
> >
> > No, isp1704 is power supply driver and export data via power
> > supply (sysfs) interface. It is not regulator but charger
> > driver.
>
> well it does not charge the battery directly, but just
> provides a power line with 5 Volt and a specified amount of
> current to the system, doesn't it?
>
No, isp1704 driver is doing fastcharger detection (and then
export charger type via sysfs power supply) based on musb usb
events.
Real charging (enabling/disabling and setting properties) is done
by bq24150a chip which has own power driver bq2415x_charger.
As already wrote this is not simple and this is reason why I sent
board data and functions only now...
> From my POV this is a candiate for the regulator framework:
>
> https://www.kernel.org/doc/Documentation/power/regulator/overv
> iew.txt
>
> -- Sebastian
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pali.rohar@gmail.com (Pali Rohár)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] RX-51: Add platform function and data for bq24150a charger
Date: Tue, 24 Sep 2013 19:05:47 +0200 [thread overview]
Message-ID: <201309241905.48301@pali> (raw)
In-Reply-To: <20130923204714.GB22995@earth.universe>
On Monday 23 September 2013 22:47:15 Sebastian Reichel wrote:
> On Mon, Sep 23, 2013 at 10:06:46PM +0200, Pali Roh?r wrote:
> > On Monday 23 September 2013 22:00:09 Sebastian Reichel wrote:
> > > On Mon, Sep 23, 2013 at 09:16:18PM +0200, Pali Roh?r wrote:
> > > > It is not as simple as it looks. This is reason why I
> > > > submited this patch long time after I submited bq2415x
> > > > driver.
> > > >
> > > > Problem is that for rx51 is needed specific function
> > > > which connect to two drivers (bq2415x and isp1704) plus
> > > > it call specific rx51 board functions.
> > > >
> > > > Something which cannot be in DT (unless DT support C/ASM
> > > > code).
> > >
> > > mh could isp1704 driver expose the data via the regulator
> > > framework?
> >
> > No, isp1704 is power supply driver and export data via power
> > supply (sysfs) interface. It is not regulator but charger
> > driver.
>
> well it does not charge the battery directly, but just
> provides a power line with 5 Volt and a specified amount of
> current to the system, doesn't it?
>
No, isp1704 driver is doing fastcharger detection (and then
export charger type via sysfs power supply) based on musb usb
events.
Real charging (enabling/disabling and setting properties) is done
by bq24150a chip which has own power driver bq2415x_charger.
As already wrote this is not simple and this is reason why I sent
board data and functions only now...
> From my POV this is a candiate for the regulator framework:
>
> https://www.kernel.org/doc/Documentation/power/regulator/overv
> iew.txt
>
> -- Sebastian
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130924/23254e9e/attachment.sig>
next prev parent reply other threads:[~2013-09-24 17:05 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-08 8:50 [PATCH 0/4] Add support for charging battery in Nokia RX-51 Pali Rohár
2013-09-08 8:50 ` Pali Rohár
2013-09-08 8:50 ` [PATCH 1/4] usb: musb: Call atomic_notifier_call_chain when status is changed Pali Rohár
2013-09-08 8:50 ` Pali Rohár
2013-09-17 15:48 ` Felipe Balbi
2013-09-17 15:48 ` Felipe Balbi
2013-09-17 15:48 ` Felipe Balbi
2013-09-17 15:49 ` Felipe Balbi
2013-09-17 15:49 ` Felipe Balbi
2013-09-17 15:49 ` Felipe Balbi
2013-09-17 16:05 ` Pali Rohár
2013-09-17 16:05 ` Pali Rohár
2013-09-17 16:05 ` Pali Rohár
2013-09-17 16:08 ` Felipe Balbi
2013-09-17 16:08 ` Felipe Balbi
2013-09-17 16:08 ` Felipe Balbi
2013-09-17 19:28 ` Pali Rohár
2013-09-17 19:28 ` Pali Rohár
2013-09-18 1:49 ` Felipe Balbi
2013-09-18 1:49 ` Felipe Balbi
2013-09-18 1:49 ` Felipe Balbi
2013-09-18 8:20 ` Pali Rohár
2013-09-18 8:20 ` Pali Rohár
2013-09-18 8:20 ` Pali Rohár
2013-09-18 9:04 ` Javier Martinez Canillas
2013-09-18 9:04 ` Javier Martinez Canillas
2013-09-18 9:04 ` Javier Martinez Canillas
2013-09-18 13:30 ` Pavel Machek
2013-09-18 13:30 ` Pavel Machek
2013-09-18 13:57 ` Javier Martinez Canillas
2013-09-18 13:57 ` Javier Martinez Canillas
2013-09-18 14:22 ` Pavel Machek
2013-09-18 14:22 ` Pavel Machek
2013-09-18 14:35 ` Pavel Machek
2013-09-18 14:35 ` Pavel Machek
2013-09-18 16:25 ` Felipe Balbi
2013-09-18 16:25 ` Felipe Balbi
2013-09-18 16:25 ` Felipe Balbi
2013-09-18 14:53 ` Javier Martinez Canillas
2013-09-18 14:53 ` Javier Martinez Canillas
2013-09-18 15:56 ` Pali Rohár
2013-09-18 15:56 ` Pali Rohár
2013-09-18 15:56 ` Pali Rohár
2013-09-18 16:36 ` Felipe Balbi
2013-09-18 16:36 ` Felipe Balbi
2013-09-18 16:36 ` Felipe Balbi
2013-09-18 16:43 ` Pali Rohár
2013-09-18 16:43 ` Pali Rohár
2013-09-18 16:43 ` Pali Rohár
2013-09-18 16:48 ` Felipe Balbi
2013-09-18 16:48 ` Felipe Balbi
2013-09-18 16:48 ` Felipe Balbi
2013-09-18 17:03 ` [PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER_HEAD Pali Rohár
2013-09-18 17:03 ` Pali Rohár
2013-09-18 17:03 ` Pali Rohár
2013-09-25 8:17 ` Pali Rohár
2013-09-25 8:17 ` Pali Rohár
2013-09-25 8:17 ` Pali Rohár
2013-09-25 20:33 ` Felipe Balbi
2013-09-25 20:33 ` Felipe Balbi
2013-09-25 20:33 ` Felipe Balbi
2013-09-26 0:00 ` Pavel Machek
2013-09-26 0:00 ` Pavel Machek
2013-10-01 14:22 ` Felipe Balbi
2013-10-01 14:22 ` Felipe Balbi
2013-10-01 14:22 ` Felipe Balbi
2013-09-18 17:03 ` [PATCH usb 2/2] usb: musb: Call atomic_notifier_call_chain when status is changed Pali Rohár
2013-09-18 17:03 ` Pali Rohár
2013-09-18 17:03 ` Pali Rohár
2013-09-08 8:50 ` [PATCH 2/4] power: isp1704_charger: Fix driver to work with changes introduced in v3.5 Pali Rohár
2013-09-08 8:50 ` Pali Rohár
2013-10-22 21:03 ` Anton Vorontsov
2013-10-22 21:03 ` Anton Vorontsov
2013-09-08 8:50 ` [PATCH 3/4] power: isp1704_charger: Add callback function set_current Pali Rohár
2013-09-08 8:50 ` Pali Rohár
2013-09-08 8:50 ` [PATCH 4/4] RX-51: Add platform function and data for bq24150a charger Pali Rohár
2013-09-08 8:50 ` Pali Rohár
2013-09-09 13:39 ` Sebastian Reichel
2013-09-09 13:39 ` Sebastian Reichel
2013-09-20 19:22 ` Pali Rohár
2013-09-20 19:22 ` Pali Rohár
2013-09-23 18:03 ` Tony Lindgren
2013-09-23 18:03 ` Tony Lindgren
2013-09-23 19:16 ` Pali Rohár
2013-09-23 19:16 ` Pali Rohár
2013-09-23 20:00 ` Sebastian Reichel
2013-09-23 20:00 ` Sebastian Reichel
2013-09-23 20:06 ` Pali Rohár
2013-09-23 20:06 ` Pali Rohár
2013-09-23 20:47 ` Sebastian Reichel
2013-09-23 20:47 ` Sebastian Reichel
2013-09-23 23:11 ` Tony Lindgren
2013-09-23 23:11 ` Tony Lindgren
2013-09-24 0:05 ` Pavel Machek
2013-09-24 0:05 ` Pavel Machek
2013-09-24 17:05 ` Pali Rohár [this message]
2013-09-24 17:05 ` Pali Rohár
2013-09-24 20:50 ` Sebastian Reichel
2013-09-24 20:50 ` Sebastian Reichel
2013-09-14 9:38 ` [PATCH 0/4] Add support for charging battery in Nokia RX-51 Pali Rohár
2013-09-14 9:38 ` Pali Rohár
2013-09-21 13:42 ` Pali Rohár
2013-09-21 13:42 ` Pali Rohár
2013-11-19 10:18 ` [PATCH v2 0/3] " Pali Rohár
2013-11-19 10:18 ` [PATCH v2 1/3] power_supply: Add power_supply notifier Pali Rohár
2013-11-19 13:10 ` Pavel Machek
2013-11-19 13:19 ` Pali Rohár
2013-11-24 17:02 ` Sebastian Reichel
2013-11-27 17:23 ` Tc, Jenny
2013-11-27 17:23 ` Tc, Jenny
2013-12-01 22:20 ` Anton Vorontsov
2013-12-01 22:23 ` Anton Vorontsov
2013-12-01 22:23 ` Anton Vorontsov
2014-01-03 11:09 ` Tc, Jenny
2014-01-03 11:09 ` Tc, Jenny
2014-01-03 16:02 ` Anton Vorontsov
2013-11-19 10:18 ` [PATCH v2 2/3] bq2415x_charger: Use power_supply notifier for automode Pali Rohár
2013-11-19 13:24 ` Pavel Machek
2013-12-24 1:58 ` Anton Vorontsov
2013-11-24 17:00 ` Sebastian Reichel
2013-11-24 19:01 ` Pali Rohár
2013-11-24 19:26 ` Sebastian Reichel
2013-11-24 19:41 ` Pali Rohár
2013-11-24 21:00 ` Sebastian Reichel
2013-11-25 14:01 ` Pavel Machek
2013-11-25 14:10 ` Pali Rohár
2013-11-25 15:18 ` Pavel Machek
2013-11-25 18:52 ` Pali Rohár
2013-11-24 17:18 ` Michael Trimarchi
2013-11-24 17:18 ` Michael Trimarchi
2013-11-24 19:01 ` Pali Rohár
2013-11-25 19:16 ` Michael Trimarchi
2013-11-25 19:16 ` Michael Trimarchi
2013-12-01 22:37 ` Anton Vorontsov
2013-12-02 0:02 ` Michael Trimarchi
2013-12-02 0:24 ` Anton Vorontsov
2013-12-02 1:45 ` Michael Trimarchi
2014-01-19 20:54 ` Sebastian Reichel
2014-01-19 20:56 ` Michael Trimarchi
2014-01-20 10:21 ` Russell King - ARM Linux
2014-01-20 11:24 ` Sebastian Reichel
2013-12-06 13:32 ` Pali Rohár
2013-11-19 10:18 ` [PATCH v2 3/3] RX-51: Add platform data for bq24150a charger Pali Rohár
2013-11-19 13:32 ` Pavel Machek
2013-11-24 10:28 ` Pali Rohár
2013-11-19 14:44 ` [PATCH v2 0/3] Add support for charging battery in Nokia RX-51 Sebastian Reichel
2013-11-19 15:40 ` Tony Lindgren
2013-11-19 21:38 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309241905.48301@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=freemangordon@abv.bg \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.