* [ANNOUNCE] 3.10.10-rt7
@ 2013-08-29 18:42 Sebastian Andrzej Siewior
2013-08-30 10:32 ` Bernhard Schiffner
2013-08-30 17:16 ` Kirill Tkhai
0 siblings, 2 replies; 8+ messages in thread
From: Sebastian Andrzej Siewior @ 2013-08-29 18:42 UTC (permalink / raw)
To: linux-rt-users; +Cc: LKML, Thomas Gleixner, rostedt, John Kacur
Dear RT folks!
I'm pleased to announce the v3.10.10-rt7 patch set.
Changes since v3.10.10-rt6
- hwlat compiles on 32bit (again). Reported by Fernando Lopez-Lezcano.
- bcache is disabled due to usage of anon semaphores. Anyone interrested
in using it?
- "genirq affinity callback" are fixed. Reported by Joe Korty. There are
two nics using this feature.
- Paul Gortmaker's swait rename patch has been included.
Known issues:
- SLAB support not working
- The cpsw network driver shows some issues.
- bcache is disabled.
- an ancient race (since we got sleeping spinlocks) where the
TASK_TRACED state is temporary replaced while waiting on a rw
lock and the task can't be traced.
The delta patch against v3.10.10-rt6 is appended below and can be found
here:
https://www.kernel.org/pub/linux/kernel/projects/rt/3.10/incr/patch-3.10.10-rt6-rt7.patch.xz
The RT patch against 3.10.10 can be found here:
https://www.kernel.org/pub/linux/kernel/projects/rt/3.10/patch-3.10.10-rt7.patch.xz
The split quilt queue is available at:
https://www.kernel.org/pub/linux/kernel/projects/rt/3.10/patches-3.10.10-rt7.tar.xz
Sebastian
diff --git a/drivers/md/bcache/Kconfig b/drivers/md/bcache/Kconfig
index f950c9d..5eb76dd 100644
--- a/drivers/md/bcache/Kconfig
+++ b/drivers/md/bcache/Kconfig
@@ -1,6 +1,7 @@
config BCACHE
tristate "Block device as cache"
+ depends on !PREEMPT_RT_FULL
---help---
Allows a block device to be used as cache for other devices; uses
a btree for indexing and the layout is optimized for SSDs.
diff --git a/drivers/misc/hwlat_detector.c b/drivers/misc/hwlat_detector.c
index 0bfa40d..6f61d5f 100644
--- a/drivers/misc/hwlat_detector.c
+++ b/drivers/misc/hwlat_detector.c
@@ -220,7 +220,7 @@ static struct sample *buffer_get_sample(struct sample *sample)
#else
#define time_type u64
#define time_get() trace_clock_local()
-#define time_to_us(x) ((x) / 1000)
+#define time_to_us(x) div_u64(x, 1000)
#define time_sub(a, b) ((a) - (b))
#define init_time(a, b) a = b
#define time_u64(a) a
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 11bdb1e..838d4bd 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -263,6 +263,7 @@ struct irq_affinity_notify {
unsigned int irq;
struct kref kref;
struct work_struct work;
+ struct list_head list;
void (*notify)(struct irq_affinity_notify *, const cpumask_t *mask);
void (*release)(struct kref *ref);
};
diff --git a/include/linux/wait-simple.h b/include/linux/wait-simple.h
index 4efba4d..f86bca2 100644
--- a/include/linux/wait-simple.h
+++ b/include/linux/wait-simple.h
@@ -47,6 +47,14 @@ extern void swait_prepare(struct swait_head *head, struct swaiter *w, int state)
extern void swait_finish_locked(struct swait_head *head, struct swaiter *w);
extern void swait_finish(struct swait_head *head, struct swaiter *w);
+/* Check whether a head has waiters enqueued */
+static inline bool swaitqueue_active(struct swait_head *h)
+{
+ /* Make sure the condition is visible before checking list_empty() */
+ smp_mb();
+ return !list_empty(&h->list);
+}
+
/*
* Wakeup functions
*/
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 0e34a98..c5c19ec 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -164,6 +164,62 @@ int irq_do_set_affinity(struct irq_data *data, const struct cpumask *mask,
return ret;
}
+#ifdef CONFIG_PREEMPT_RT_FULL
+static void _irq_affinity_notify(struct irq_affinity_notify *notify);
+static struct task_struct *set_affinity_helper;
+static LIST_HEAD(affinity_list);
+static DEFINE_RAW_SPINLOCK(affinity_list_lock);
+
+static int set_affinity_thread(void *unused)
+{
+ while (1) {
+ struct irq_affinity_notify *notify;
+ int empty;
+
+ set_current_state(TASK_INTERRUPTIBLE);
+
+ raw_spin_lock_irq(&affinity_list_lock);
+ empty = list_empty(&affinity_list);
+ raw_spin_unlock_irq(&affinity_list_lock);
+
+ if (empty)
+ schedule();
+ if (kthread_should_stop())
+ break;
+ set_current_state(TASK_RUNNING);
+try_next:
+ notify = NULL;
+
+ raw_spin_lock_irq(&affinity_list_lock);
+ if (!list_empty(&affinity_list)) {
+ notify = list_first_entry(&affinity_list,
+ struct irq_affinity_notify, list);
+ list_del_init(¬ify->list);
+ }
+ raw_spin_unlock_irq(&affinity_list_lock);
+
+ if (!notify)
+ continue;
+ _irq_affinity_notify(notify);
+ goto try_next;
+ }
+ return 0;
+}
+
+static void init_helper_thread(void)
+{
+ if (set_affinity_helper)
+ return;
+ set_affinity_helper = kthread_run(set_affinity_thread, NULL,
+ "affinity-cb");
+ WARN_ON(IS_ERR(set_affinity_helper));
+}
+#else
+
+static inline void init_helper_thread(void) { }
+
+#endif
+
int __irq_set_affinity_locked(struct irq_data *data, const struct cpumask *mask)
{
struct irq_chip *chip = irq_data_get_irq_chip(data);
@@ -182,7 +238,17 @@ int __irq_set_affinity_locked(struct irq_data *data, const struct cpumask *mask)
if (desc->affinity_notify) {
kref_get(&desc->affinity_notify->kref);
+
+#ifdef CONFIG_PREEMPT_RT_FULL
+ raw_spin_lock(&affinity_list_lock);
+ if (list_empty(&desc->affinity_notify->list))
+ list_add_tail(&affinity_list,
+ &desc->affinity_notify->list);
+ raw_spin_unlock(&affinity_list_lock);
+ wake_up_process(set_affinity_helper);
+#else
schedule_work(&desc->affinity_notify->work);
+#endif
}
irqd_set(data, IRQD_AFFINITY_SET);
@@ -223,10 +289,8 @@ int irq_set_affinity_hint(unsigned int irq, const struct cpumask *m)
}
EXPORT_SYMBOL_GPL(irq_set_affinity_hint);
-static void irq_affinity_notify(struct work_struct *work)
+static void _irq_affinity_notify(struct irq_affinity_notify *notify)
{
- struct irq_affinity_notify *notify =
- container_of(work, struct irq_affinity_notify, work);
struct irq_desc *desc = irq_to_desc(notify->irq);
cpumask_var_t cpumask;
unsigned long flags;
@@ -248,6 +312,13 @@ static void irq_affinity_notify(struct work_struct *work)
kref_put(¬ify->kref, notify->release);
}
+static void irq_affinity_notify(struct work_struct *work)
+{
+ struct irq_affinity_notify *notify =
+ container_of(work, struct irq_affinity_notify, work);
+ _irq_affinity_notify(notify);
+}
+
/**
* irq_set_affinity_notifier - control notification of IRQ affinity changes
* @irq: Interrupt for which to enable/disable notification
@@ -277,6 +348,8 @@ irq_set_affinity_notifier(unsigned int irq, struct irq_affinity_notify *notify)
notify->irq = irq;
kref_init(¬ify->kref);
INIT_WORK(¬ify->work, irq_affinity_notify);
+ INIT_LIST_HEAD(¬ify->list);
+ init_helper_thread();
}
raw_spin_lock_irqsave(&desc->lock, flags);
diff --git a/kernel/wait-simple.c b/kernel/wait-simple.c
index 2c85626..7dfa86d 100644
--- a/kernel/wait-simple.c
+++ b/kernel/wait-simple.c
@@ -26,14 +26,6 @@ static inline void __swait_dequeue(struct swaiter *w)
list_del_init(&w->node);
}
-/* Check whether a head has waiters enqueued */
-static inline bool swait_head_has_waiters(struct swait_head *h)
-{
- /* Make sure the condition is visible before checking list_empty() */
- smp_mb();
- return !list_empty(&h->list);
-}
-
void __init_swait_head(struct swait_head *head, struct lock_class_key *key)
{
raw_spin_lock_init(&head->lock);
@@ -112,7 +104,7 @@ __swait_wake(struct swait_head *head, unsigned int state, unsigned int num)
unsigned long flags;
int woken;
- if (!swait_head_has_waiters(head))
+ if (!swaitqueue_active(head))
return 0;
raw_spin_lock_irqsave(&head->lock, flags);
diff --git a/localversion-rt b/localversion-rt
index 8fc605d..0454789 100644
--- a/localversion-rt
+++ b/localversion-rt
@@ -1 +1 @@
--rt6
+-rt7
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [ANNOUNCE] 3.10.10-rt7
2013-08-29 18:42 [ANNOUNCE] 3.10.10-rt7 Sebastian Andrzej Siewior
@ 2013-08-30 10:32 ` Bernhard Schiffner
2013-10-04 18:34 ` Sebastian Andrzej Siewior
2013-08-30 17:16 ` Kirill Tkhai
1 sibling, 1 reply; 8+ messages in thread
From: Bernhard Schiffner @ 2013-08-30 10:32 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: linux-rt-users
> Dear RT folks!
>
> I'm pleased to announce the v3.10.10-rt7 patch set.
>
> Changes since v3.10.10-rt6
> - hwlat compiles on 32bit (again). Reported by Fernando Lopez-Lezcano.
> - bcache is disabled due to usage of anon semaphores. Anyone interrested
> in using it?
> - "genirq affinity callback" are fixed. Reported by Joe Korty. There are
> two nics using this feature.
> - Paul Gortmaker's swait rename patch has been included.
>
> Known issues:
>
> - SLAB support not working
>
> - The cpsw network driver shows some issues.
>
> - bcache is disabled.
>
> - an ancient race (since we got sleeping spinlocks) where the
> TASK_TRACED state is temporary replaced while waiting on a rw
> lock and the task can't be traced.
>
> The delta patch against v3.10.10-rt6 is appended below and can be found
> here:
>
> https://www.kernel.org/pub/linux/kernel/projects/rt/3.10/incr/patch-3.10.10
> -rt6-rt7.patch.xz
>
> The RT patch against 3.10.10 can be found here:
>
>
> https://www.kernel.org/pub/linux/kernel/projects/rt/3.10/patch-3.10.10-rt7.
> patch.xz
>
> The split quilt queue is available at:
>
>
> https://www.kernel.org/pub/linux/kernel/projects/rt/3.10/patches-3.10.10-rt
> 7.tar.xz
>
> Sebastian
Just for the records:
older, but recent rt-kernels (3.10.*, rt [1,3]) stopped booting here
indicating some problems with initialisation of the nouveau drm driver.
(might also be a PCI-E problem)
This was not the case with 3.8.*-rt*.
The problem gone with 3.10.10-rt7 tested today.
A lot of thanks!
Bernhard
PS:
Would it be much work to activate netconsole with rt-kernels?
(I was ready to send some "real screenshots" of the probelm next days, but
the problem gone :-) )
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ANNOUNCE] 3.10.10-rt7
2013-08-30 10:32 ` Bernhard Schiffner
@ 2013-10-04 18:34 ` Sebastian Andrzej Siewior
0 siblings, 0 replies; 8+ messages in thread
From: Sebastian Andrzej Siewior @ 2013-10-04 18:34 UTC (permalink / raw)
To: Bernhard Schiffner; +Cc: linux-rt-users
* Bernhard Schiffner | 2013-08-30 12:32:48 [+0200]:
>Just for the records:
>
>older, but recent rt-kernels (3.10.*, rt [1,3]) stopped booting here
>indicating some problems with initialisation of the nouveau drm driver.
>(might also be a PCI-E problem)
>
>This was not the case with 3.8.*-rt*.
>The problem gone with 3.10.10-rt7 tested today.
In that case it was probably fixed by the stable series.
>A lot of thanks!
>
>
>Bernhard
>
>PS:
>Would it be much work to activate netconsole with rt-kernels?
>(I was ready to send some "real screenshots" of the probelm next days, but
>the problem gone :-) )
You could enable and check what explodes. I would assume the problem is
somewhere around write_msg() :)
Sebastian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ANNOUNCE] 3.10.10-rt7
2013-08-29 18:42 [ANNOUNCE] 3.10.10-rt7 Sebastian Andrzej Siewior
2013-08-30 10:32 ` Bernhard Schiffner
@ 2013-08-30 17:16 ` Kirill Tkhai
2013-10-04 12:27 ` Sebastian Andrzej Siewior
1 sibling, 1 reply; 8+ messages in thread
From: Kirill Tkhai @ 2013-08-30 17:16 UTC (permalink / raw)
To: Sebastian Andrzej Siewior, linux-rt-users
29.08.2013, 22:42, "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>:
> Dear RT folks!
>
> I'm pleased to announce the v3.10.10-rt7 patch set.
>
> Changes since v3.10.10-rt6
> - hwlat compiles on 32bit (again). Reported by Fernando Lopez-Lezcano.
> - bcache is disabled due to usage of anon semaphores. Anyone interrested
> in using it?
> - "genirq affinity callback" are fixed. Reported by Joe Korty. There are
> two nics using this feature.
> - Paul Gortmaker's swait rename patch has been included.
sparc does not have CONFIG_EARLY_PRINTK option.
So early-printk-consolidate.patch breaks compilation:
arch/sparc/built-in.o: In function `setup_arch':
(.init.text+0x15e4): undefined reference to `early_console'
arch/sparc/built-in.o: In function `setup_arch':
(.init.text+0x15ec): undefined reference to `early_console'
The below addition fixes that.
Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
---
arch/sparc/Kconfig | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index 9ac9f16..6787bd3 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -521,6 +521,10 @@ menu "Executable file formats"
source "fs/Kconfig.binfmt"
+config EARLY_PRINTK
+ bool
+ default y
+
config COMPAT
bool
depends on SPARC64
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [ANNOUNCE] 3.10.10-rt7
2013-08-30 17:16 ` Kirill Tkhai
@ 2013-10-04 12:27 ` Sebastian Andrzej Siewior
2013-10-04 12:57 ` Kirill Tkhai
0 siblings, 1 reply; 8+ messages in thread
From: Sebastian Andrzej Siewior @ 2013-10-04 12:27 UTC (permalink / raw)
To: Kirill Tkhai; +Cc: linux-rt-users
* Kirill Tkhai | 2013-08-30 21:16:08 [+0400]:
>sparc does not have CONFIG_EARLY_PRINTK option.
>
>So early-printk-consolidate.patch breaks compilation:
>
>arch/sparc/built-in.o: In function `setup_arch':
>(.init.text+0x15e4): undefined reference to `early_console'
>arch/sparc/built-in.o: In function `setup_arch':
>(.init.text+0x15ec): undefined reference to `early_console'
that is true and I applied that patch, thanks.
However with this alone you do not have a working RT on Sparc because
you can't select "Fully Preemptible Kernel (RT)" only the "basic" system
is available.
Sebastian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ANNOUNCE] 3.10.10-rt7
2013-10-04 12:27 ` Sebastian Andrzej Siewior
@ 2013-10-04 12:57 ` Kirill Tkhai
2013-10-04 13:05 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 8+ messages in thread
From: Kirill Tkhai @ 2013-10-04 12:57 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: linux-rt-users
04.10.2013, 16:27, "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>:
> * Kirill Tkhai | 2013-08-30 21:16:08 [+0400]:
>
>> sparc does not have CONFIG_EARLY_PRINTK option.
>>
>> So early-printk-consolidate.patch breaks compilation:
>>
>> arch/sparc/built-in.o: In function `setup_arch':
>> (.init.text+0x15e4): undefined reference to `early_console'
>> arch/sparc/built-in.o: In function `setup_arch':
>> (.init.text+0x15ec): undefined reference to `early_console'
>
> that is true and I applied that patch, thanks.
> However with this alone you do not have a working RT on Sparc because
> you can't select "Fully Preemptible Kernel (RT)" only the "basic" system
> is available.
Yes, I now. I added IRQ_FORCED_THREADING to Kconfig. My hardware
requires additional changes at arch/sparc and it's in a process of porting
on 3.10 so I can't say if everything works on sparc or not yet.
The other required fix to make sparc64 compilable is deletion of rwsem leftovers.
I sent it to mainline sparc:
https://git.kernel.org/cgit/linux/kernel/git/davem/sparc.git/commit/arch/sparc?id=61d9b9355b0d427bd1e732bd54628ff9103e496f
It seems it's resonable to add it to the patch too.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ANNOUNCE] 3.10.10-rt7
2013-10-04 12:57 ` Kirill Tkhai
@ 2013-10-04 13:05 ` Sebastian Andrzej Siewior
2013-10-04 13:11 ` Kirill Tkhai
0 siblings, 1 reply; 8+ messages in thread
From: Sebastian Andrzej Siewior @ 2013-10-04 13:05 UTC (permalink / raw)
To: Kirill Tkhai; +Cc: linux-rt-users
On 10/04/2013 02:57 PM, Kirill Tkhai wrote:
> Yes, I now. I added IRQ_FORCED_THREADING to Kconfig. My hardware
> requires additional changes at arch/sparc and it's in a process of porting
> on 3.10 so I can't say if everything works on sparc or not yet.
So if you marked NMIs and so as non-threaded you can send this patch to
Dave, too :)
> The other required fix to make sparc64 compilable is deletion of rwsem leftovers.
> I sent it to mainline sparc:
>
> https://git.kernel.org/cgit/linux/kernel/git/davem/sparc.git/commit/arch/sparc?id=61d9b9355b0d427bd1e732bd54628ff9103e496f
>
> It seems it's resonable to add it to the patch too.
Since it is queued for mainline let me make your life easier and pick
it up for -RT, too.
Sebastian
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ANNOUNCE] 3.10.10-rt7
2013-10-04 13:05 ` Sebastian Andrzej Siewior
@ 2013-10-04 13:11 ` Kirill Tkhai
0 siblings, 0 replies; 8+ messages in thread
From: Kirill Tkhai @ 2013-10-04 13:11 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: linux-rt-users
04.10.2013, 17:05, "Sebastian Andrzej Siewior" <bigeasy@linutronix.de>:
> On 10/04/2013 02:57 PM, Kirill Tkhai wrote:
>
>> Yes, I now. I added IRQ_FORCED_THREADING to Kconfig. My hardware
>> requires additional changes at arch/sparc and it's in a process of porting
>> on 3.10 so I can't say if everything works on sparc or not yet.
>
> So if you marked NMIs and so as non-threaded you can send this patch to
> Dave, too :)
It's not standard interrupt controller, so it's useless for mainline. It maybe,
later we'll go to upstream, not ready for now.
>> The other required fix to make sparc64 compilable is deletion of rwsem leftovers.
>> I sent it to mainline sparc:
>>
>> https://git.kernel.org/cgit/linux/kernel/git/davem/sparc.git/commit/arch/sparc?id=61d9b9355b0d427bd1e732bd54628ff9103e496f
>>
>> It seems it's resonable to add it to the patch too.
>
> Since it is queued for mainline let me make your life easier and pick
> it up for -RT, too.
Ok, thanks :)
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-10-04 18:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-29 18:42 [ANNOUNCE] 3.10.10-rt7 Sebastian Andrzej Siewior
2013-08-30 10:32 ` Bernhard Schiffner
2013-10-04 18:34 ` Sebastian Andrzej Siewior
2013-08-30 17:16 ` Kirill Tkhai
2013-10-04 12:27 ` Sebastian Andrzej Siewior
2013-10-04 12:57 ` Kirill Tkhai
2013-10-04 13:05 ` Sebastian Andrzej Siewior
2013-10-04 13:11 ` Kirill Tkhai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.