* [PATCH v2 3/5] kconfig: adjust warning message for conflicting types
@ 2013-10-03 17:24 Martin Walch
2013-10-04 14:25 ` Wang YanQing
0 siblings, 1 reply; 2+ messages in thread
From: Martin Walch @ 2013-10-03 17:24 UTC (permalink / raw)
To: linux-kbuild
Cc: Michal Marek, Arve Hjønnevåg, Jiri Kosina,
Yann E. MORIN, Benjamin Poirier, Dirk Gouders, Wang YanQing,
Andrew Morton, Jean Delvare, Kees Cook, linux-kernel
From: Martin Walch <walch.martin@web.de>
Date: Thu, 3 Oct 2013 18:32:02 +0200
Subject: [PATCH v2 3/5] kconfig: adjust warning message for conflicting types
Each symbol must have exactly one type assigned. However, if a symbol happens
to have two different types assigned at runtime, a warning is printed and the
first type is preserved while the second type is being ignored.
The warning message says
type of <symbol name> redefined from <first type> to <second type>
which may be misleading as it may create the impression that the second type
replaces the first type.
This patch clarifies this by changing the warning to
ignoring type redefinition of <symbol name> from <first type> to <second type>
Signed-off-by: Martin Walch <walch.martin@web.de>
---
| 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index b970101..9e69f19 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -119,9 +119,10 @@ void menu_set_type(int type)
sym->type = type;
return;
}
- menu_warn(current_entry, "type of '%s' redefined from '%s' to '%s'",
- sym->name ? sym->name : "<choice>",
- sym_type_name(sym->type), sym_type_name(type));
+ menu_warn(current_entry,
+ "ignoring type redefinition of '%s' from '%s' to '%s'",
+ sym->name ? sym->name : "<choice>",
+ sym_type_name(sym->type), sym_type_name(type));
}
struct property *menu_add_prop(enum prop_type type, char *prompt, struct expr *expr, struct expr *dep)
--
1.8.1.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 3/5] kconfig: adjust warning message for conflicting types
2013-10-03 17:24 [PATCH v2 3/5] kconfig: adjust warning message for conflicting types Martin Walch
@ 2013-10-04 14:25 ` Wang YanQing
0 siblings, 0 replies; 2+ messages in thread
From: Wang YanQing @ 2013-10-04 14:25 UTC (permalink / raw)
To: Martin Walch
Cc: linux-kbuild, Michal Marek, Arve Hjønnevåg,
Jiri Kosina, Yann E. MORIN, Benjamin Poirier, Dirk Gouders,
Andrew Morton, Jean Delvare, Kees Cook, linux-kernel
On Thu, Oct 03, 2013 at 07:24:46PM +0200, Martin Walch wrote:
> From: Martin Walch <walch.martin@web.de>
> Date: Thu, 3 Oct 2013 18:32:02 +0200
> Subject: [PATCH v2 3/5] kconfig: adjust warning message for conflicting types
>
> Each symbol must have exactly one type assigned. However, if a symbol happens
> to have two different types assigned at runtime, a warning is printed and the
> first type is preserved while the second type is being ignored.
>
> The warning message says
>
> type of <symbol name> redefined from <first type> to <second type>
>
> which may be misleading as it may create the impression that the second type
> replaces the first type.
>
> This patch clarifies this by changing the warning to
>
> ignoring type redefinition of <symbol name> from <first type> to <second type>
>
> Signed-off-by: Martin Walch <walch.martin@web.de>
Acked-by: Wang YanQing <udknight@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-04 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-03 17:24 [PATCH v2 3/5] kconfig: adjust warning message for conflicting types Martin Walch
2013-10-04 14:25 ` Wang YanQing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.