* [PATCH] slab+rt: Don't free locks twice in cpuup_canceled
@ 2013-09-20 18:02 minyard
2013-09-25 16:37 ` Corey Minyard
0 siblings, 1 reply; 4+ messages in thread
From: minyard @ 2013-09-20 18:02 UTC (permalink / raw)
To: linux-rt-users; +Cc: Corey Minyard
From: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Corey Minyard <cminyard@cavium.com>
---
mm/slab.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/slab.c b/mm/slab.c
index 494274e..0a3d6d3 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -1270,7 +1270,6 @@ static void __cpuinit cpuup_canceled(long cpu)
free_block(cachep, nc->entry, nc->avail, node);
if (!cpumask_empty(mask)) {
- local_spin_unlock_irq(slab_lock, &n->list_lock);
unlock_l3_and_free_delayed(&n->list_lock);
goto free_array_cache;
}
@@ -1285,7 +1284,6 @@ static void __cpuinit cpuup_canceled(long cpu)
alien = n->alien;
n->alien = NULL;
- local_spin_unlock_irq(slab_lock, &n->list_lock);
unlock_l3_and_free_delayed(&n->list_lock);
kfree(shared);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] slab+rt: Don't free locks twice in cpuup_canceled
2013-09-20 18:02 [PATCH] slab+rt: Don't free locks twice in cpuup_canceled minyard
@ 2013-09-25 16:37 ` Corey Minyard
2013-10-04 14:49 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 4+ messages in thread
From: Corey Minyard @ 2013-09-25 16:37 UTC (permalink / raw)
To: linux-rt-users
I forgot to mention that this was on 3.10.10-rt7.
-corey
On 09/20/2013 01:02 PM, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> Signed-off-by: Corey Minyard <cminyard@cavium.com>
> ---
> mm/slab.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index 494274e..0a3d6d3 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1270,7 +1270,6 @@ static void __cpuinit cpuup_canceled(long cpu)
> free_block(cachep, nc->entry, nc->avail, node);
>
> if (!cpumask_empty(mask)) {
> - local_spin_unlock_irq(slab_lock, &n->list_lock);
> unlock_l3_and_free_delayed(&n->list_lock);
> goto free_array_cache;
> }
> @@ -1285,7 +1284,6 @@ static void __cpuinit cpuup_canceled(long cpu)
> alien = n->alien;
> n->alien = NULL;
>
> - local_spin_unlock_irq(slab_lock, &n->list_lock);
> unlock_l3_and_free_delayed(&n->list_lock);
>
> kfree(shared);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] slab+rt: Don't free locks twice in cpuup_canceled
2013-09-25 16:37 ` Corey Minyard
@ 2013-10-04 14:49 ` Sebastian Andrzej Siewior
2013-10-04 16:10 ` Corey Minyard
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2013-10-04 14:49 UTC (permalink / raw)
To: Corey Minyard; +Cc: linux-rt-users
* Corey Minyard | 2013-09-25 11:37:06 [-0500]:
>I forgot to mention that this was on 3.10.10-rt7.
This looks valid. But SLAB still isn't working on -RT, right?
>-corey
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] slab+rt: Don't free locks twice in cpuup_canceled
2013-10-04 14:49 ` Sebastian Andrzej Siewior
@ 2013-10-04 16:10 ` Corey Minyard
0 siblings, 0 replies; 4+ messages in thread
From: Corey Minyard @ 2013-10-04 16:10 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: Corey Minyard, linux-rt-users
On 10/04/2013 09:49 AM, Sebastian Andrzej Siewior wrote:
> * Corey Minyard | 2013-09-25 11:37:06 [-0500]:
>
>> I forgot to mention that this was on 3.10.10-rt7.
> This looks valid. But SLAB still isn't working on -RT, right?
>
AFAIK SLAB is still not working on RT, but this breaks things if you
have RT disabled.
-corey
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-04 16:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-20 18:02 [PATCH] slab+rt: Don't free locks twice in cpuup_canceled minyard
2013-09-25 16:37 ` Corey Minyard
2013-10-04 14:49 ` Sebastian Andrzej Siewior
2013-10-04 16:10 ` Corey Minyard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.