* [PATCH] veth: allow to setup multicast address for veth device
@ 2013-10-04 8:52 Gao feng
2013-10-09 8:58 ` Gao feng
2013-10-10 4:16 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Gao feng @ 2013-10-04 8:52 UTC (permalink / raw)
To: netdev; +Cc: pablo, davem, edumazet, kaber, hannes, Gao feng
We can only setup multicast address for network device when
net_device_ops->ndo_set_rx_mode is not null.
Some configurations need to add multicast address for net
device, such as netfilter cluster match module.
Add a fake ndo_set_rx_mode function to allow this operation.
Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
---
drivers/net/veth.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index eee1f19..b2d0347 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -188,6 +188,11 @@ static struct rtnl_link_stats64 *veth_get_stats64(struct net_device *dev,
return tot;
}
+/* fake multicast ability */
+static void veth_set_multicast_list(struct net_device *dev)
+{
+}
+
static int veth_open(struct net_device *dev)
{
struct veth_priv *priv = netdev_priv(dev);
@@ -250,6 +255,7 @@ static const struct net_device_ops veth_netdev_ops = {
.ndo_start_xmit = veth_xmit,
.ndo_change_mtu = veth_change_mtu,
.ndo_get_stats64 = veth_get_stats64,
+ .ndo_set_rx_mode = veth_set_multicast_list,
.ndo_set_mac_address = eth_mac_addr,
};
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] veth: allow to setup multicast address for veth device
2013-10-04 8:52 [PATCH] veth: allow to setup multicast address for veth device Gao feng
@ 2013-10-09 8:58 ` Gao feng
2013-10-09 17:22 ` David Miller
2013-10-10 4:16 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Gao feng @ 2013-10-09 8:58 UTC (permalink / raw)
To: davem; +Cc: Gao feng, netdev, pablo, edumazet, kaber, hannes
Hi David,
On 10/04/2013 04:52 PM, Gao feng wrote:
> We can only setup multicast address for network device when
> net_device_ops->ndo_set_rx_mode is not null.
>
> Some configurations need to add multicast address for net
> device, such as netfilter cluster match module.
>
> Add a fake ndo_set_rx_mode function to allow this operation.
>
> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
I see this patch being marked as "Changes Requested" on patchwork.
Is there something I missed?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] veth: allow to setup multicast address for veth device
2013-10-09 8:58 ` Gao feng
@ 2013-10-09 17:22 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2013-10-09 17:22 UTC (permalink / raw)
To: gaofeng; +Cc: netdev, pablo, edumazet, kaber, hannes
From: Gao feng <gaofeng@cn.fujitsu.com>
Date: Wed, 09 Oct 2013 16:58:37 +0800
> Hi David,
>
> On 10/04/2013 04:52 PM, Gao feng wrote:
>> We can only setup multicast address for network device when
>> net_device_ops->ndo_set_rx_mode is not null.
>>
>> Some configurations need to add multicast address for net
>> device, such as netfilter cluster match module.
>>
>> Add a fake ndo_set_rx_mode function to allow this operation.
>>
>> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
>
> I see this patch being marked as "Changes Requested" on patchwork.
> Is there something I missed?
It was a mistake, I put it back in Under Review.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] veth: allow to setup multicast address for veth device
2013-10-04 8:52 [PATCH] veth: allow to setup multicast address for veth device Gao feng
2013-10-09 8:58 ` Gao feng
@ 2013-10-10 4:16 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2013-10-10 4:16 UTC (permalink / raw)
To: gaofeng; +Cc: netdev, pablo, edumazet, kaber, hannes
From: Gao feng <gaofeng@cn.fujitsu.com>
Date: Fri, 4 Oct 2013 16:52:24 +0800
> We can only setup multicast address for network device when
> net_device_ops->ndo_set_rx_mode is not null.
>
> Some configurations need to add multicast address for net
> device, such as netfilter cluster match module.
>
> Add a fake ndo_set_rx_mode function to allow this operation.
>
> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-10 4:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-04 8:52 [PATCH] veth: allow to setup multicast address for veth device Gao feng
2013-10-09 8:58 ` Gao feng
2013-10-09 17:22 ` David Miller
2013-10-10 4:16 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.