From: Wei Liu <wei.liu2@citrix.com>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH QEMU-upstream] Fix build errors when enabling extra logging with #define DEBUG_XEN and #define XEN_PT_LOGGING_ENABLED
Date: Wed, 9 Oct 2013 18:02:00 +0100 [thread overview]
Message-ID: <20131009170200.GQ28411@zion.uk.xensource.com> (raw)
In-Reply-To: <566800526.20131009185841@eikelenboom.it>
On Wed, Oct 09, 2013 at 06:58:41PM +0200, Sander Eikelenboom wrote:
>
> Wednesday, October 9, 2013, 6:56:57 PM, you wrote:
>
> > On Wed, Oct 09, 2013 at 06:34:00PM +0200, Sander Eikelenboom wrote:
> >>
> >> Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
> >> ---
> >> hw/xen/xen_pt.c | 2 +-
> >> xen-all.c | 2 +-
> >> 2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
> >> index ca2d460..3521e36 100644
> >> --- a/hw/xen/xen_pt.c
> >> +++ b/hw/xen/xen_pt.c
> >> @@ -570,7 +570,7 @@ static void xen_pt_region_update(XenPCIPassthroughState *s,
> >> if (args.rc) {
> >> XEN_PT_WARN(d, "Region: %d (addr: %#"FMT_PCIBUS
> >> ", len: %#"FMT_PCIBUS") is overlapped.\n",
> >> - bar, sec->offset_within_address_space, sec->size);
> >> + bar, sec->offset_within_address_space, int128_get64(sec->size));
>
> > Why is this needed? Isn't sec->size of type uint64?
>
> Nope it's uint128 since http://lists.nongnu.org/archive/html/qemu-devel/2013-06/msg03612.html
>
Time to refresh me tree. Thanks! :-)
Wei.
next prev parent reply other threads:[~2013-10-09 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 16:34 [PATCH QEMU-upstream] Fix build errors when enabling extra logging with #define DEBUG_XEN and #define XEN_PT_LOGGING_ENABLED Sander Eikelenboom
2013-10-09 16:56 ` Wei Liu
2013-10-09 16:58 ` Sander Eikelenboom
2013-10-09 17:02 ` Wei Liu [this message]
2013-10-14 12:38 ` Wei Liu
2013-10-14 12:40 ` Sander Eikelenboom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009170200.GQ28411@zion.uk.xensource.com \
--to=wei.liu2@citrix.com \
--cc=linux@eikelenboom.it \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.