All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
	"Rajendra Nayak" <rnayak@ti.com>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: omap4-panda-es: Do not reset gpio1
Date: Thu, 10 Oct 2013 09:47:02 -0700	[thread overview]
Message-ID: <20131010164702.GF29913@atomide.com> (raw)
In-Reply-To: <1381423481-5920-1-git-send-email-nm@ti.com>

* Nishanth Menon <nm@ti.com> [131010 09:53]:
> Do not reset GPIO1 at boot-up because GPIO 7 in GPIO1 block is used on
> OMAP4460 PandaBoard-ES to select voltage register in TPS62361 which
> supplies VDD_MPU.
> 
> Without this, OMAP4460 PandaBoard-ES boards fail to boot-up because
> MPU voltage switches over to VSET0 voltage value (boot voltage) which
> is not sufficient to operate the device at OPP100.

Is this needs as a fix for the -rc series?

Tony
 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> As explained here: http://marc.info/?l=u-boot&m=133066647800872&w=2
> 
> GPIO1 reset causes PandaBoard-ES to stop functioning.
> This depends on Patch series from Rajendra:
> http://marc.info/?l=linux-doc&m=138131355520116&w=2
> Applies on Benoit's for_13/dts branch:
> https://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git/log/?h=for_3.13/dts
> 
> Tested on PandaBoard-ES without the u-boot uenv hack
> 
>  arch/arm/boot/dts/omap4-panda-es.dts |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap4-panda-es.dts b/arch/arm/boot/dts/omap4-panda-es.dts
> index 56c4354..816d1c9 100644
> --- a/arch/arm/boot/dts/omap4-panda-es.dts
> +++ b/arch/arm/boot/dts/omap4-panda-es.dts
> @@ -62,3 +62,7 @@
>  		gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
>  	};
>  };
> +
> +&gpio1 {
> +	 ti,no-reset-on-init;
> +};
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: omap4-panda-es: Do not reset gpio1
Date: Thu, 10 Oct 2013 09:47:02 -0700	[thread overview]
Message-ID: <20131010164702.GF29913@atomide.com> (raw)
In-Reply-To: <1381423481-5920-1-git-send-email-nm@ti.com>

* Nishanth Menon <nm@ti.com> [131010 09:53]:
> Do not reset GPIO1 at boot-up because GPIO 7 in GPIO1 block is used on
> OMAP4460 PandaBoard-ES to select voltage register in TPS62361 which
> supplies VDD_MPU.
> 
> Without this, OMAP4460 PandaBoard-ES boards fail to boot-up because
> MPU voltage switches over to VSET0 voltage value (boot voltage) which
> is not sufficient to operate the device at OPP100.

Is this needs as a fix for the -rc series?

Tony
 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> As explained here: http://marc.info/?l=u-boot&m=133066647800872&w=2
> 
> GPIO1 reset causes PandaBoard-ES to stop functioning.
> This depends on Patch series from Rajendra:
> http://marc.info/?l=linux-doc&m=138131355520116&w=2
> Applies on Benoit's for_13/dts branch:
> https://git.kernel.org/cgit/linux/kernel/git/bcousson/linux-omap-dt.git/log/?h=for_3.13/dts
> 
> Tested on PandaBoard-ES without the u-boot uenv hack
> 
>  arch/arm/boot/dts/omap4-panda-es.dts |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap4-panda-es.dts b/arch/arm/boot/dts/omap4-panda-es.dts
> index 56c4354..816d1c9 100644
> --- a/arch/arm/boot/dts/omap4-panda-es.dts
> +++ b/arch/arm/boot/dts/omap4-panda-es.dts
> @@ -62,3 +62,7 @@
>  		gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
>  	};
>  };
> +
> +&gpio1 {
> +	 ti,no-reset-on-init;
> +};
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2013-10-10 16:47 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09 10:11 [PATCH v2 0/5] OMAP: Add DT bindings to specify when devices should not be idled or reset Rajendra Nayak
2013-10-09 10:11 ` Rajendra Nayak
2013-10-09 10:11 ` [PATCH v2 1/5] ARM: OMAP2+: hwmod: cleanup HWMOD_INIT_NO_RESET usage Rajendra Nayak
2013-10-09 10:11   ` Rajendra Nayak
2013-10-09 14:55   ` Paul Walmsley
2013-10-09 14:55     ` Paul Walmsley
2013-10-09 10:11 ` [PATCH v2 2/5] ARM: dts: omap: Add new bindings for OMAP Rajendra Nayak
2013-10-09 10:11   ` Rajendra Nayak
2013-10-09 15:13   ` Benoit Cousson
2013-10-09 15:13     ` Benoit Cousson
2013-10-09 16:41     ` Rajendra Nayak
2013-10-09 16:41       ` Rajendra Nayak
2013-10-09 16:45       ` Benoit Cousson
2013-10-09 16:45         ` Benoit Cousson
2013-10-15  7:27         ` Benoit Cousson
2013-10-15  7:27           ` Benoit Cousson
2013-10-15  8:23           ` Rajendra Nayak
2013-10-15  8:23             ` Rajendra Nayak
2013-10-09 10:11 ` [PATCH v2 3/5] ARM: OMAP2+: hwmod: Extract no-idle and no-reset info from DT Rajendra Nayak
2013-10-09 10:11   ` Rajendra Nayak
2013-10-09 14:55   ` Paul Walmsley
2013-10-09 14:55     ` Paul Walmsley
2013-10-09 10:12 ` [PATCH v2 4/5] ARM: OMAP2+: hwmod: Cleanup usage of HWMOD_INIT_NO_RESET and HWMOD_INIT_NO_IDLE Rajendra Nayak
2013-10-09 10:12   ` Rajendra Nayak
2013-10-09 10:12 ` [PATCH v2 5/5] ARM: dts: AM335x-evmsk: Do not reset gpio0 Rajendra Nayak
2013-10-09 10:12   ` Rajendra Nayak
2013-10-10 16:44 ` [PATCH] ARM: dts: omap4-panda-es: Do not reset gpio1 Nishanth Menon
2013-10-10 16:44   ` Nishanth Menon
2013-10-10 16:44   ` Nishanth Menon
2013-10-10 16:47   ` Tony Lindgren [this message]
2013-10-10 16:47     ` Tony Lindgren
2013-10-10 19:01     ` Nishanth Menon
2013-10-10 19:01       ` Nishanth Menon
2013-10-10 19:01       ` Nishanth Menon
2013-10-15  7:28   ` Benoit Cousson
2013-10-15  7:28     ` Benoit Cousson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131010164702.GF29913@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.