From: Ingo Molnar <mingo@kernel.org> To: Tim Chen <tim.c.chen@linux.intel.com> Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>, Linus Torvalds <torvalds@linux-foundation.org>, Andrea Arcangeli <aarcange@redhat.com>, Alex Shi <alex.shi@linaro.org>, Andi Kleen <andi@firstfloor.org>, Michel Lespinasse <walken@google.com>, Davidlohr Bueso <davidlohr.bueso@hp.com>, Matthew R Wilcox <matthew.r.wilcox@intel.com>, Dave Hansen <dave.hansen@intel.com>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Rik van Riel <riel@redhat.com>, Peter Hurley <peter@hurleysoftware.com>, "Paul E.McKenney" <paulmck@linux.vnet.ibm.com>, Jason Low <jason.low2@hp.com>, Waiman Long <Waiman.Long@hp.com>, linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org> Subject: Re: [PATCH v8 0/9] rwsem performance optimizations Date: Fri, 18 Oct 2013 08:52:06 +0200 [thread overview] Message-ID: <20131018065206.GA17512@gmail.com> (raw) In-Reply-To: <1381960530.11046.200.camel@schen9-DESK> * Tim Chen <tim.c.chen@linux.intel.com> wrote: > > > > > It would be _really_ nice to stick this into tools/perf/bench/ as: > > > > perf bench mem pagefaults > > > > or so, with a number of parallelism and workload patterns. See > > tools/perf/bench/numa.c for a couple of workload generators - although > > those are not page fault intense. > > > > So that future generations can run all these tests too and such. > > > > > I compare the throughput where I have the complete rwsem patchset > > > against vanilla and the case where I take out the optimistic spin patch. > > > I have increased the run time by 10x from my pervious experiments and do > > > 10 runs for each case. The standard deviation is ~1.5% so any changes > > > under 1.5% is statistically significant. > > > > > > % change in throughput vs the vanilla kernel. > > > Threads all No-optspin > > > 1 +0.4% -0.1% > > > 2 +2.0% +0.2% > > > 3 +1.1% +1.5% > > > 4 -0.5% -1.4% > > > 5 -0.1% -0.1% > > > 10 +2.2% -1.2% > > > 20 +237.3% -2.3% > > > 40 +548.1% +0.3% > > > > The tail is impressive. The early parts are important as well, but it's > > really hard to tell the significance of the early portion without having > > an sttdev column. > > > > ( "perf stat --repeat N" will give you sttdev output, in handy percentage > > form. ) > > Quick naive question as I haven't hacked perf bench before. Btw., please use tip:master, I've got a few cleanups in there that should make it easier to hack. > Now perf stat gives the statistics of the performance counter or events. > How do I get it to compute the stats of > the throughput reported by perf bench? What I do is that I measure the execution time, via: perf stat --null --repeat 10 perf bench ... instead of relying on benchmark output. > Something like > > perf stat -r 10 -- perf bench mm memset --iterations 10 > > doesn't quite give what I need. Yeha. So, perf bench also has a 'simple' output format: comet:~/tip> perf bench -f simple sched pipe 10.378 We could extend 'perf stat' with an option to not measure time, but to take any numeric data output from the executed task and use that as the measurement result. If you'd be interested in such a feature I can give it a try. Thanks, Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org> To: Tim Chen <tim.c.chen@linux.intel.com> Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>, Linus Torvalds <torvalds@linux-foundation.org>, Andrea Arcangeli <aarcange@redhat.com>, Alex Shi <alex.shi@linaro.org>, Andi Kleen <andi@firstfloor.org>, Michel Lespinasse <walken@google.com>, Davidlohr Bueso <davidlohr.bueso@hp.com>, Matthew R Wilcox <matthew.r.wilcox@intel.com>, Dave Hansen <dave.hansen@intel.com>, Peter Zijlstra <a.p.zijlstra@chello.nl>, Rik van Riel <riel@redhat.com>, Peter Hurley <peter@hurleysoftware.com>, "Paul E.McKenney" <paulmck@linux.vnet.ibm.com>, Jason Low <jason.low2@hp.com>, Waiman Long <Waiman.Long@hp.com>, linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org> Subject: Re: [PATCH v8 0/9] rwsem performance optimizations Date: Fri, 18 Oct 2013 08:52:06 +0200 [thread overview] Message-ID: <20131018065206.GA17512@gmail.com> (raw) In-Reply-To: <1381960530.11046.200.camel@schen9-DESK> * Tim Chen <tim.c.chen@linux.intel.com> wrote: > > > > > It would be _really_ nice to stick this into tools/perf/bench/ as: > > > > perf bench mem pagefaults > > > > or so, with a number of parallelism and workload patterns. See > > tools/perf/bench/numa.c for a couple of workload generators - although > > those are not page fault intense. > > > > So that future generations can run all these tests too and such. > > > > > I compare the throughput where I have the complete rwsem patchset > > > against vanilla and the case where I take out the optimistic spin patch. > > > I have increased the run time by 10x from my pervious experiments and do > > > 10 runs for each case. The standard deviation is ~1.5% so any changes > > > under 1.5% is statistically significant. > > > > > > % change in throughput vs the vanilla kernel. > > > Threads all No-optspin > > > 1 +0.4% -0.1% > > > 2 +2.0% +0.2% > > > 3 +1.1% +1.5% > > > 4 -0.5% -1.4% > > > 5 -0.1% -0.1% > > > 10 +2.2% -1.2% > > > 20 +237.3% -2.3% > > > 40 +548.1% +0.3% > > > > The tail is impressive. The early parts are important as well, but it's > > really hard to tell the significance of the early portion without having > > an sttdev column. > > > > ( "perf stat --repeat N" will give you sttdev output, in handy percentage > > form. ) > > Quick naive question as I haven't hacked perf bench before. Btw., please use tip:master, I've got a few cleanups in there that should make it easier to hack. > Now perf stat gives the statistics of the performance counter or events. > How do I get it to compute the stats of > the throughput reported by perf bench? What I do is that I measure the execution time, via: perf stat --null --repeat 10 perf bench ... instead of relying on benchmark output. > Something like > > perf stat -r 10 -- perf bench mm memset --iterations 10 > > doesn't quite give what I need. Yeha. So, perf bench also has a 'simple' output format: comet:~/tip> perf bench -f simple sched pipe 10.378 We could extend 'perf stat' with an option to not measure time, but to take any numeric data output from the executed task and use that as the measurement result. If you'd be interested in such a feature I can give it a try. Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-10-18 6:52 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <cover.1380748401.git.tim.c.chen@linux.intel.com> 2013-10-02 22:38 ` [PATCH v8 0/9] rwsem performance optimizations Tim Chen 2013-10-02 22:38 ` Tim Chen 2013-10-03 7:32 ` Ingo Molnar 2013-10-03 7:32 ` Ingo Molnar 2013-10-07 22:57 ` Tim Chen 2013-10-07 22:57 ` Tim Chen 2013-10-09 6:15 ` Ingo Molnar 2013-10-09 6:15 ` Ingo Molnar 2013-10-09 7:28 ` Peter Zijlstra 2013-10-09 7:28 ` Peter Zijlstra 2013-10-10 3:14 ` Linus Torvalds 2013-10-10 3:14 ` Linus Torvalds 2013-10-10 5:03 ` Davidlohr Bueso 2013-10-10 5:03 ` Davidlohr Bueso 2013-10-09 16:34 ` Tim Chen 2013-10-09 16:34 ` Tim Chen 2013-10-10 7:54 ` Ingo Molnar 2013-10-10 7:54 ` Ingo Molnar 2013-10-16 0:09 ` Tim Chen 2013-10-16 0:09 ` Tim Chen 2013-10-16 6:55 ` Ingo Molnar 2013-10-16 6:55 ` Ingo Molnar 2013-10-16 18:28 ` Tim Chen 2013-10-16 18:28 ` Tim Chen 2013-11-04 22:36 ` Tim Chen 2013-11-04 22:36 ` Tim Chen 2013-10-16 21:55 ` Tim Chen 2013-10-16 21:55 ` Tim Chen 2013-10-18 6:52 ` Ingo Molnar [this message] 2013-10-18 6:52 ` Ingo Molnar 2013-10-02 22:38 ` [PATCH v8 1/9] rwsem: check the lock before cpmxchg in down_write_trylock Tim Chen 2013-10-02 22:38 ` Tim Chen 2013-10-02 22:38 ` [PATCH v8 2/9] rwsem: remove 'out' label in do_wake Tim Chen 2013-10-02 22:38 ` Tim Chen 2013-10-02 22:38 ` [PATCH v8 3/9] rwsem: remove try_reader_grant label do_wake Tim Chen 2013-10-02 22:38 ` Tim Chen 2013-10-02 22:38 ` [PATCH v8 4/9] rwsem/wake: check lock before do atomic update Tim Chen 2013-10-02 22:38 ` Tim Chen 2013-10-02 22:38 ` [PATCH v8 5/9] MCS Lock: Restructure the MCS lock defines and locking code into its own file Tim Chen 2013-10-02 22:38 ` Tim Chen 2013-10-08 19:51 ` Rafael Aquini 2013-10-08 19:51 ` Rafael Aquini 2013-10-08 20:34 ` Tim Chen 2013-10-08 20:34 ` Tim Chen 2013-10-08 21:31 ` Rafael Aquini 2013-10-08 21:31 ` Rafael Aquini 2013-10-02 22:38 ` [PATCH v8 6/9] MCS Lock: optimizations and extra comments Tim Chen 2013-10-02 22:38 ` Tim Chen 2013-10-02 22:38 ` [PATCH v8 7/9] MCS Lock: Barrier corrections Tim Chen 2013-10-02 22:38 ` Tim Chen 2013-10-02 22:38 ` [PATCH v8 8/9] rwsem: do optimistic spinning for writer lock acquisition Tim Chen 2013-10-02 22:38 ` Tim Chen 2013-10-02 22:38 ` [PATCH v8 9/9] rwsem: reduce spinlock contention in wakeup code path Tim Chen 2013-10-02 22:38 ` Tim Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20131018065206.GA17512@gmail.com \ --to=mingo@kernel.org \ --cc=Waiman.Long@hp.com \ --cc=a.p.zijlstra@chello.nl \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=alex.shi@linaro.org \ --cc=andi@firstfloor.org \ --cc=dave.hansen@intel.com \ --cc=davidlohr.bueso@hp.com \ --cc=jason.low2@hp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=matthew.r.wilcox@intel.com \ --cc=mingo@elte.hu \ --cc=paulmck@linux.vnet.ibm.com \ --cc=peter@hurleysoftware.com \ --cc=riel@redhat.com \ --cc=tim.c.chen@linux.intel.com \ --cc=torvalds@linux-foundation.org \ --cc=walken@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.