* [Qemu-devel] [PULL] QMP queue
@ 2013-10-18 18:30 Luiz Capitulino
2013-10-18 18:30 ` [Qemu-devel] [PULL] monitor: eliminate monitor_event_state_lock Luiz Capitulino
2013-10-29 21:30 ` [Qemu-devel] [PULL] QMP queue Luiz Capitulino
0 siblings, 2 replies; 6+ messages in thread
From: Luiz Capitulino @ 2013-10-18 18:30 UTC (permalink / raw)
To: anthony; +Cc: qemu-devel
The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197:
Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-10-18 10:03:24 -0700)
are available in the git repository at:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
for you to fetch changes up to c20b7fa4b2fedd979bcb0cc974bb5d08a10e3448:
monitor: eliminate monitor_event_state_lock (2013-10-18 14:23:00 -0400)
----------------------------------------------------------------
Paolo Bonzini (1):
monitor: eliminate monitor_event_state_lock
monitor.c | 6 ------
1 file changed, 6 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PULL] monitor: eliminate monitor_event_state_lock
2013-10-18 18:30 [Qemu-devel] [PULL] QMP queue Luiz Capitulino
@ 2013-10-18 18:30 ` Luiz Capitulino
2013-10-29 21:30 ` [Qemu-devel] [PULL] QMP queue Luiz Capitulino
1 sibling, 0 replies; 6+ messages in thread
From: Luiz Capitulino @ 2013-10-18 18:30 UTC (permalink / raw)
To: anthony; +Cc: qemu-devel
From: Paolo Bonzini <pbonzini@redhat.com>
This lock does not protect anything that the BQL does not already
protect. Furthermore, with -nodefaults and no monitor, the mutex
is not initialized but monitor_protocol_event_queue is called
anyway, which causes a crash under mingw (and only works by luck.
under Linux or other POSIX OSes).
Reported-by: Orx Goshen <orx.goshen@intel.com>
Cc: Daniel Berrange <berrange@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
monitor.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index 74f3f1b..0ae99dc 100644
--- a/monitor.c
+++ b/monitor.c
@@ -511,7 +511,6 @@ static const char *monitor_event_names[] = {
QEMU_BUILD_BUG_ON(ARRAY_SIZE(monitor_event_names) != QEVENT_MAX)
MonitorEventState monitor_event_state[QEVENT_MAX];
-QemuMutex monitor_event_state_lock;
/*
* Emits the event to every monitor instance
@@ -543,7 +542,6 @@ monitor_protocol_event_queue(MonitorEvent event,
int64_t now = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
assert(event < QEVENT_MAX);
- qemu_mutex_lock(&monitor_event_state_lock);
evstate = &(monitor_event_state[event]);
trace_monitor_protocol_event_queue(event,
data,
@@ -576,7 +574,6 @@ monitor_protocol_event_queue(MonitorEvent event,
evstate->last = now;
}
}
- qemu_mutex_unlock(&monitor_event_state_lock);
}
@@ -589,7 +586,6 @@ static void monitor_protocol_event_handler(void *opaque)
MonitorEventState *evstate = opaque;
int64_t now = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
- qemu_mutex_lock(&monitor_event_state_lock);
trace_monitor_protocol_event_handler(evstate->event,
evstate->data,
@@ -601,7 +597,6 @@ static void monitor_protocol_event_handler(void *opaque)
evstate->data = NULL;
}
evstate->last = now;
- qemu_mutex_unlock(&monitor_event_state_lock);
}
@@ -638,7 +633,6 @@ monitor_protocol_event_throttle(MonitorEvent event,
* and initialize state */
static void monitor_protocol_event_init(void)
{
- qemu_mutex_init(&monitor_event_state_lock);
/* Limit RTC & BALLOON events to 1 per second */
monitor_protocol_event_throttle(QEVENT_RTC_CHANGE, 1000);
monitor_protocol_event_throttle(QEVENT_BALLOON_CHANGE, 1000);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PULL] QMP queue
2013-10-18 18:30 [Qemu-devel] [PULL] QMP queue Luiz Capitulino
2013-10-18 18:30 ` [Qemu-devel] [PULL] monitor: eliminate monitor_event_state_lock Luiz Capitulino
@ 2013-10-29 21:30 ` Luiz Capitulino
1 sibling, 0 replies; 6+ messages in thread
From: Luiz Capitulino @ 2013-10-29 21:30 UTC (permalink / raw)
To: anthony; +Cc: qemu-devel
On Fri, 18 Oct 2013 14:30:02 -0400
Luiz Capitulino <lcapitulino@redhat.com> wrote:
> The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197:
>
> Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-10-18 10:03:24 -0700)
>
> are available in the git repository at:
>
>
> git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
>
> for you to fetch changes up to c20b7fa4b2fedd979bcb0cc974bb5d08a10e3448:
>
> monitor: eliminate monitor_event_state_lock (2013-10-18 14:23:00 -0400)
>
> ----------------------------------------------------------------
> Paolo Bonzini (1):
> monitor: eliminate monitor_event_state_lock
>
> monitor.c | 6 ------
> 1 file changed, 6 deletions(-)
>
This for 1.7.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PULL] QMP queue
@ 2013-09-10 14:12 Luiz Capitulino
0 siblings, 0 replies; 6+ messages in thread
From: Luiz Capitulino @ 2013-09-10 14:12 UTC (permalink / raw)
To: anthony; +Cc: qemu-devel
The changes (since 94c2b6aff43cdfcfdfb552773a6b6b973a72ef0b) are available
in the following repository:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
Cole Robinson (1):
qapi-types.py: Fix enum struct sizes on i686
scripts/qapi-types.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
1.8.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PULL] QMP queue
2013-06-28 20:43 Luiz Capitulino
@ 2013-07-10 16:53 ` Anthony Liguori
0 siblings, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2013-07-10 16:53 UTC (permalink / raw)
To: Luiz Capitulino, qemu-devel; +Cc: aliguori
Pulled. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PULL] QMP queue
@ 2013-06-28 20:43 Luiz Capitulino
2013-07-10 16:53 ` Anthony Liguori
0 siblings, 1 reply; 6+ messages in thread
From: Luiz Capitulino @ 2013-06-28 20:43 UTC (permalink / raw)
To: qemu-devel; +Cc: aliguori
The following changes since commit 36125631e79d53ffb9365740f43f386e2171d116:
Merge remote-tracking branch 'kwolf/for-anthony' into staging (2013-06-28 10:37:34 -0500)
are available in the git repository at:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
for you to fetch changes up to fbe2e26c15af35e4d157874dc80f6a19eebaa83b:
hmp: Make "info block" output more readable (2013-06-28 16:14:39 -0400)
----------------------------------------------------------------
Kevin Wolf (1):
hmp: Make "info block" output more readable
hmp.c | 94 +++++++++++++++++++++++++++++++++++++++----------------------------
1 file changed, 55 insertions(+), 39 deletions(-)
--
1.8.1.4
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-29 21:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-18 18:30 [Qemu-devel] [PULL] QMP queue Luiz Capitulino
2013-10-18 18:30 ` [Qemu-devel] [PULL] monitor: eliminate monitor_event_state_lock Luiz Capitulino
2013-10-29 21:30 ` [Qemu-devel] [PULL] QMP queue Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2013-09-10 14:12 Luiz Capitulino
2013-06-28 20:43 Luiz Capitulino
2013-07-10 16:53 ` Anthony Liguori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.