All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] watchdog: imx2_wdt: add module device table
@ 2013-10-30 23:57 ` Russell King
  0 siblings, 0 replies; 7+ messages in thread
From: Russell King @ 2013-10-30 23:57 UTC (permalink / raw)
  To: linux-arm-kernel, Sascha Hauer, Shawn Guo
  Cc: Wim Van Sebroeck, linux-watchdog

Add the module device table declaration so the module can be loaded
automatically at boot time.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 drivers/watchdog/imx2_wdt.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
index 693ac3f4de5a..ae1ac198d968 100644
--- a/drivers/watchdog/imx2_wdt.c
+++ b/drivers/watchdog/imx2_wdt.c
@@ -340,3 +340,4 @@ MODULE_DESCRIPTION("Watchdog driver for IMX2 and later");
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
 MODULE_ALIAS("platform:" DRIVER_NAME);
+MODULE_DEVICE_TABLE(of, imx2_wdt_dt_ids);
-- 
1.7.4.4


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] watchdog: imx2_wdt: add module device table
@ 2013-10-30 23:57 ` Russell King
  0 siblings, 0 replies; 7+ messages in thread
From: Russell King @ 2013-10-30 23:57 UTC (permalink / raw)
  To: linux-arm-kernel

Add the module device table declaration so the module can be loaded
automatically at boot time.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 drivers/watchdog/imx2_wdt.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
index 693ac3f4de5a..ae1ac198d968 100644
--- a/drivers/watchdog/imx2_wdt.c
+++ b/drivers/watchdog/imx2_wdt.c
@@ -340,3 +340,4 @@ MODULE_DESCRIPTION("Watchdog driver for IMX2 and later");
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
 MODULE_ALIAS("platform:" DRIVER_NAME);
+MODULE_DEVICE_TABLE(of, imx2_wdt_dt_ids);
-- 
1.7.4.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] watchdog: imx2_wdt: add module device table
  2013-10-30 23:57 ` Russell King
@ 2013-10-31  0:43   ` Guenter Roeck
  -1 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2013-10-31  0:43 UTC (permalink / raw)
  To: Russell King
  Cc: linux-arm-kernel, Sascha Hauer, Shawn Guo, Wim Van Sebroeck,
	linux-watchdog

On Wed, Oct 30, 2013 at 11:57:00PM +0000, Russell King wrote:
> Add the module device table declaration so the module can be loaded
> automatically at boot time.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Hi Russell,

Wim should have this patch in his queue already, as 'watchdog: imx2_wdt:
expose module alias for loading from device-tree', submitted by Niels
de Vos back in July.

Thanks,
Guenter

> ---
>  drivers/watchdog/imx2_wdt.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
> index 693ac3f4de5a..ae1ac198d968 100644
> --- a/drivers/watchdog/imx2_wdt.c
> +++ b/drivers/watchdog/imx2_wdt.c
> @@ -340,3 +340,4 @@ MODULE_DESCRIPTION("Watchdog driver for IMX2 and later");
>  MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
>  MODULE_ALIAS("platform:" DRIVER_NAME);
> +MODULE_DEVICE_TABLE(of, imx2_wdt_dt_ids);
> -- 
> 1.7.4.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] watchdog: imx2_wdt: add module device table
@ 2013-10-31  0:43   ` Guenter Roeck
  0 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2013-10-31  0:43 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Oct 30, 2013 at 11:57:00PM +0000, Russell King wrote:
> Add the module device table declaration so the module can be loaded
> automatically at boot time.
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Hi Russell,

Wim should have this patch in his queue already, as 'watchdog: imx2_wdt:
expose module alias for loading from device-tree', submitted by Niels
de Vos back in July.

Thanks,
Guenter

> ---
>  drivers/watchdog/imx2_wdt.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
> index 693ac3f4de5a..ae1ac198d968 100644
> --- a/drivers/watchdog/imx2_wdt.c
> +++ b/drivers/watchdog/imx2_wdt.c
> @@ -340,3 +340,4 @@ MODULE_DESCRIPTION("Watchdog driver for IMX2 and later");
>  MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR);
>  MODULE_ALIAS("platform:" DRIVER_NAME);
> +MODULE_DEVICE_TABLE(of, imx2_wdt_dt_ids);
> -- 
> 1.7.4.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] watchdog: imx2_wdt: add module device table
  2013-10-31  0:43   ` Guenter Roeck
@ 2013-10-31  0:48     ` Russell King - ARM Linux
  -1 siblings, 0 replies; 7+ messages in thread
From: Russell King - ARM Linux @ 2013-10-31  0:48 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: linux-arm-kernel, Sascha Hauer, Shawn Guo, Wim Van Sebroeck,
	linux-watchdog

On Wed, Oct 30, 2013 at 05:43:38PM -0700, Guenter Roeck wrote:
> On Wed, Oct 30, 2013 at 11:57:00PM +0000, Russell King wrote:
> > Add the module device table declaration so the module can be loaded
> > automatically at boot time.
> > 
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> 
> Hi Russell,
> 
> Wim should have this patch in his queue already, as 'watchdog: imx2_wdt:
> expose module alias for loading from device-tree', submitted by Niels
> de Vos back in July.

Any reason it hasn't made it in yet?  We had a merge window back in
September where, if we're not happy to apply it as a fix during -rc,
it could have gone in.  I see watchdog stuff did merge during the
last merge window...

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] watchdog: imx2_wdt: add module device table
@ 2013-10-31  0:48     ` Russell King - ARM Linux
  0 siblings, 0 replies; 7+ messages in thread
From: Russell King - ARM Linux @ 2013-10-31  0:48 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Oct 30, 2013 at 05:43:38PM -0700, Guenter Roeck wrote:
> On Wed, Oct 30, 2013 at 11:57:00PM +0000, Russell King wrote:
> > Add the module device table declaration so the module can be loaded
> > automatically at boot time.
> > 
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> 
> Hi Russell,
> 
> Wim should have this patch in his queue already, as 'watchdog: imx2_wdt:
> expose module alias for loading from device-tree', submitted by Niels
> de Vos back in July.

Any reason it hasn't made it in yet?  We had a merge window back in
September where, if we're not happy to apply it as a fix during -rc,
it could have gone in.  I see watchdog stuff did merge during the
last merge window...

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] watchdog: imx2_wdt: add module device table
  2013-10-31  0:48     ` Russell King - ARM Linux
  (?)
@ 2013-10-31  8:08     ` Wim Van Sebroeck
  -1 siblings, 0 replies; 7+ messages in thread
From: Wim Van Sebroeck @ 2013-10-31  8:08 UTC (permalink / raw)
  To: Russell King - ARM Linux
  Cc: Guenter Roeck, linux-arm-kernel, Sascha Hauer, Shawn Guo, linux-watchdog

Hi Russel,

> > > Add the module device table declaration so the module can be loaded
> > > automatically at boot time.
> > > 
> > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > 
> > Hi Russell,
> > 
> > Wim should have this patch in his queue already, as 'watchdog: imx2_wdt:
> > expose module alias for loading from device-tree', submitted by Niels
> > de Vos back in July.
> 
> Any reason it hasn't made it in yet?  We had a merge window back in
> September where, if we're not happy to apply it as a fix during -rc,
> it could have gone in.  I see watchdog stuff did merge during the
> last merge window...

Lack of time due to an outsourcing project at a customer of mine.

But the patch is indeed in linux-watchdog-next now.

Kind regards,
Wim.


^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-10-31  8:08 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-30 23:57 [PATCH] watchdog: imx2_wdt: add module device table Russell King
2013-10-30 23:57 ` Russell King
2013-10-31  0:43 ` Guenter Roeck
2013-10-31  0:43   ` Guenter Roeck
2013-10-31  0:48   ` Russell King - ARM Linux
2013-10-31  0:48     ` Russell King - ARM Linux
2013-10-31  8:08     ` Wim Van Sebroeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.