Re: [PATCH RESEND] ARM: tegra: set regulator full constraints

From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org"
	<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH RESEND] ARM: tegra: set regulator full constraints
Date: Mon, 4 Nov 2013 08:18:28 -0800	[thread overview]
Message-ID: <20131104161828.GK2493@sirena.org.uk> (raw)
In-Reply-To: <527737C5.5080901-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

On Mon, Nov 04, 2013 at 01:59:33PM +0800, Wei Ni wrote:

> I didn't find the generic DT init code, do you mean to add it in the
> customize_machine() in arch/arm/kernel/setup.c ? But it isn't only for
> DT systems.

We can do it as part of parsing the DT or deciding to parse the DT.

> How about to add it in the regulator subsystem? I mean we can add
> following codes in the regulator_init() routine in driver/regulator/core.c:
> +#ifdef CONFIG_OF
> +regulator_has_full_constraints();
> +#endif

No, that's not good - we can have DT enabled but boot on a non-DT board.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]