All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: fix the comment explaining xfs_trans_dqlockedjoin
@ 2013-11-06 11:45 Christoph Hellwig
  2013-11-06 12:50 ` Carlos Maiolino
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Christoph Hellwig @ 2013-11-06 11:45 UTC (permalink / raw)
  To: xfs

Signed-off-by: Christoph Hellwig <hch@lst.de>

diff --git a/fs/xfs/xfs_trans_dquot.c b/fs/xfs/xfs_trans_dquot.c
index cd2a10e..4117286 100644
--- a/fs/xfs/xfs_trans_dquot.c
+++ b/fs/xfs/xfs_trans_dquot.c
@@ -295,8 +295,8 @@ xfs_trans_mod_dquot(
 /*
  * Given an array of dqtrx structures, lock all the dquots associated and join
  * them to the transaction, provided they have been modified.  We know that the
- * highest number of dquots of one type - usr, grp OR prj - involved in a
- * transaction is 2 so we don't need to make this very generic.
+ * highest number of dquots of one type - usr, grp and prj - involved in a
+ * transaction is 3 so we don't need to make this very generic.
  */
 STATIC void
 xfs_trans_dqlockedjoin(

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] xfs: fix the comment explaining xfs_trans_dqlockedjoin
  2013-11-06 11:45 [PATCH] xfs: fix the comment explaining xfs_trans_dqlockedjoin Christoph Hellwig
@ 2013-11-06 12:50 ` Carlos Maiolino
  2013-11-15 17:34 ` Christoph Hellwig
  2013-12-04 21:54 ` Ben Myers
  2 siblings, 0 replies; 5+ messages in thread
From: Carlos Maiolino @ 2013-11-06 12:50 UTC (permalink / raw)
  To: xfs

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

On Wed, Nov 06, 2013 at 03:45:36AM -0800, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> diff --git a/fs/xfs/xfs_trans_dquot.c b/fs/xfs/xfs_trans_dquot.c
> index cd2a10e..4117286 100644
> --- a/fs/xfs/xfs_trans_dquot.c
> +++ b/fs/xfs/xfs_trans_dquot.c
> @@ -295,8 +295,8 @@ xfs_trans_mod_dquot(
>  /*
>   * Given an array of dqtrx structures, lock all the dquots associated and join
>   * them to the transaction, provided they have been modified.  We know that the
> - * highest number of dquots of one type - usr, grp OR prj - involved in a
> - * transaction is 2 so we don't need to make this very generic.
> + * highest number of dquots of one type - usr, grp and prj - involved in a
> + * transaction is 3 so we don't need to make this very generic.
>   */
>  STATIC void
>  xfs_trans_dqlockedjoin(
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Carlos

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] xfs: fix the comment explaining xfs_trans_dqlockedjoin
  2013-11-06 11:45 [PATCH] xfs: fix the comment explaining xfs_trans_dqlockedjoin Christoph Hellwig
  2013-11-06 12:50 ` Carlos Maiolino
@ 2013-11-15 17:34 ` Christoph Hellwig
  2013-11-18 15:26   ` Ben Myers
  2013-12-04 21:54 ` Ben Myers
  2 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2013-11-15 17:34 UTC (permalink / raw)
  To: xfs

Not the most important patch ever, but I think it should still be picked
up :)

On Wed, Nov 06, 2013 at 03:45:36AM -0800, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> diff --git a/fs/xfs/xfs_trans_dquot.c b/fs/xfs/xfs_trans_dquot.c
> index cd2a10e..4117286 100644
> --- a/fs/xfs/xfs_trans_dquot.c
> +++ b/fs/xfs/xfs_trans_dquot.c
> @@ -295,8 +295,8 @@ xfs_trans_mod_dquot(
>  /*
>   * Given an array of dqtrx structures, lock all the dquots associated and join
>   * them to the transaction, provided they have been modified.  We know that the
> - * highest number of dquots of one type - usr, grp OR prj - involved in a
> - * transaction is 2 so we don't need to make this very generic.
> + * highest number of dquots of one type - usr, grp and prj - involved in a
> + * transaction is 3 so we don't need to make this very generic.
>   */
>  STATIC void
>  xfs_trans_dqlockedjoin(
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] xfs: fix the comment explaining xfs_trans_dqlockedjoin
  2013-11-15 17:34 ` Christoph Hellwig
@ 2013-11-18 15:26   ` Ben Myers
  0 siblings, 0 replies; 5+ messages in thread
From: Ben Myers @ 2013-11-18 15:26 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs

On Fri, Nov 15, 2013 at 09:34:15AM -0800, Christoph Hellwig wrote:
> Not the most important patch ever, but I think it should still be picked
> up :)

Sure.  We'll get it in once the merge window closes.

-Ben

> On Wed, Nov 06, 2013 at 03:45:36AM -0800, Christoph Hellwig wrote:
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > 
> > diff --git a/fs/xfs/xfs_trans_dquot.c b/fs/xfs/xfs_trans_dquot.c
> > index cd2a10e..4117286 100644
> > --- a/fs/xfs/xfs_trans_dquot.c
> > +++ b/fs/xfs/xfs_trans_dquot.c
> > @@ -295,8 +295,8 @@ xfs_trans_mod_dquot(
> >  /*
> >   * Given an array of dqtrx structures, lock all the dquots associated and join
> >   * them to the transaction, provided they have been modified.  We know that the
> > - * highest number of dquots of one type - usr, grp OR prj - involved in a
> > - * transaction is 2 so we don't need to make this very generic.
> > + * highest number of dquots of one type - usr, grp and prj - involved in a
> > + * transaction is 3 so we don't need to make this very generic.
> >   */
> >  STATIC void
> >  xfs_trans_dqlockedjoin(
> > 
> > _______________________________________________
> > xfs mailing list
> > xfs@oss.sgi.com
> > http://oss.sgi.com/mailman/listinfo/xfs
> ---end quoted text---
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] xfs: fix the comment explaining xfs_trans_dqlockedjoin
  2013-11-06 11:45 [PATCH] xfs: fix the comment explaining xfs_trans_dqlockedjoin Christoph Hellwig
  2013-11-06 12:50 ` Carlos Maiolino
  2013-11-15 17:34 ` Christoph Hellwig
@ 2013-12-04 21:54 ` Ben Myers
  2 siblings, 0 replies; 5+ messages in thread
From: Ben Myers @ 2013-12-04 21:54 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs

On Wed, Nov 06, 2013 at 03:45:36AM -0800, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Applied this.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-12-04 21:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-06 11:45 [PATCH] xfs: fix the comment explaining xfs_trans_dqlockedjoin Christoph Hellwig
2013-11-06 12:50 ` Carlos Maiolino
2013-11-15 17:34 ` Christoph Hellwig
2013-11-18 15:26   ` Ben Myers
2013-12-04 21:54 ` Ben Myers

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.