* kvm unit test fails to build on 32 bit systems
@ 2013-11-11 16:34 Michael S. Tsirkin
2013-11-11 16:59 ` Gleb Natapov
0 siblings, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2013-11-11 16:34 UTC (permalink / raw)
To: kvm
x86/eventinj.c: Assembler messages:
x86/eventinj.c:151: Error: bad register name `%rsp'
x86/eventinj.c:152: Error: bad register name `%rsp'
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: kvm unit test fails to build on 32 bit systems
2013-11-11 16:34 kvm unit test fails to build on 32 bit systems Michael S. Tsirkin
@ 2013-11-11 16:59 ` Gleb Natapov
2013-11-11 18:47 ` Michael S. Tsirkin
0 siblings, 1 reply; 6+ messages in thread
From: Gleb Natapov @ 2013-11-11 16:59 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: kvm
On Mon, Nov 11, 2013 at 06:34:01PM +0200, Michael S. Tsirkin wrote:
> x86/eventinj.c: Assembler messages:
> x86/eventinj.c:151: Error: bad register name `%rsp'
> x86/eventinj.c:152: Error: bad register name `%rsp'
>
How about that?
diff --git a/x86/eventinj.c b/x86/eventinj.c
index 3d36b37..9d4392c 100644
--- a/x86/eventinj.c
+++ b/x86/eventinj.c
@@ -148,8 +148,8 @@ static void nmi_iret_isr(struct ex_regs *r)
s[2] = read_rflags();
s[1] = read_cs();
s[0] = after_iret_addr = (unsigned long)&&after_iret;
- asm ("mov %%rsp, %0\n\t"
- "mov %1, %%rsp\n\t"
+ asm ("mov %%" R "sp, %0\n\t"
+ "mov %1, %%" R "sp\n\t"
"outl %2, $0xe4\n\t" /* flush stack page */
#ifdef __x86_64__
"iretq\n\t"
--
Gleb.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: kvm unit test fails to build on 32 bit systems
2013-11-11 16:59 ` Gleb Natapov
@ 2013-11-11 18:47 ` Michael S. Tsirkin
2013-11-11 18:48 ` Gleb Natapov
0 siblings, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2013-11-11 18:47 UTC (permalink / raw)
To: Gleb Natapov; +Cc: kvm
On Mon, Nov 11, 2013 at 06:59:51PM +0200, Gleb Natapov wrote:
> On Mon, Nov 11, 2013 at 06:34:01PM +0200, Michael S. Tsirkin wrote:
> > x86/eventinj.c: Assembler messages:
> > x86/eventinj.c:151: Error: bad register name `%rsp'
> > x86/eventinj.c:152: Error: bad register name `%rsp'
> >
> How about that?
works for me.
Tested-by: Michael S. Tsirkin <mst@redhat.com>
> diff --git a/x86/eventinj.c b/x86/eventinj.c
> index 3d36b37..9d4392c 100644
> --- a/x86/eventinj.c
> +++ b/x86/eventinj.c
> @@ -148,8 +148,8 @@ static void nmi_iret_isr(struct ex_regs *r)
> s[2] = read_rflags();
> s[1] = read_cs();
> s[0] = after_iret_addr = (unsigned long)&&after_iret;
> - asm ("mov %%rsp, %0\n\t"
> - "mov %1, %%rsp\n\t"
> + asm ("mov %%" R "sp, %0\n\t"
> + "mov %1, %%" R "sp\n\t"
> "outl %2, $0xe4\n\t" /* flush stack page */
> #ifdef __x86_64__
> "iretq\n\t"
> --
> Gleb.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: kvm unit test fails to build on 32 bit systems
2013-11-11 18:47 ` Michael S. Tsirkin
@ 2013-11-11 18:48 ` Gleb Natapov
2013-11-18 19:02 ` Michael S. Tsirkin
0 siblings, 1 reply; 6+ messages in thread
From: Gleb Natapov @ 2013-11-11 18:48 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: kvm
On Mon, Nov 11, 2013 at 08:47:15PM +0200, Michael S. Tsirkin wrote:
> On Mon, Nov 11, 2013 at 06:59:51PM +0200, Gleb Natapov wrote:
> > On Mon, Nov 11, 2013 at 06:34:01PM +0200, Michael S. Tsirkin wrote:
> > > x86/eventinj.c: Assembler messages:
> > > x86/eventinj.c:151: Error: bad register name `%rsp'
> > > x86/eventinj.c:152: Error: bad register name `%rsp'
> > >
> > How about that?
>
>
> works for me.
>
> Tested-by: Michael S. Tsirkin <mst@redhat.com>
>
>
Signed-off-by: Gleb Natapov <gleb@redhat.com>
> > diff --git a/x86/eventinj.c b/x86/eventinj.c
> > index 3d36b37..9d4392c 100644
> > --- a/x86/eventinj.c
> > +++ b/x86/eventinj.c
> > @@ -148,8 +148,8 @@ static void nmi_iret_isr(struct ex_regs *r)
> > s[2] = read_rflags();
> > s[1] = read_cs();
> > s[0] = after_iret_addr = (unsigned long)&&after_iret;
> > - asm ("mov %%rsp, %0\n\t"
> > - "mov %1, %%rsp\n\t"
> > + asm ("mov %%" R "sp, %0\n\t"
> > + "mov %1, %%" R "sp\n\t"
> > "outl %2, $0xe4\n\t" /* flush stack page */
> > #ifdef __x86_64__
> > "iretq\n\t"
> > --
> > Gleb.
--
Gleb.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: kvm unit test fails to build on 32 bit systems
2013-11-11 18:48 ` Gleb Natapov
@ 2013-11-18 19:02 ` Michael S. Tsirkin
2013-11-18 19:05 ` Gleb Natapov
0 siblings, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2013-11-18 19:02 UTC (permalink / raw)
To: Gleb Natapov, pbonzini; +Cc: kvm
On Mon, Nov 11, 2013 at 08:48:23PM +0200, Gleb Natapov wrote:
> On Mon, Nov 11, 2013 at 08:47:15PM +0200, Michael S. Tsirkin wrote:
> > On Mon, Nov 11, 2013 at 06:59:51PM +0200, Gleb Natapov wrote:
> > > On Mon, Nov 11, 2013 at 06:34:01PM +0200, Michael S. Tsirkin wrote:
> > > > x86/eventinj.c: Assembler messages:
> > > > x86/eventinj.c:151: Error: bad register name `%rsp'
> > > > x86/eventinj.c:152: Error: bad register name `%rsp'
> > > >
> > > How about that?
> >
> >
> > works for me.
> >
> > Tested-by: Michael S. Tsirkin <mst@redhat.com>
> >
> >
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
Can this be applied please?
> > > diff --git a/x86/eventinj.c b/x86/eventinj.c
> > > index 3d36b37..9d4392c 100644
> > > --- a/x86/eventinj.c
> > > +++ b/x86/eventinj.c
> > > @@ -148,8 +148,8 @@ static void nmi_iret_isr(struct ex_regs *r)
> > > s[2] = read_rflags();
> > > s[1] = read_cs();
> > > s[0] = after_iret_addr = (unsigned long)&&after_iret;
> > > - asm ("mov %%rsp, %0\n\t"
> > > - "mov %1, %%rsp\n\t"
> > > + asm ("mov %%" R "sp, %0\n\t"
> > > + "mov %1, %%" R "sp\n\t"
> > > "outl %2, $0xe4\n\t" /* flush stack page */
> > > #ifdef __x86_64__
> > > "iretq\n\t"
> > > --
> > > Gleb.
>
> --
> Gleb.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: kvm unit test fails to build on 32 bit systems
2013-11-18 19:02 ` Michael S. Tsirkin
@ 2013-11-18 19:05 ` Gleb Natapov
0 siblings, 0 replies; 6+ messages in thread
From: Gleb Natapov @ 2013-11-18 19:05 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: pbonzini, kvm
On Mon, Nov 18, 2013 at 09:02:39PM +0200, Michael S. Tsirkin wrote:
> On Mon, Nov 11, 2013 at 08:48:23PM +0200, Gleb Natapov wrote:
> > On Mon, Nov 11, 2013 at 08:47:15PM +0200, Michael S. Tsirkin wrote:
> > > On Mon, Nov 11, 2013 at 06:59:51PM +0200, Gleb Natapov wrote:
> > > > On Mon, Nov 11, 2013 at 06:34:01PM +0200, Michael S. Tsirkin wrote:
> > > > > x86/eventinj.c: Assembler messages:
> > > > > x86/eventinj.c:151: Error: bad register name `%rsp'
> > > > > x86/eventinj.c:152: Error: bad register name `%rsp'
> > > > >
> > > > How about that?
> > >
> > >
> > > works for me.
> > >
> > > Tested-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > >
> >
> > Signed-off-by: Gleb Natapov <gleb@redhat.com>
>
> Can this be applied please?
>
I applied, but haven't pushed. Will do.
> > > > diff --git a/x86/eventinj.c b/x86/eventinj.c
> > > > index 3d36b37..9d4392c 100644
> > > > --- a/x86/eventinj.c
> > > > +++ b/x86/eventinj.c
> > > > @@ -148,8 +148,8 @@ static void nmi_iret_isr(struct ex_regs *r)
> > > > s[2] = read_rflags();
> > > > s[1] = read_cs();
> > > > s[0] = after_iret_addr = (unsigned long)&&after_iret;
> > > > - asm ("mov %%rsp, %0\n\t"
> > > > - "mov %1, %%rsp\n\t"
> > > > + asm ("mov %%" R "sp, %0\n\t"
> > > > + "mov %1, %%" R "sp\n\t"
> > > > "outl %2, $0xe4\n\t" /* flush stack page */
> > > > #ifdef __x86_64__
> > > > "iretq\n\t"
> > > > --
> > > > Gleb.
> >
> > --
> > Gleb.
--
Gleb.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-18 19:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-11 16:34 kvm unit test fails to build on 32 bit systems Michael S. Tsirkin
2013-11-11 16:59 ` Gleb Natapov
2013-11-11 18:47 ` Michael S. Tsirkin
2013-11-11 18:48 ` Gleb Natapov
2013-11-18 19:02 ` Michael S. Tsirkin
2013-11-18 19:05 ` Gleb Natapov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.