Re: [PATCH v2 2/2] dt: binding: sound cs42l52 driver

From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Brian Austin
	<brian.austin-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH v2 2/2] dt: binding: sound cs42l52 driver
Date: Wed, 13 Nov 2013 16:43:28 +0000	[thread overview]
Message-ID: <20131113164328.GW878@sirena.org.uk> (raw)
In-Reply-To: <1485256.GGQxcSNhvH@flatron>

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

On Wed, Nov 13, 2013 at 05:33:30PM +0100, Tomasz Figa wrote:
> On Wednesday 13 of November 2013 09:44:34 Brian Austin wrote:

> > +  - reset-gpio : GPIO controller's phandle and the number
> > +		 of the GPIO used to reset the codec.

> As Kumar has already mentioned, all device-specific properties should be
> prefixed with vendor prefix, "cirrus," in this case.

The best practice on this one seems to vary somewhat randomly -
sometimes it's a requirement, sometimes it isn't.

> > +codec: cs42l52@4a {

> coding style: Node name should be generic, i.e. codec@4a.

Is this a constructive thing from a style point of view?  We're not
allowed to actually do anything useful with the value at runtime so
people may as well choose what they like.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]