Re: [PATCH v2 2/2] dt: binding: sound cs42l52 driver

From: Mark Brown <broonie@kernel.org>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	Brian Austin <brian.austin@cirrus.com>,
	alsa-devel@alsa-project.org, rob.herring@calxeda.com,
	lgirdwood@gmail.com
Subject: Re: [PATCH v2 2/2] dt: binding: sound cs42l52 driver
Date: Wed, 13 Nov 2013 19:49:15 +0000	[thread overview]
Message-ID: <20131113194915.GF878@sirena.org.uk> (raw)
In-Reply-To: <1799362.QSDMu6GHtU@flatron>

[-- Attachment #1.1: Type: text/plain, Size: 831 bytes --]

On Wed, Nov 13, 2013 at 07:24:04PM +0100, Tomasz Figa wrote:

> Well, the label is just for the parser and it does not get into the DTB.
> This is where the DTS author can make things up just for their own
> convenience (like main_codec, aux_codec or even cs42l52). 

If only we could have comments :)

> I know this is really more bikeshedding than anything useful, but I'd
> rather try to follow the written rules in ePAPR, instead of nothing at
> all. At least just to make things more consistent.

My feeling here is that we should be looking more critically at ePAPR -
if we're picking people up for having what's essentially a comment
that's too specific we're probably doing something wrong especially
since the corrected example would look something like:

	codec: codec@12 {

which is a bit redundant.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]