From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Wang Weidong <wangweidong1@huawei.com>
Cc: davem@davemloft.net, gerrit@erg.abdn.ac.uk, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
vyasevich@gmail.com, nhorman@tuxdriver.com, dccp@vger.kernel.org,
netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
dingtianhong@huawei.com
Subject: Re: [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6_pinfo
Date: Tue, 19 Nov 2013 04:14:09 +0100 [thread overview]
Message-ID: <20131119031408.GQ16541@order.stressinduktion.org> (raw)
In-Reply-To: <1384829247-8624-3-git-send-email-wangweidong1@huawei.com>
On Tue, Nov 19, 2013 at 10:47:27AM +0800, Wang Weidong wrote:
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index 0740f93..83d011e 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -1116,6 +1116,10 @@ static struct sock * tcp_v6_syn_recv_sock(struct sock *sk, struct sk_buff *skb,
> newtp = tcp_sk(newsk);
>
> memcpy(newnp, np, sizeof(struct ipv6_pinfo));
> + /* Don't forget copy the rcv_saddr and daddr when
> + * copy ipv6_pinfo.
> + */
> + sk_v6_copy_addrs(newsk, sk);
>
> ipv6_addr_set_v4mapped(newinet->inet_daddr, &newsk->sk_v6_daddr);
>
Hmm, how did you spot this?
Greetings,
Hannes
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Wang Weidong <wangweidong1@huawei.com>
Cc: davem@davemloft.net, gerrit@erg.abdn.ac.uk, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
vyasevich@gmail.com, nhorman@tuxdriver.com, dccp@vger.kernel.org,
netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
dingtianhong@huawei.com
Subject: Re: [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6_pinfo
Date: Tue, 19 Nov 2013 03:14:09 +0000 [thread overview]
Message-ID: <20131119031408.GQ16541@order.stressinduktion.org> (raw)
In-Reply-To: <1384829247-8624-3-git-send-email-wangweidong1@huawei.com>
On Tue, Nov 19, 2013 at 10:47:27AM +0800, Wang Weidong wrote:
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index 0740f93..83d011e 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -1116,6 +1116,10 @@ static struct sock * tcp_v6_syn_recv_sock(struct sock *sk, struct sk_buff *skb,
> newtp = tcp_sk(newsk);
>
> memcpy(newnp, np, sizeof(struct ipv6_pinfo));
> + /* Don't forget copy the rcv_saddr and daddr when
> + * copy ipv6_pinfo.
> + */
> + sk_v6_copy_addrs(newsk, sk);
>
> ipv6_addr_set_v4mapped(newinet->inet_daddr, &newsk->sk_v6_daddr);
>
Hmm, how did you spot this?
Greetings,
Hannes
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6_pinfo
Date: Tue, 19 Nov 2013 03:14:09 +0000 [thread overview]
Message-ID: <20131119031408.GQ16541@order.stressinduktion.org> (raw)
In-Reply-To: <1384829247-8624-3-git-send-email-wangweidong1@huawei.com>
On Tue, Nov 19, 2013 at 10:47:27AM +0800, Wang Weidong wrote:
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index 0740f93..83d011e 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -1116,6 +1116,10 @@ static struct sock * tcp_v6_syn_recv_sock(struct sock *sk, struct sk_buff *skb,
> newtp = tcp_sk(newsk);
>
> memcpy(newnp, np, sizeof(struct ipv6_pinfo));
> + /* Don't forget copy the rcv_saddr and daddr when
> + * copy ipv6_pinfo.
> + */
> + sk_v6_copy_addrs(newsk, sk);
>
> ipv6_addr_set_v4mapped(newinet->inet_daddr, &newsk->sk_v6_daddr);
>
Hmm, how did you spot this?
Greetings,
Hannes
next prev parent reply other threads:[~2013-11-19 3:14 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 2:47 [PATCH 0/2] ipv6: fix the missing copies when memcpy ipv6_pinfo Wang Weidong
2013-11-19 2:47 ` Wang Weidong
2013-11-19 2:47 ` Wang Weidong
2013-11-19 2:47 ` [PATCH 1/2] ipv6: add helper function for copy addrs from old sock Wang Weidong
2013-11-19 2:47 ` Wang Weidong
2013-11-19 2:47 ` Wang Weidong
2013-11-19 2:47 ` [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6_pinfo Wang Weidong
2013-11-19 2:47 ` Wang Weidong
2013-11-19 2:47 ` Wang Weidong
2013-11-19 3:14 ` Hannes Frederic Sowa [this message]
2013-11-19 3:14 ` Hannes Frederic Sowa
2013-11-19 3:14 ` Hannes Frederic Sowa
2013-11-19 3:32 ` wangweidong
2013-11-19 3:32 ` wangweidong
2013-11-19 3:32 ` wangweidong
2013-11-19 3:58 ` Eric Dumazet
2013-11-19 3:58 ` Eric Dumazet
2013-11-19 3:58 ` Eric Dumazet
2013-11-19 4:00 ` Eric Dumazet
2013-11-19 4:00 ` Eric Dumazet
2013-11-19 4:00 ` Eric Dumazet
2013-11-19 4:44 ` wangweidong
2013-11-19 4:44 ` wangweidong
2013-11-19 4:44 ` wangweidong
2013-11-19 11:35 ` Daniel Borkmann
2013-11-19 11:35 ` Daniel Borkmann
2013-11-19 11:35 ` Daniel Borkmann
2013-11-19 14:23 ` Eric Dumazet
2013-11-19 14:23 ` Eric Dumazet
2013-11-19 14:23 ` Eric Dumazet
2013-11-19 14:26 ` Daniel Borkmann
2013-11-19 14:26 ` Daniel Borkmann
2013-11-19 14:26 ` Daniel Borkmann
2013-11-19 15:25 ` Vlad Yasevich
2013-11-19 15:25 ` Vlad Yasevich
2013-11-19 15:25 ` Vlad Yasevich
2013-11-19 11:04 ` Daniel Borkmann
2013-11-19 11:04 ` Daniel Borkmann
2013-11-19 11:04 ` Daniel Borkmann
2013-11-19 11:09 ` wangweidong
2013-11-19 11:09 ` wangweidong
2013-11-19 11:09 ` wangweidong
2013-11-19 3:55 ` Eric Dumazet
2013-11-19 3:55 ` Eric Dumazet
2013-11-19 3:55 ` Eric Dumazet
2013-11-19 4:38 ` wangweidong
2013-11-19 4:38 ` wangweidong
2013-11-19 4:38 ` wangweidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119031408.GQ16541@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=dingtianhong@huawei.com \
--cc=gerrit@erg.abdn.ac.uk \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
--cc=wangweidong1@huawei.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.