From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3/6] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v7
Date: Sat, 14 Dec 2013 12:33:42 +0100 [thread overview]
Message-ID: <20131214113342.GM9804@phenom.ffwll.local> (raw)
In-Reply-To: <20131214104406.GH9804@phenom.ffwll.local>
On Sat, Dec 14, 2013 at 11:44:06AM +0100, Daniel Vetter wrote:
> On Fri, Dec 13, 2013 at 04:43:50PM -0800, Jesse Barnes wrote:
> > This is just fixing up existing code to use the new field name, so no
> > functional change. I see what you mean about splitting out the field
> > change, but now that would be a pain :/
>
> Yeah, the switch from struct to pointer for ifbdev->fb would be neat as a
> separate patch, but also real pain to split out now.
I'm inclined to say that we actually need the split-out conversion to a
pointer. I might have lost my traces somewhere in this maze, but I think
with the current patches we can have a NULL deref on ifbdev->fb in
intelfb_create. Not sure, but a split-out patch would definitely help ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-12-14 11:32 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 20:41 [PATCH 1/6] drm/i915: unconditionally copy mode into crtc at boot time Jesse Barnes
2013-12-12 20:41 ` [PATCH 2/6] drm/i915: retrieve current fb config into new plane_config structure at init Jesse Barnes
2013-12-14 11:01 ` Daniel Vetter
2013-12-17 0:01 ` Jesse Barnes
2013-12-17 8:38 ` Daniel Vetter
2013-12-17 21:04 ` Jesse Barnes
2013-12-17 21:19 ` Daniel Vetter
2013-12-12 20:41 ` [PATCH 3/6] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v7 Jesse Barnes
2013-12-12 22:54 ` Daniel Vetter
2013-12-12 23:45 ` Jesse Barnes
2013-12-13 19:09 ` Jesse Barnes
2013-12-13 20:47 ` Daniel Vetter
2013-12-14 0:43 ` Jesse Barnes
2013-12-14 10:44 ` Daniel Vetter
2013-12-14 11:33 ` Daniel Vetter [this message]
2013-12-14 11:13 ` Daniel Vetter
2013-12-14 11:36 ` Daniel Vetter
2014-02-05 14:57 ` Jesse Barnes
2013-12-12 20:41 ` [PATCH 4/6] drm/i915: don't memset the fb buffer if preallocated Jesse Barnes
2013-12-14 11:28 ` Daniel Vetter
2013-12-17 0:17 ` Jesse Barnes
2013-12-17 7:56 ` Daniel Vetter
2013-12-12 20:41 ` [PATCH 5/6] drm/i915/vlv: move DPIO init earlier v2 Jesse Barnes
2013-12-14 10:47 ` Daniel Vetter
2013-12-17 0:02 ` Jesse Barnes
2013-12-12 20:41 ` [PATCH 6/6] drm/i915: inform drm_fb_helper if we abandoned a connected output Jesse Barnes
2013-12-12 22:30 ` Chris Wilson
2013-12-12 22:34 ` Jesse Barnes
2013-12-17 0:18 ` Jesse Barnes
2013-12-12 21:21 ` [PATCH 1/6] drm/i915: unconditionally copy mode into crtc at boot time Daniel Vetter
2013-12-12 21:29 ` Jesse Barnes
2013-12-12 22:39 ` Daniel Vetter
2013-12-12 22:44 ` Jesse Barnes
2013-12-12 23:04 ` Daniel Vetter
2013-12-17 0:35 ` Jesse Barnes
2013-12-17 8:00 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131214113342.GM9804@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.