* losetup "-p" option is not documented
@ 2013-12-18 22:32 Dale R. Worley
2013-12-19 9:46 ` Sami Kerola
0 siblings, 1 reply; 3+ messages in thread
From: Dale R. Worley @ 2013-12-18 22:32 UTC (permalink / raw)
To: util-linux
(My understanding is that this is the correct place to report bugs for
util-linux.)
In the manual page for losetup (in util-linux-2.23.2-4.fc19.x86_64) is
the text:
Setup loop device:
losetup [-o offset] [--sizelimit size]
[-p pfd] [-rP] {-f[--show]|loopdev} file
However, the "-p" option is not described in the text.
There also should be a space after "-f".
Thanks for attending to this,
Dale
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: losetup "-p" option is not documented
2013-12-18 22:32 losetup "-p" option is not documented Dale R. Worley
@ 2013-12-19 9:46 ` Sami Kerola
2014-01-06 8:09 ` Karel Zak
0 siblings, 1 reply; 3+ messages in thread
From: Sami Kerola @ 2013-12-19 9:46 UTC (permalink / raw)
To: Dale R. Worley; +Cc: util-linux
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On 18 December 2013 22:32, Dale R. Worley <worley@alum.mit.edu> wrote:
> (My understanding is that this is the correct place to report bugs for
> util-linux.)
Hi Dale,
Correct. You reached right audience.
> In the manual page for losetup (in util-linux-2.23.2-4.fc19.x86_64) is
> the text:
>
> Setup loop device:
>
> losetup [-o offset] [--sizelimit size]
> [-p pfd] [-rP] {-f[--show]|loopdev} file
>
> However, the "-p" option is not described in the text.
>
> There also should be a space after "-f".
That help output looks a little old. Never the less the point about
manual page not informing the --pass-fd not being supported is valid.
Karel, sorry about the attachment. Mail relays in the office are git
send-email hostile.
--
Sami Kerola
http://www.iki.fi/kerolasa/
[-- Attachment #2: 0001-losetup-mention-in-manual-page-pass-fd-is-not-supporte.txt --]
[-- Type: text/plain, Size: 1340 bytes --]
From 1ec7f343d460f702f79c39538025ef6fca0548c7 Mon Sep 17 00:00:00 2001
From: Sami Kerola <sami.kerola@sabre.com>
Date: Thu, 19 Dec 2013 09:41:18 +0000
Subject: [PATCH] losetup: mention in manual page --pass-fd is not supported
Organization: lastminute.com
And suppress warn() errno conversion to 'Success' that does not make
sense.
Signed-off-by: Sami Kerola <sami.kerola@sabre.com>
---
sys-utils/losetup.8 | 2 ++
sys-utils/losetup.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/sys-utils/losetup.8 b/sys-utils/losetup.8
index c61a61e..1099210 100644
--- a/sys-utils/losetup.8
+++ b/sys-utils/losetup.8
@@ -122,6 +122,8 @@ option and a
argument are present.
.IP "\fB\-v, \-\-verbose\fP"
verbose mode
+.IP "\fB\-p, \-\-pass-fd\fP \fIfile descriptior\fP"
+This option is no longer supported.
.SH ENCRYPTION
.B Cryptoloop is no longer supported in favor of dm-crypt. For more details see
diff --git a/sys-utils/losetup.c b/sys-utils/losetup.c
index 70d9155..7708fd9 100644
--- a/sys-utils/losetup.c
+++ b/sys-utils/losetup.c
@@ -538,7 +538,7 @@ int main(int argc, char **argv)
list = 1;
break;
case 'p':
- warn(_("--pass-fd is no longer supported"));
+ warnx(_("--pass-fd is no longer supported"));
break;
case 'P':
lo_flags |= LO_FLAGS_PARTSCAN;
--
1.8.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: losetup "-p" option is not documented
2013-12-19 9:46 ` Sami Kerola
@ 2014-01-06 8:09 ` Karel Zak
0 siblings, 0 replies; 3+ messages in thread
From: Karel Zak @ 2014-01-06 8:09 UTC (permalink / raw)
To: kerolasa; +Cc: Dale R. Worley, util-linux
On Thu, Dec 19, 2013 at 09:46:27AM +0000, Sami Kerola wrote:
> +.IP "\fB\-p, \-\-pass-fd\fP \fIfile descriptior\fP"
> +This option is no longer supported.
>
> .SH ENCRYPTION
> .B Cryptoloop is no longer supported in favor of dm-crypt. For more details see
> diff --git a/sys-utils/losetup.c b/sys-utils/losetup.c
> index 70d9155..7708fd9 100644
> --- a/sys-utils/losetup.c
> +++ b/sys-utils/losetup.c
> @@ -538,7 +538,7 @@ int main(int argc, char **argv)
> list = 1;
> break;
> case 'p':
> - warn(_("--pass-fd is no longer supported"));
> + warnx(_("--pass-fd is no longer supported"));
> break;
I have removed the option (and also -e and -E) from code and man page
at all, I don't think we have to maintain the warnings for ever.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-06 8:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-18 22:32 losetup "-p" option is not documented Dale R. Worley
2013-12-19 9:46 ` Sami Kerola
2014-01-06 8:09 ` Karel Zak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.