All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [net-next/master PATCH] lib: fix compile warning in hashlib_init
       [not found] <1387415314-21786-1-git-send-email-gaowanlong@cn.fujitsu.com>
@ 2013-12-19  1:15 ` Fengguang Wu
  2013-12-19  1:32   ` Daniel Borkmann
  0 siblings, 1 reply; 4+ messages in thread
From: Fengguang Wu @ 2013-12-19  1:15 UTC (permalink / raw)
  To: Wanlong Gao; +Cc: davem, ffusco, kbuild-all, netdev, LKML

CC the list.

On Thu, Dec 19, 2013 at 09:08:34AM +0800, Wanlong Gao wrote:
> /git/linux/lib/hash.c: In function 'hashlib_init':
> /git/linux/lib/hash.c:35:2: warning: passing argument 1 of 'setup_arch_fast_hash' from incompatible pointer type [enabled by default]
> /git/linux/include/asm-generic/hash.h:5:20: note: expected 'struct arch_hash_ops *' but argument is of type 'struct fast_hash_ops *'
> 
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
>  include/asm-generic/hash.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/asm-generic/hash.h b/include/asm-generic/hash.h
> index 05cb342..b631284 100644
> --- a/include/asm-generic/hash.h
> +++ b/include/asm-generic/hash.h
> @@ -1,8 +1,8 @@
>  #ifndef __ASM_GENERIC_HASH_H
>  #define __ASM_GENERIC_HASH_H
>  
> -struct arch_hash_ops;
> -static inline void setup_arch_fast_hash(struct arch_hash_ops *ops)
> +struct fast_hash_ops;
> +static inline void setup_arch_fast_hash(struct fast_hash_ops *ops)
>  {
>  }
>  
> -- 
> 1.8.5.2.192.g7794a68

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [net-next/master PATCH] lib: fix compile warning in hashlib_init
  2013-12-19  1:15 ` [net-next/master PATCH] lib: fix compile warning in hashlib_init Fengguang Wu
@ 2013-12-19  1:32   ` Daniel Borkmann
  2013-12-19  1:36     ` Wanlong Gao
  2013-12-19  5:15     ` David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Daniel Borkmann @ 2013-12-19  1:32 UTC (permalink / raw)
  To: Fengguang Wu; +Cc: Wanlong Gao, davem, ffusco, kbuild-all, netdev, LKML

On 12/19/2013 02:15 AM, Fengguang Wu wrote:
> CC the list.
>
> On Thu, Dec 19, 2013 at 09:08:34AM +0800, Wanlong Gao wrote:
>> /git/linux/lib/hash.c: In function 'hashlib_init':
>> /git/linux/lib/hash.c:35:2: warning: passing argument 1 of 'setup_arch_fast_hash' from incompatible pointer type [enabled by default]
>> /git/linux/include/asm-generic/hash.h:5:20: note: expected 'struct arch_hash_ops *' but argument is of type 'struct fast_hash_ops *'
>>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

That's already in netdev patchwork:

http://patchwork.ozlabs.org/patch/302908/

Thanks !

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [net-next/master PATCH] lib: fix compile warning in hashlib_init
  2013-12-19  1:32   ` Daniel Borkmann
@ 2013-12-19  1:36     ` Wanlong Gao
  2013-12-19  5:15     ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: Wanlong Gao @ 2013-12-19  1:36 UTC (permalink / raw)
  To: Daniel Borkmann; +Cc: Fengguang Wu, davem, ffusco, kbuild-all, netdev, LKML

On 12/19/2013 09:32 AM, Daniel Borkmann wrote:
> On 12/19/2013 02:15 AM, Fengguang Wu wrote:
>> CC the list.
>>
>> On Thu, Dec 19, 2013 at 09:08:34AM +0800, Wanlong Gao wrote:
>>> /git/linux/lib/hash.c: In function 'hashlib_init':
>>> /git/linux/lib/hash.c:35:2: warning: passing argument 1 of 'setup_arch_fast_hash' from incompatible pointer type [enabled by default]
>>> /git/linux/include/asm-generic/hash.h:5:20: note: expected 'struct arch_hash_ops *' but argument is of type 'struct fast_hash_ops *'
>>>
>>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>>> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> 
> That's already in netdev patchwork:
> 
> http://patchwork.ozlabs.org/patch/302908/

Nice, thank you.

Regards,
Wanlong Gao

> 
> Thanks !
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [net-next/master PATCH] lib: fix compile warning in hashlib_init
  2013-12-19  1:32   ` Daniel Borkmann
  2013-12-19  1:36     ` Wanlong Gao
@ 2013-12-19  5:15     ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2013-12-19  5:15 UTC (permalink / raw)
  To: borkmann
  Cc: fengguang.wu, gaowanlong, ffusco, kbuild-all, netdev, linux-kernel

From: Daniel Borkmann <borkmann@iogearbox.net>
Date: Thu, 19 Dec 2013 02:32:02 +0100

> On 12/19/2013 02:15 AM, Fengguang Wu wrote:
>> CC the list.
>>
>> On Thu, Dec 19, 2013 at 09:08:34AM +0800, Wanlong Gao wrote:
>>> /git/linux/lib/hash.c: In function 'hashlib_init':
>>> /git/linux/lib/hash.c:35:2: warning: passing argument 1 of
>>> 'setup_arch_fast_hash' from incompatible pointer type [enabled by
>>> default]
>>> /git/linux/include/asm-generic/hash.h:5:20: note: expected 'struct
>>> arch_hash_ops *' but argument is of type 'struct fast_hash_ops *'
>>>
>>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>>> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> 
> That's already in netdev patchwork:
> 
> http://patchwork.ozlabs.org/patch/302908/

And I've applied it, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-12-19  5:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1387415314-21786-1-git-send-email-gaowanlong@cn.fujitsu.com>
2013-12-19  1:15 ` [net-next/master PATCH] lib: fix compile warning in hashlib_init Fengguang Wu
2013-12-19  1:32   ` Daniel Borkmann
2013-12-19  1:36     ` Wanlong Gao
2013-12-19  5:15     ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.