All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] ARM: dts: imx6qdl-sabresd: Add power key support
  2013-12-19 17:25 ` Anson Huang
@ 2013-12-19  6:08     ` Shawn Guo
  -1 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2013-12-19  6:08 UTC (permalink / raw)
  To: Anson Huang
  Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Thu, Dec 19, 2013 at 12:25:34PM -0500, Anson Huang wrote:
> This patch adds support for imx6qdl-sabresd board's power
> key, the key is named "SW1" on board, press it can wake up
> system from suspend.
> 
> Signed-off-by: Anson Huang <b20788-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index e75e11b..85e3487 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -47,6 +47,13 @@
>  	gpio-keys {
>  		compatible = "gpio-keys";
>  
> +		power {
> +			label = "Power Button";
> +			gpios = <&gpio3 29 0>;
> +			linux,code = <116>; /* KEY_POWER */

The patch looks good.  But I want to ask for more.

 - Move linux,code to the bottom, so that it follows the order used in
   volume-up and volume-down.

 - Replace magic number 116 with macro KEY_POWER defined in
   include/dt-bindings/input/input.h, as well as the numbers in
   volume-up and volume-down.

 - Create a pinctrl entry in gpio-keys node, and move the following out
   from pinctrl_hog into there.

	MX6QDL_PAD_EIM_D29__GPIO3_IO29
	MX6QDL_PAD_GPIO_4__GPIO1_IO04
	MX6QDL_PAD_GPIO_5__GPIO1_IO05

Shawn

> +			gpio-key,wakeup;
> +		};
> +
>  		volume-up {
>  			label = "Volume Up";
>  			gpios = <&gpio1 4 0>;
> @@ -182,6 +189,7 @@
>  				MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000
>  				MX6QDL_PAD_EIM_D22__GPIO3_IO22  0x80000000
>  				MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000
> +				MX6QDL_PAD_EIM_D29__GPIO3_IO29 0x80000000
>  			>;
>  		};
>  	};
> -- 
> 1.7.9.5
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx6qdl-sabresd: Add power key support
@ 2013-12-19  6:08     ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2013-12-19  6:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Dec 19, 2013 at 12:25:34PM -0500, Anson Huang wrote:
> This patch adds support for imx6qdl-sabresd board's power
> key, the key is named "SW1" on board, press it can wake up
> system from suspend.
> 
> Signed-off-by: Anson Huang <b20788@freescale.com>
> ---
>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index e75e11b..85e3487 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -47,6 +47,13 @@
>  	gpio-keys {
>  		compatible = "gpio-keys";
>  
> +		power {
> +			label = "Power Button";
> +			gpios = <&gpio3 29 0>;
> +			linux,code = <116>; /* KEY_POWER */

The patch looks good.  But I want to ask for more.

 - Move linux,code to the bottom, so that it follows the order used in
   volume-up and volume-down.

 - Replace magic number 116 with macro KEY_POWER defined in
   include/dt-bindings/input/input.h, as well as the numbers in
   volume-up and volume-down.

 - Create a pinctrl entry in gpio-keys node, and move the following out
   from pinctrl_hog into there.

	MX6QDL_PAD_EIM_D29__GPIO3_IO29
	MX6QDL_PAD_GPIO_4__GPIO1_IO04
	MX6QDL_PAD_GPIO_5__GPIO1_IO05

Shawn

> +			gpio-key,wakeup;
> +		};
> +
>  		volume-up {
>  			label = "Volume Up";
>  			gpios = <&gpio1 4 0>;
> @@ -182,6 +189,7 @@
>  				MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000
>  				MX6QDL_PAD_EIM_D22__GPIO3_IO22  0x80000000
>  				MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000
> +				MX6QDL_PAD_EIM_D29__GPIO3_IO29 0x80000000
>  			>;
>  		};
>  	};
> -- 
> 1.7.9.5
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx6qdl-sabresd: Add power key support
@ 2013-12-19 17:25 ` Anson Huang
  0 siblings, 0 replies; 4+ messages in thread
From: Anson Huang @ 2013-12-19 17:25 UTC (permalink / raw)
  To: shawn.guo-QSEj5FYQhm4dnm+yROfE0A, kernel-bIcnvbaLZ9MEGnE8C9+IrQ
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

This patch adds support for imx6qdl-sabresd board's power
key, the key is named "SW1" on board, press it can wake up
system from suspend.

Signed-off-by: Anson Huang <b20788-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index e75e11b..85e3487 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -47,6 +47,13 @@
 	gpio-keys {
 		compatible = "gpio-keys";
 
+		power {
+			label = "Power Button";
+			gpios = <&gpio3 29 0>;
+			linux,code = <116>; /* KEY_POWER */
+			gpio-key,wakeup;
+		};
+
 		volume-up {
 			label = "Volume Up";
 			gpios = <&gpio1 4 0>;
@@ -182,6 +189,7 @@
 				MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000
 				MX6QDL_PAD_EIM_D22__GPIO3_IO22  0x80000000
 				MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000
+				MX6QDL_PAD_EIM_D29__GPIO3_IO29 0x80000000
 			>;
 		};
 	};
-- 
1.7.9.5


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx6qdl-sabresd: Add power key support
@ 2013-12-19 17:25 ` Anson Huang
  0 siblings, 0 replies; 4+ messages in thread
From: Anson Huang @ 2013-12-19 17:25 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds support for imx6qdl-sabresd board's power
key, the key is named "SW1" on board, press it can wake up
system from suspend.

Signed-off-by: Anson Huang <b20788@freescale.com>
---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index e75e11b..85e3487 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -47,6 +47,13 @@
 	gpio-keys {
 		compatible = "gpio-keys";
 
+		power {
+			label = "Power Button";
+			gpios = <&gpio3 29 0>;
+			linux,code = <116>; /* KEY_POWER */
+			gpio-key,wakeup;
+		};
+
 		volume-up {
 			label = "Volume Up";
 			gpios = <&gpio1 4 0>;
@@ -182,6 +189,7 @@
 				MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000
 				MX6QDL_PAD_EIM_D22__GPIO3_IO22  0x80000000
 				MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000
+				MX6QDL_PAD_EIM_D29__GPIO3_IO29 0x80000000
 			>;
 		};
 	};
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-19 17:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-19 17:25 [PATCH] ARM: dts: imx6qdl-sabresd: Add power key support Anson Huang
2013-12-19 17:25 ` Anson Huang
     [not found] ` <1387473934-10188-1-git-send-email-b20788-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-19  6:08   ` Shawn Guo
2013-12-19  6:08     ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.